Odoo Changelog — 2024-02-23

Friday, February 23, 2024

2 changes

Branch: master

1 change

Refactoring(1)

Code cleanup and technical improvements

[REF] *: list: stop using onWillUpdateProps to compute columns

PR #56589

Enterprisemasteraccount_reportsspreadsheet_editionweb_studio

List views in reporting, spreadsheets, and Studio now update their visible columns more reliably when related field values change. This reduces the chance that users see outdated or incorrectly hidden columns after data changes.

Original PR description

*account_reports,spreadsheet_edition,web_studio

This commit is the counterpart of odoo/odoo#153998, where we stop computing list's columns in onWillUpdateProps. Using this hook is often a mistake, as it is only called when the component is re-rendered via a parent. With the fine-grained reactivity, it may happen that the renderer is re-rendered directly (e.g. because it is subscribed to a reactive object that changes). In this case, onWillUpdateProps isn't called, so we don't recompute the columns.

Before this commit, this doesn't seem to be possible, but by removing the evalViewModifier props, which is the other change done by this commit, the problem occurs: if a column has a conditional column_invisible attribute, and a field used to evaluate the expression changes, the renderer is re-rendered, as it is the one who is subscribed, whereas before it was the parent (the one defining evalViewModifier).

Preliminary ref for task 3649970

#list-view#columns#reliability

Branch: 17.0

1 change

Refactoring(1)

Code cleanup and technical improvements

[FW][16.0][REF] mrp: refactor action_unbuild() for stock move line creation

PR #154667

Core17.0mrp

The manufacturing unbuild process has been restructured to make it easier for developers to customize and extend. Previously, adding new parameters to unbuild operations required completely rewriting the entire function. Now developers can make targeted modifications to specific parts of the process, reducing complexity and maintenance burden.

Original PR description

With the current design, when we want to pass more parameters from the original move lines of MO to the unbuild move lines, we can't easily extend action_unbuild() and it seems we need to completely override it.

After this refactoring commit, developers can easily extend and add more parameters.

@qrtl



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#151983

#refactoring#extensibility#developer-experience#manufacturing

*account_reports,spreadsheet_edition,web_studio This commit is the counterpart of odoo/odoo#153998, where we stop computing list's columns in onWillUpdateProps. Using this hook is often a mistake, as it is only called when the component is re-rendered via a parent. With the fine-grained reactivity, it may happen that the renderer is re-rendered directly (e.g. because it is subscribed to a reactive object that changes). In this case, onWillUpdateProps isn't called, so we don't recompute the columns. Before this commit, this doesn't seem to be possible, but by removing the evalViewModifier props, which is the other change done by this commit, the problem occurs: if a column has a conditional column_invisible attribute, and a field used to evaluate the expression changes, the renderer is re-rendered, as it is the one who is subscribed, whereas before it was the parent (the one defining evalViewModifier). Preliminary ref for task 3649970

With the current design, when we want to pass more parameters from the original move lines of MO to the unbuild move lines, we can't easily extend action_unbuild() and it seems we need to completely override it. After this refactoring commit, developers can easily extend and add more parameters. @qrtl --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#151983