Wednesday, February 28, 2024
9 changes · 17.0
Enhancements to existing features
This update adjusts the performance test thresholds in the mail module to match the latest system benchmarks. The changes ensure that performance tests accurately reflect current system capabilities and prevent false test failures due to outdated baseline metrics.
Original PR description
Based on last runbot counters
Resolved issues and error corrections
This update corrects a configuration issue in the HR Payroll Holidays module where its test class was incorrectly inheriting from an invoicing test class, even though the module doesn't use accounting features. This fix ensures the module's tests run properly without unnecessary dependencies.
Original PR description
This fixes an issue with the common test class in hr_payroll_holidays which is set to inherit from the invoicing test common class while the module does not depend on the account module. Forward-Port-Of: odoo/enterprise#57202
Miscellaneous changes
Partial revert of ceb8b785. That commit replaced a generic error message with the one received from Adyen and stored in `error.message.data.message`, but `error.message` was not always defined. opw-3736725 Forward-Port-Of: odoo/odoo#155305 Forward-Port-Of: odoo/odoo#154984
Original PR description
Partial revert of ceb8b785. That commit replaced a generic error message with the one received from Adyen and stored in `error.message.data.message`, but `error.message` was not always defined. opw-3736725 Forward-Port-Of: odoo/odoo#155305 Forward-Port-Of: odoo/odoo#154984
This update fixes a test failure in the report editor that occurred when running without demo data. The test was crashing because it expected an image to be set on a partner record, but this requirement wasn't essential to what the test was actually checking. By removing this unnecessary dependency, the test now runs reliably in all environments.
Original PR description
Before this commit, the test test_add_non_searchable_field crashed in no-demo mode because an image was not set on a partner, and that had only an effect on a sanity check in the business code rather than an effect on the relavance of the test After this commit, the test doesn't crash in demo mode. runbot-error-57397 runbot-error-57430 runbot-error-57432 runbot-error-57822 runbot-error-58218 Forward-Port-Of: odoo/enterprise#57559
This update removes print-related styling rules from the backend system that were only needed for survey frontend pages. By isolating these styles to just the survey module where they're actually used, the change prevents unintended formatting effects across the rest of Odoo's backend interface.
Original PR description
PURPOSE ======= The survey addon assets contain some global rules for print mode, that are present in the global backend stack. In Odoo 15.2, we put these rules in `survey_templates_results.scss`.…
PURPOSE ======= The survey addon assets contain some global rules for print mode, that are present in the global backend stack. In Odoo 15.2, we put these rules in `survey_templates_results.scss`. Then, in later versions of Odoo we updated it wih more 'print mode' global rules. As these rules are specific to the survey addon, we don't want them to affect the (whole) Odoo backend. HOW TO FIX ========== It seems rules defined in `survey_templates_results.scss` are not used in survey backend views, but specific to frontend views. `survey_templates_results.scss` is also part of the `survey.survey_assets` bundle. This bundle is loaded only for the following frontend views: - Survey: main page (take survey) - Survey: custom 403 page - Survey: void content - Survey: login required - Survey: expired - Survey: Access Code page - Survey: print page - Survey: result statistics page Among them, views that are not intended to be printed are not negatively impacted by the css rules for print mode. A solution would therefore be to remove `survey_templates_results.scss` from the backend stack. see https://github.com/odoo/odoo/commit/03641610c2b4a6b832ea87795fd21e1d7af10b59 see https://github.com/odoo/odoo/pull/135683 see https://github.com/odoo/odoo/pull/146812 task-3666858 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#148296
This update removes redundant code that was causing duplicate warning messages when products are added to sales orders. The fix ensures warning notifications only appear when necessary, improving the user experience by eliminating unnecessary duplicate alerts.
Original PR description
This is a fixup of: https://github.com/odoo/odoo/pull/149155 Warning is duplicated: https://github.com/odoo/odoo/blob/8ccde3f101cdb6ca41fe29cc5b4252f13745774a/addons/sale/models/sale_order_line.py#L1223-L1232 In the case where some products are already added to the SO before selecting the catalog, the warning props will always be loaded. However, since the warning props is a String but sale_line_warn can be false, it only need no be added if sale_line_warn is set. opw-3631511
This fix corrects the alignment and display of invoice totals in the Argentine localization module. When invoices contain large amounts, the total line was not properly aligned on printed invoices. The fix adjusts the column layout to ensure totals display correctly regardless of amount size.
Original PR description
Steps to reproduce: [l10n_ar] - create an invoice with an invoice line having a big amount - confirm - print invoice Issue: The alignment of total is not correct Solution: In l10n_ar, we need more cols to be able to display the correct information. In the base report, the difference is not important visually (the line total is slightly longer) opw-3670830 Forward-Port-Of: odoo/odoo#152682
This update corrects the phone country codes for the Democratic Republic of the Congo (CD) and the Republic of the Congo (CG), which were previously assigned to the wrong countries. The fix ensures that customers and contacts in these countries will have the correct phone code associated with their location, improving data accuracy in the system.
Original PR description
Phone codes for the Democratic Republic of the Congo (CD) and The Republic of the Congo (CG) are the wrong way around, and ought to be reversed. This commit is based on a commit that was not merged in v14.0 in this PR: https://github.com/odoo/odoo/pull/133287 Forward-Port-Of: odoo/odoo#155557
Example of steps with studio: ``` 1 - Install `web_studio` and `hr_holidays` 2 - Open `hr_holidays` 3 - Go to Approvals/Time off 4 - Create a new time off 5 - Set any user 6 - Set a time off type with a support attachment (example sick) 7 - Upload any file 8 - Save 9 - Open studio in this form view 10 - Make `supported_attachments_ids` required via studio 11 - Try the flow again steps 4 to 8 without uploading a file 12 - It should not let you save since `support_attachme
Original PR description
Example of steps with studio: ``` 1 - Install `web_studio` and `hr_holidays` 2 - Open `hr_holidays` 3 - Go to Approvals/Time off 4 - Create a new time off 5 - Set any user 6 - Set a time off type…
Example of steps with studio: ``` 1 - Install `web_studio` and `hr_holidays` 2 - Open `hr_holidays` 3 - Go to Approvals/Time off 4 - Create a new time off 5 - Set any user 6 - Set a time off type with a support attachment (example sick) 7 - Upload any file 8 - Save 9 - Open studio in this form view 10 - Make `supported_attachments_ids` required via studio 11 - Try the flow again steps 4 to 8 without uploading a file 12 - It should not let you save since `support_attachments_ids` is required 13 - But it's not working ``` Logic is done here https://github.com/odoo/odoo/blob/1b09a6314dbce9363f4785c670033f41846359ad/addons/web/static/src/legacy/js/views/basic/basic_renderer.js#L355-L367 Before saving, `widget.isSet` is called to check if it's not empty in case it's required This commit fix this issue by adding a proper `isSet` method to `FieldMany2ManyBinaryMultiFiles`/`many2many_binary` Forward-Port-Of: odoo/odoo#155361 Forward-Port-Of: odoo/odoo#154994