Daily updates from Odoo
Thursday, February 29, 2024
9 changes · master
Enhancements to existing features
This update simplifies how activity information is handled in form chatter areas across many Odoo apps. It removes unnecessary activity identifiers from screen definitions and prepares view data to carry extra model information when needed, helping keep the interface infrastructure cleaner and easier to maintain.
Original PR description
**Before this PR:**
- Each model in models from `get_views` return data, only contains a dict of fields. The structure of models is like:
```py
models: {
resModel1: {contains resModel1 fields},
resModel2: {contains resModel2 fields},
...
}
```
**After this PR:**
- Adding `fields` in form of `key: value` to each model in `get_views`, makes it possible to add extra data about model beside `fields` if it's needed.
```py
models: {
resModel1: {
fields: {contains resModel1 fields},
extra_data: ...
},
resModel2: {
fields: {contains resModel2 fields}
extra_data: ...
},
...
}
```
- All the `activity_ids` (descendants of `oe_chatter`) are removed from the view arch
[Related Odoo PR](https://github.com/odoo/odoo/pull/154710)Miscellaneous changes
Pricelists are now restricted to the current company by default. Some tests had to be adapted to keep some pricelists shared between companies. task-3610823 See odoo/odoo#147014 Forward-Port-Of: odoo/enterprise#55857
Original PR description
Pricelists are now restricted to the current company by default. Some tests had to be adapted to keep some pricelists shared between companies. task-3610823 See odoo/odoo#147014 Forward-Port-Of: odoo/enterprise#55857
It seems some people are getting an "unassigned variable 'balance'". This shouldn't happen with the standard code because _get_write_off_move_lines_dict is only called from the manual reconciliation widget in which, you only have access to models having strictly lines being percentage or fixed (see get_reconcile_modelds_for_manual_reconciliation). This method is not called from the bank reco widget pointed by "RECONCILE x ITEMS" on the accounting dashboard. It probably comes from some customizat
Original PR description
It seems some people are getting an "unassigned variable 'balance'". This shouldn't happen with the standard code because _get_write_off_move_lines_dict is only called from the manual reconciliation widget in which, you only have access to models having strictly lines being percentage or fixed (see get_reconcile_modelds_for_manual_reconciliation). This method is not called from the bank reco widget pointed by "RECONCILE x ITEMS" on the accounting dashboard. It probably comes from some customization but I don't know which ones. github issue: 116064 X-original-commit: 99525f8dac17170a59ed10e471a8ea364258884c Forward-Port-Of: odoo/enterprise#57047
Before this commit, answer's partner for 360 feedbacks were set as the employee's user partner or the employee's private email. This meant that all employees with no user would get the feedback request through their private email instead of their work email. However, it's not a wanted behaviour. This commit changes the way the answer's partner is determined, taking first the work partner, then the user partner if no work partner is found. task-3627757 based on ticket-3612515 Forward-Port-
Original PR description
Before this commit, answer's partner for 360 feedbacks were set as the employee's user partner or the employee's private email. This meant that all employees with no user would get the feedback request through their private email instead of their work email. However, it's not a wanted behaviour. This commit changes the way the answer's partner is determined, taking first the work partner, then the user partner if no work partner is found. task-3627757 based on ticket-3612515 Forward-Port-Of: odoo/enterprise#53518 Forward-Port-Of: odoo/enterprise#52235
When generating work entries based on attendances, lunch time was not being taken into consideration, we fix this issue in the version where lunch time was introduced Forward-Port-Of: odoo/enterprise#57217
Original PR description
When generating work entries based on attendances, lunch time was not being taken into consideration, we fix this issue in the version where lunch time was introduced Forward-Port-Of: odoo/enterprise#57217
**Current behavior:** Modifying an email template associated with the Appraisals app will not result in that attachment being sent when a message is composed using that the template. **Expected behavior:** The attachment(s) of a certain template will be sent when an email is triggered that references that template. **Steps to reproduce:** 1. Modify an HR Appraisals email template so that it has some file attachment 2. In the Appraisals app, create a new appraisal that will use the mo
Original PR description
**Current behavior:** Modifying an email template associated with the Appraisals app will not result in that attachment being sent when a message is composed using that the template. **Expected…
**Current behavior:** Modifying an email template associated with the Appraisals app will not result in that attachment being sent when a message is composed using that the template. **Expected behavior:** The attachment(s) of a certain template will be sent when an email is triggered that references that template. **Steps to reproduce:** 1. Modify an HR Appraisals email template so that it has some file attachment 2. In the Appraisals app, create a new appraisal that will use the modified email template 3. Send the email, observe in the chatter sidebar or in the list of emails in settings that the attachment linked to the relevant template was not sent **Cause of the issue:** The attachment_ids field of the request.appraisal model was not passed as a kwarg to the action_invite() method, which is where the email gets composed and posted. **Fix:** Add the missing attachment_ids argument to this method. opw-3644820 Forward-Port-Of: odoo/enterprise#57402 Forward-Port-Of: odoo/enterprise#55977
In Chile, "Untaxed Amount" has its own special term that isn't used in Spain/LATAM spanish: ~~"Total neto"~~ "Monto neto" [as for v17 since customer changed their mind]. Therefore everywhere that it appears (in a .pot file), we ensure that the es_CL localization uses this term. Also untranslated terms from the es_CL.po files that were edited have been removed since they add no benefit and make it harder to read the file (we expect to only add terms to the file, not translate every term for C
Original PR description
In Chile, "Untaxed Amount" has its own special term that isn't used in Spain/LATAM spanish: ~~"Total neto"~~ "Monto neto" [as for v17 since customer changed their mind]. Therefore everywhere that it appears (in a .pot file), we ensure that the es_CL localization uses this term. Also untranslated terms from the es_CL.po files that were edited have been removed since they add no benefit and make it harder to read the file (we expect to only add terms to the file, not translate every term for Chile). opw-3670297 Forward-Port-Of: odoo/enterprise#56863 Forward-Port-Of: odoo/enterprise#54712
Steps to reproduce the bug: - Go to Approvals - Create a new approval request - Set the start date after the end date - Save - the record is saved without any error or chenge in the dates Expected behavior: The system should not allow to save the record with the start date after the end date or it should show an error message Fix: Add constrains on the date fields to avoid saving the record with the start date after the end date and raise a ValidationError if the user tries to
Original PR description
Steps to reproduce the bug: - Go to Approvals - Create a new approval request - Set the start date after the end date - Save - the record is saved without any error or chenge in the dates Expected behavior: The system should not allow to save the record with the start date after the end date or it should show an error message Fix: Add constrains on the date fields to avoid saving the record with the start date after the end date and raise a ValidationError if the user tries to save the record with the start date after the end date task-3650931 Forward-Port-Of: odoo/enterprise#55851
When creating SOLs on the fly for tickets, only the "Create and Edit" option is available. This PR enables the quick create for SOLs on tickets. Community: https://github.com/odoo/odoo/pull/142720 Task-3553151 Forward-Port-Of: odoo/enterprise#57418 Forward-Port-Of: odoo/enterprise#53833
Original PR description
When creating SOLs on the fly for tickets, only the "Create and Edit" option is available. This PR enables the quick create for SOLs on tickets. Community: https://github.com/odoo/odoo/pull/142720 Task-3553151 Forward-Port-Of: odoo/enterprise#57418 Forward-Port-Of: odoo/enterprise#53833