Wednesday, March 6, 2024
23 changes · saas-17.1
Resolved issues and error corrections
When users add a Tax ID, some invalid or unknown number parts were being logged as errors even when they did not require action. This change records those cases as warnings instead, reducing unnecessary error noise for support and monitoring teams.
Original PR description
``One of the parts of the number are invalid or unknown`` error occurs when the user adds a Tax ID. This commit changes the logger exception to a warning to avoid an unnecessary error in the log. sentry-4880057848, 4972280626 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes a problem that caused the Salary Configurator to fail when holiday-related benefit information was missing. This helps HR users open and use the configurator reliably when preparing salary packages.
Original PR description
A trackback arises because the holiday key is not included in the benefits. This commit led to the issue -issue.https://github.com/odoo/odoo/commit/e0a739897e170c5f08c1cf4ca3a98638ad664027 task-3740939
This update corrects a problem that occurred during Odoo upgrades, specifically related to how account report expressions were managed. The change ensures that report expression records are properly removed when updating, preventing database errors and maintaining a stable system. This resolves a potential upgrade disruption.
Original PR description
Cascade removal of account.report.expression records to corresponding account.report.external.value, avoiding the following issue when upgrading: ``` Traceback (most recent call last): File…
Cascade removal of account.report.expression records to corresponding account.report.external.value, avoiding the following issue when upgrading:
```
Traceback (most recent call last):
File "/home/odoo/src/odoo/17.0/odoo/service/server.py", line 1302, in preload_registries
registry = Registry.new(dbname, update_module=update_module)
File "<decorator-gen-16>", line 2, in new
File "/home/odoo/src/odoo/17.0/odoo/tools/func.py", line 87, in locked
return func(inst, *args, **kwargs)
File "/home/odoo/src/odoo/17.0/odoo/modules/registry.py", line 113, in new
odoo.modules.load_modules(registry, force_demo, status, update_module)
File "/home/odoo/src/odoo/17.0/odoo/modules/loading.py", line 536, in load_modules
env['ir.model.data']._process_end(processed_modules)
File "/tmp/tmpwrjjshgf/migrations/base/0.0.0/pre-models-no-model-data-delete.py", line 103, in _process_end
return super(IrModelData, self)._process_end(modules)
File "/home/odoo/src/odoo/17.0/odoo/addons/base/models/ir_model.py", line 2562, in _process_end
self._process_end_unlink_record(record)
File "/home/odoo/src/odoo/17.0/addons/website/models/ir_model_data.py", line 36, in _process_end_unlink_record
return super()._process_end_unlink_record(record)
File "/home/odoo/src/odoo/17.0/odoo/addons/base/models/ir_model.py", line 2491, in _process_end_unlink_record
record.unlink()
File "/home/odoo/src/odoo/17.0/odoo/models.py", line 4218, in unlink
cr.execute(SQL(
File "/home/odoo/src/odoo/17.0/odoo/sql_db.py", line 332, in execute
res = self._obj.execute(query, params)
psycopg2.errors.ForeignKeyViolation: update or delete on table "account_report_expression" violates foreign key constraint "account_report_external_value_target_report_expression_id_fkey" on table "account_report_external_value"
DETAIL: Key (id)=(94) is still referenced from table "account_report_external_value".
```
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#154191This update fixes a problem where QR codes weren't printed when automatically generating receipts. The change ensures the QR code image is loaded *before* sending the receipt to the printer, guaranteeing its inclusion on the printed document. This improves the user experience for receiving and scanning receipts.
Original PR description
Prior to this commit, enabling auto receipt printing resulted in the QR code not being printed on the receipt. This was due to the QR image being fetched post printing. This commit addresses the issue by first loading the QR code image, then sending it to the printer, ensuring its presence on the printed receipt. opw-3763169 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#155354
This update fixes an issue where service purchase orders weren't automatically generating linked purchase orders. The change ensures the correct company context is used when creating purchase orders linked to service orders, resolving a problem where POs weren't being created when a specific company was designated for the service.
Original PR description
Steps to reproduce: - Setup two companies and a product - For one of the company activate "Subcontract Service" on the product - Make an SO with the product and in Other Infos set the company with the one that has subcontract service on - Confirm the SO with the company that doesn't have it on Issue: No PO is generated. Solution: Make sure we got the right context when generating purchase. opw-3622278 Forward-Port-Of: odoo/odoo#150626
This update resolves an issue where moving tables in the restaurant point-of-sale system didn't correctly update the backend. The change ensures that table selections are saved when a table is moved from or the move edit is closed, maintaining accurate table management.
Original PR description
After this pr https://github.com/odoo/odoo/pull/148139 the table moves where not saved anymore. This commit makes sure that when a table is unselected or the edit move is exited, the selected tables are updated in the backend. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update resolves an issue where combo products weren't correctly updating references when new variants were created. Now, when a combo product's details are saved as a variant is made, the reference is updated to include all newly created variants, ensuring accurate tracking of product combinations in point of sale transactions.
Original PR description
-When product in combo choices are being archived because of variants creation, replace the archived reference with all newly created variants. -Add test to reproduce this use case task id: 3713861 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#156301
This update resolves an issue where Ctrl+clicking on styled links within the web editor didn't open the intended destination. The fix ensures that the link targets the nearest actual anchor tag, providing the expected functionality for users to navigate to external URLs.
Original PR description
Current behavior before PR: Ctrl+clicking on a styled link is ineffective since the target is the styled element, which lacks an href. Desired behavior after PR is merged: The target should be set to the nearest `<a>` tag rather than on the styled tag. task-3773924 Forward-Port-Of: odoo/odoo#155820
This update fixes a rounding issue that was causing incorrect prices in UBL (Universal Business Language) invoices. The team switched from a specific rounding function to Python's built-in rounding method to ensure accurate price calculations. This improves invoice accuracy and consistency for our customers.
Original PR description
In [1], we added a rounding of the amounts in the `<PriceAmount>` tags to avoid floating point rounding errors. However, it seems the `float_round` function does not guarantee to avoid these errors. Take the example of `price_subtotal` = 250.80 and `quantity` = 3. We will compute the PriceAmount as 250.80 / 3 which yields 83.60000000000001. Even when using `float_round(amount, 10)`, it still results in the same amount with the rounding error. For that reason we use the built-in `round` method of Python instead. [1] 58d57bbbaaab32ba0183890a9182e6de09b32ac5 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#155949 Forward-Port-Of: odoo/odoo#155570
This update fixes a potential error in how Odoo fetches message types within the mail system. Previously, retrieving related information after the initial fetch could cause performance issues. This change adds a temporary solution to optimize the database retrieval process, ensuring smoother and more reliable mail operations.
Original PR description
A new message type was added in stable. This is usually safe, however in cases where there are related fields on that same selection fetching them will raise an exception as the ORM has to fetch the translations for the selection in DB. We add a hack on mail.mail to update the selections in DB when fetching the message type the first time. Subsequent gets should be inexpensive as these are cached. task-3773301 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#156235 Forward-Port-Of: odoo/odoo#155766
This update resolves an issue where removing a filter on the website forum would incorrectly redirect users to their own profile instead of displaying all questions from the author. Now, removing the filter correctly shows all questions from the author's profile as intended.
Original PR description
Before this PR: - Navigate to the author's profile from a course on website forum. - Go to the Questions tab and remove the existing filter - It directs to the login user's profile instead of removing the filter. After this PR: Now when the filter is removed and all the questions of the author are shown from his profile. Task-3725329 Forward-Port-Of: odoo/odoo#154901 Forward-Port-Of: odoo/odoo#153986
This update corrects terminology and translates key terms within the l10n_it_edi_website_sale module into Italian. This ensures accurate and localized reporting for Italian customers using the website sale functionality, improving the user experience and compliance with Italian regulations.
Original PR description
Correct the terms in this module and translate them in Italian. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#155993 Forward-Port-Of: odoo/odoo#155905
This update fixes a potential error where duplicate accounts could be created in the system. Previously, the system checked for account duplicates based on the original code, not the normalized code. Now, the system correctly checks for duplicates using the normalized code, preventing errors and ensuring data integrity.
Original PR description
**Description of the issue/feature this PR addresses:** Function `_pre_reload_data` checks for the existance of accounts with the same code to avoid creating a duplicate. It does so however comparing with the code before normalizing it with the length from the template, failing to find possible duplicates with a normalized code. **Current behavior before PR:** If accounts with non-normalized codes _(eg 172)_ are being loaded, there's a risk that an account with a matching normalized code _(eg 172000)_ already exists in the database. If the corresponding xmlid is not pointing at it, another account with the same code will be created triggering the ValidationError. **Desired behavior after PR is merged:** The comparison with existing accounts is made with the normalized code avoiding this conflicts. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#156119 Forward-Port-Of: odoo/odoo#155256
This update fixes an issue where survey questions using comment fields as answers wouldn't display the expected text input box. The fix ensures that clicking on the comment field reveals the text box, allowing users to properly input their responses. This improves the survey functionality and user experience.
Original PR description
**Current behavior:** A survey question which has a comment field counted as an answer will not reveal its text box input field when it is selected as the current answer. **Expected behavior:** After clicking on the comment field answer, the text box will be revealed and enabled. **Steps to reproduce:** 1. In the surveys app, add a question to a survey of type `Multiple choice: only one answer` 2. In the question's options, enable the `Show Comments Field` and `Comment is an answer` options 3. Go to the question in the survey, click on the comment answer and observe there is no field to enter a comment **Cause of the issue:** The function which is responsible for adapting these page elements is not selecting the correct html elements, thus their attributes are not properly changed when needed. **Fix:** Change the function variables so that they are pointing to the correct location in the DOM. opw-3748291 Forward-Port-Of: odoo/odoo#155023
This update fixes an issue where duplicating a warehouse didn't automatically copy its operating types (like 'delivery' or 'internal transfer). Now, when you duplicate a warehouse, the new warehouse will have its own set of operating types, ensuring consistent inventory management. This improves the reliability of warehouse duplication processes.
Original PR description
[FIX] stock: duplicating warehouse dependencies Before this commit when duplicating a warehouse, its operation types (picking.type) wouldn't get copied. This commit ensures that new picking.types are created for the duplicate warehouse. ### [Reproduce] - run odoo 17 with -i stock,mrp_subcontracting - in Inventory/Configuration/Warehouses Duplicate a Warehouse - Bug: in Inventory/Configuration/OperationTypes picking types aren't duplicated opw-3674614 Forward-Port-Of: odoo/odoo#151769
This update removes an outdated code used in Swedish billing (EAS code '9955') and replaces it with the correct, current code ('0007'). This ensures accurate and compliant electronic invoicing for our Swedish customers, aligning with European regulations.
Original PR description
remove deprecated EAS code for Sweden. The code is no longer part of the valid list of codes. See https://docs.peppol.eu/poacc/billing/3.0/codelist/eas/ and https://docs.peppol.eu/edelivery/codelists/ Also, in the endpoint the Swedish organization number must be used, which is taken from the VAT by removing the country code and the last two digits. You can check it out here: https://organisationsnummer.dev/ --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#156289 Forward-Port-Of: odoo/odoo#153440
This update fixes a potential issue where notifications were being sent even when there were no channel members to update. This prevented the creation of channel members with invalid IDs. A new test case has been added to ensure notifications are only sent when updates are actually needed.
Original PR description
When there is no channel members to be updated the seen status, we should not send a notification to the channel members, otherwise, it will lead into creating a channel member with id undefined. test case added to check that the notification is not sent when there is no channel members to be updated. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#156534
A recent update to Odoo's frontend styling caused a visual inconsistency where search bar buttons lacked rounded corners. This update corrects this issue, ensuring that search bars and other input groups maintain a consistent and visually appealing design. This change improves the overall user experience for website editing.
Original PR description
Since the commit [1] introducing Bootstrap 5, buttons within input groups (e.g., "search bars") no longer have the same border-radius as the inputs. Steps to reproduce the bug: - In Website edit mode, drag and drop a "Search" snippet onto the page. - Click on the "Theme" tab. - Set the inputs "Border Radius" option to 25px. - Bug: The border-radius is not applied to the right side of the search bar. [1]: https://github.com/odoo/odoo/commit/9ea13513342b14e6b8d4e10e162b618a6ab2cce0 task-3662985 Forward-Port-Of: odoo/odoo#156499 Forward-Port-Of: odoo/odoo#154235
This update prevents users from submitting multiple reviews for the same course. Previously, users could add multiple reviews even with multiple browser tabs open. This change ensures data integrity and a consistent user experience when leaving feedback on courses.
Original PR description
Once a user posts a review, they are able to edit this single review and not create any new ones. However if the user had multiple tabs open of the same course, then they can still access the "Add a review" functionality. This fix enforces the single review per user per course policy. Task-3721958 Forward-Port-Of: odoo/odoo#156411 Forward-Port-Of: odoo/odoo#153679
This update fixes a bug that caused Odoo to crash when attempting to retrieve information about channels that didn't exist. The fix ensures that Odoo gracefully handles missing channel data, improving stability and preventing unexpected errors. This resolves an issue reported as part of opw-3775992.
Original PR description
When the channel is not found it becomes deleted, then `thread.fetchChannelInfoDeferred` becomes undefined, and attempting to resolve/reject it leads to a crash. Part of opw-3775992
This update corrects a problem where the 'Journal' field was sometimes hidden on payment providers other than Wire Transfer. The change ensures the `payment_custom` module always loads after `account_payment`, guaranteeing consistent visibility of the 'Journal' field for all payment providers. This improves the user experience and data accuracy.
Original PR description
Both the `payment_custom` and the `account_payment` modules made changes to the visibility of the `payment_followup` group in the view of the `payment.provider` model. As these modules didn't depend on each other, the visibility of the group was determined based on the (random) loading order or the modules, causing the "Journal" field to be either visible or invisible on other providers than Wire Transfer. With this commit, a priority is set on `payment_custom`'s view to force it to always load after that of `account_payment`. Forward-Port-Of: odoo/odoo#156514
This update corrects a bug where the 'Open in new window' setting for website links wasn't consistently saved and reapplied when editing. Previously, the toggle would reset to off after saving. This change ensures the 'Open in new window' option persists correctly, improving the website builder's functionality.
Original PR description
Before this commit and most likely since commit [1], the "Open in new window" option of link would not persist through editions. Steps to reproduce: - Create a link in the website builder - Set its "Open in new window" property to true - Save, and see that it works as expected - Now enter edit mode again, the toggle will be off and not on as it should be since the `target="_blank"` was correctly added. For easy of debugging and understanding, you can just grep this line ```js this.initialNewWindow = this.initialNewWindow || this.linkEl.target === '_blank'; ``` [1]: https://github.com/odoo/odoo/commit/d7245d2abf528d093226c80e40975e63d61e8997# opw-3781477 Forward-Port-Of: odoo/odoo#156372
This update fixes a confusing issue where users could accidentally submit surveys by pressing the Enter key. Now, requiring Ctrl + Enter for submission ensures a clearer and more intentional process, reducing errors and improving the user experience. This change enhances survey completion rates and data accuracy.
Original PR description
Previously, In "one_page & page_per_section" survey, pressing Enter would submit the survey, leading to confusion and accidental submissions, as users might press Enter intending to navigate through questions. With this PR, Now, requiring "Ctrl + Enter" to submit, ensures clarity in survey submission, reducing the chance of accidental submission. task-3707763 Forward-Port-Of: odoo/odoo#152850