Thursday, March 7, 2024
22 changes · saas-17.1
Resolved issues and error corrections
This pull request fixes a minor issue where a character was missing from a translation pattern within the Odoo survey module. As a result, users were not seeing the intended text. This update ensures all survey text is displayed correctly for a better user experience.
Original PR description
A character was left out of the translation pattern, so the text was never displayed correctly to the user. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#155331
This update corrects a visual glitch (flicker) that occasionally appeared when hovering over buttons on the course page. This enhancement ensures a smoother and more professional user experience for visitors. The fix was part of a larger effort to improve website stability.
Original PR description
This commit fixes the flicker issue of buttons hovering over content on the course page. Task-3751285 Forward-Port-Of: odoo/odoo#156543 Forward-Port-Of: odoo/odoo#155869
This update ensures that when a manufactured order (MO) is created from a sales order (SO), the analytic account specified on the SO is automatically applied to the MO if no analytic account is defined in the product's manufacturing bill of materials (BOM). This resolves an issue where analytic accounts weren't being correctly transferred, improving financial reporting accuracy.
Original PR description
Steps to reproduce: - Enable MTO - Create a manufactured product (no analytic distribution on the bom) - Create an SO for that product and set an analytic account on it - Confirm the SO Bug: no analytic account on the created MO Fix: inherit MO analytic account from SO if none is set on the BOM opw-3708134 Forward-Port-Of: odoo/odoo#156535 Forward-Port-Of: odoo/odoo#154354
This update fixes an issue where charts on survey results pages would disappear when printing. The fix adds styling to ensure charts are always visible and removes unnecessary code that caused this problem. This ensures consistent and reliable printing of survey results.
Original PR description
Purpose ======= When you go on any survey results page, you notice charts are smaller than they used to be on version 16. But there are still readable. The annoying part is when you click on the `print` btn or press `CTRL + P`, the charts disappear from both the page and the window preview. How to fix ========== - add classes `w-100` and `h-auto` to the canvas elements containing the charts Also, remove after/before-print events in the public widget as they are no longer useful. see https://github.com/odoo/odoo/pull/135683 task-3667969 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#152705
This update fixes a display issue in the Amounts to Settle report, replacing a confusing 'Display Name' column with the more useful 'Name' column. It also adds a search option for journal entries, making it easier to find relevant transactions. This improves the clarity and usability of key financial reporting tools.
Original PR description
This commit fixes the amounts to settle view which currently shows a "Display Name" column which makes no sense and is missing a search option for journal entries. --- enterprise: https://github.com/odoo/enterprise/pull/54137 task-3640027 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#148476
This update adds a new test to ensure the screencast feature continues to function correctly. Recent changes impacted the underlying ffmpeg call, and this test provides verification and compatibility testing across different ffmpeg versions used in Odoo's distribution builds.
Original PR description
Screencast are not always enable and a recent change broke the ffmpeg call. This call was already broken in some ffmpeg versions. This test will help to ensure this feature continues to work, and will also test it in different ffmpeg versions during distro builds. Forward-Port-Of: odoo/odoo#155951 Forward-Port-Of: odoo/odoo#151815
This update corrects a minor typo in the Odoo system's channel management process. The change prevents unnecessary requests, optimizing performance and resource usage. This ensures a smoother and more efficient user experience.
Original PR description
There is no bug manifesting because the condition is only here to prevent from making extra RPC calls while one is already in progress.
This update fixes a recurring issue where payments were incorrectly canceled due to lingering inactivity timeouts. By explicitly clearing these timeouts before initiating new payments, we've eliminated this error and ensured smoother payment processing for our customers. This improves the reliability of the point-of-sale system.
Original PR description
Before this commit ================== In certain scenarios, when a new subsequent payment was initiated after the initial payment was completed, an error message appeared stating, **Payment is canceled due to inactivity** Issue ===== Failing to remove the previous inactivity timeout before establishing a new one led to the aforementioned error. With this commit ================ Explicitly clear previous timeouts before setting a new one to prevent potential conflicts and ensure a clean timeout environment. Forward-Port-Of: odoo/odoo#156430
This update resolves an issue where the EMV QR code selection was incorrectly choosing QR codes for unsupported countries, leading to potential currency errors. The fix introduces a fallback error message, ensuring accurate QR code selection and preventing incorrect currency checks.
Original PR description
The account_qr_code_emv module has an issue at the moment where it will only return errors in _get_error_messages_for_qr for the country the qr code is intended for. This makes sense since you want…
The account_qr_code_emv module has an issue at the moment where it will only return errors in
_get_error_messages_for_qr for the country the qr
code is intended for.
This makes sense since you want to check all countries in later versions where we have multiple of them.
But it causes an issue with the standard implementation where if you are using a country that is not supported by an EMV QR, _get_error_messages_for_qr will just return None.
This means that:
- The default QR CODE selection on the invoice that
depends on that may select EMV QR for unrelated
countries.
- If it gets selected, this method will not check
that the currency is correct for said countries.
To fix this issue, we will simply return an error
message in the common module, which will serve as a fallback once all the EMV QR methods have been checked.
Task id # 3758668
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#156840
Forward-Port-Of: odoo/odoo#154957This update resolves an issue where the actionable error widget didn't refresh when underlying data changed. Now, the widget accurately reflects any updates to the account configuration, ensuring users see the correct error messages or no messages at all. This improves the user experience and data accuracy.
Original PR description
The widget for actionable errors does not update when the errors it displays are updated due to, for example, a recomputation of the field. This results in irrelevant errors being displayed in the view, when a particular configuration is correct. The correct errors (or an absence of any errors) will not be displayed until the view is refreshed. This commit adapts the component, such that the record data is accessed directly from the template. This means that the recordObserver, and the method it uses can be removed (as they were redundant) task-id: None Forward-Port-Of: odoo/odoo#155914
This update fixes an issue where the forecast report incorrectly marked stock reservations as 'Reserved from stock' when transfers involved multiple warehouses. Previously, a move could be marked as reserved even if the transfer chain wasn't fully completed across warehouses. Now, the system ensures reservations are linked to the correct transfer, providing accurate stock visibility in multi-warehouse operations.
Original PR description
Commit c05815ae6b8bd will go through a chain a move to set the last one as "reserved from stock" if the first one is reserved even if the cahin is not completed yet. The issue is if the chain is…
Commit c05815ae6b8bd will go through a chain a move to set the last one as "reserved from stock" if the first one is reserved even if the cahin is not completed yet. The issue is if the chain is inter warehouses, a move out in a warehouse can be marked as "reserved" while the stock being reserved is actually the one of another warehouse. ### To reproduce 1. Create 2 warehouses 2. Create a stock rule (pull) and a route between the 2 stock location of those product create a product having the route MTO and the new replenish route create a delivery in the second warehouse. 3. A transfer from the two warehouse should be created and linked to the delivery Open the forecast report for the warehouse that deliver the product -> the delivery is marked as "Reserved from stock" instead of being linked to the replenish transfer. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#152922 Forward-Port-Of: odoo/odoo#152322
This update resolves a crash in the full composer when using the im_livechat module to mention partners. The issue stemmed from an incorrect assumption about optional parameters within the suggestion service. This fix ensures the system correctly handles optional thread information, preventing the crash and improving stability.
Original PR description
Making a mention in full composer when `im_livechat` is installed was making the following crash:
```
TypeError: Cannot read properties of undefined (reading 'type')
at SuggestionService.fetchSuggestions
```
Steps to reproduce:
- install module `im_livechat`
- open contacts app form view
- open full composer (e.g. Log note => expand icon)
- type @ + a character => throws error above
This happens because `SuggestionService` methods can optionally pass a thread, but livechat overrides wrongfully assume they were always provided.
This commit fixes the issue with optional chaining, taking into account it's optional.
No test because full composer doesn't work in unit tests, tours require adding steps blindly and I've already wasted too much time to no avail.
Forward-Port-Of: odoo/odoo#156773This update addresses a recent issue where restricted editor data was unintentionally shared with public users. This commit includes a new test to confirm that the fix implemented in a previous pull request remains in place, preventing future data leakage. This ensures data security and proper functionality for users.
Original PR description
This commit is a follow-up on [1] which fixed the caching of restricted editor which was accidentally shared with public users. It introduces a test that verifies that this fix is not lost. [1]: https://github.com/odoo/odoo/commit/821888023db462d522c5d6de84fcab80a81c2713 task-3482439 Forward-Port-Of: odoo/odoo#156479
This update corrects a bug where radio button checkboxes on forms were not functioning as expected. The change restores the default behavior of toggling the 'checked' attribute, which was inadvertently altered due to a recent update to the QWeb engine. This ensures all form elements, including radio buttons, work reliably.
Original PR description
Same fix as for checkbox (commit [1]) and select (commit [2]). The radio buttons were forgotten. Check commit [1] for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at [3]), it would toggle the internal `checked` value and not the `checked` attribute anymore. [1]: https://github.com/odoo/odoo/commit/b42e9cc686e7d3ccf82cd091a5dc24028fff8a2b [2]: https://github.com/odoo/odoo/commit/dd504811303a2ace661259d05d1e3b88794dc5be [3]: https://github.com/odoo/odoo/pull/130467 opw-3755078 Forward-Port-Of: odoo/odoo#156666
This update fixes a technical issue related to how early payment discounts are applied to customer invoices. Specifically, a misconfiguration was causing incorrect tax tagging, which has now been corrected by restoring the proper calculation method. This ensures accurate tax reporting for early payment discounts.
Original PR description
When configuring the payment term to include the EPD within the payment's journal entry on a customer invoice, the tax_tag_invert field got wrongly set as True. This was hardcoded in the code; computing the field in the regular way gives the proper value. OPW 3754446 Forward-Port-Of: odoo/odoo#156588
This update corrects a problem where special characters (like quotes) weren't printed correctly on ZPL product labels. Because the labels are generated as text, these characters are harmless and now display accurately. This ensures consistent and accurate product labeling for all products.
Original PR description
Current behavior: When printing products ZPL Labels, special characters are not printed correctly. e.g. quotes become ' Steps to reproduce: - Modify a product name with special characters - Print a product label - Select ZPL Labels As the report is only rendered as text, the special characters are not dangerous and can be printed as is. opw-3684870 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#156624 Forward-Port-Of: odoo/odoo#152657
This update fixes a warning message that prevented users from submitting expense reports. The system was incorrectly checking all applicability rules without considering the company setting, leading to errors. Now, the system accurately applies company-specific rules for analytic distributions, ensuring reports can be processed correctly.
Original PR description
Have company A and company B With company B: - Create an analytic plan with default applicability 'Mandatory' - Add an applicability: domain 'Expense', applicability 'Mandatory' With company A: - Open the same analytic plan - Set default applicability 'Optional', no assigned applicability - Add an analytc account for the plan - Create an expense, add amount - Create report > Submit to Mananger > Approve Issue: Action will be blocked by Warning message "One or more lines require a 100% analytic distribution." This occurs because the system checks all applicabilities of the plan without taking into account the company opw-3709374 Forward-Port-Of: odoo/odoo#155195
This update resolves a bug that caused survey submissions to fail when users had previously saved their answers as nicknames or email addresses. The change ensures that pre-filled answers are correctly handled, preventing security-related crashes when users attempt to modify saved data. This improves the survey experience for all users.
Original PR description
Purpose ======= Fix the UserError which is raised when the user submits an answer to a question having the "save as nickname" or "save as email" option checked. In testing or non-testing mode.…
Purpose ======= Fix the UserError which is raised when the user submits an answer to a question having the "save as nickname" or "save as email" option checked. In testing or non-testing mode. Specifications ============== When the question is marked as "save as email" or "save as nickname" and when the user isn't public, the partner data is already saved as the question answer (in the form of a user input line). The answer is then pre-filled in the survey. This is an issue because when the survey has the "users can go back" option to False and the user tries to submit the answer, it thinks the user is trying to changed the already saved user input line and it crashes for security reasons. In addition of allowing the answer override if the user can go back, also allow the override if the question is marked as "save as nickname" or "save as email". This issue was introduced in 17.0 when the overwrite_existing optional parameter has been added on the _save_lines method. Before that, the existing user input lines were overwritten no matter what. related https://github.com/odoo/odoo/pull/129329 Task-3756749 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#155561
This update resolves an issue where duplicating CTA buttons in the website editor resulted in a permanent, unremovable duplicate. The change prevents this duplication, allowing users to easily add and remove CTA buttons through the standard drag-and-drop interface. This ensures a smoother and more flexible experience for website customization.
Original PR description
Steps to reproduce [17.0]: - Go to website (in "Edit" mode) > Click on the "Contact Us" button. - Duplicate the CTA button ("Button options" > "Duplicate icon"). - There is no way to only remove the…
Steps to reproduce [17.0]:
- Go to website (in "Edit" mode) > Click on the "Contact Us" button.
- Duplicate the CTA button ("Button options" > "Duplicate icon").
- There is no way to only remove the duplicated button, and the "Header" >
"Show/Hide Button" option will disable the whole CTA container.
After the website headers redesign in [1], a new feature was added to
allow users to select the elements they want to display in the header
(social links, call to action...). The CTA section was also marked as
'oe_unremovable' which disabled the option to remove it in the editor.
When a CTA button is duplicted, the clone will also be unremovable which
makes it impossible to remove.
The goal of this commit is to prevent the duplication of CTA buttons.
It's always possible to add buttons by drag & dropping "Button" snippets
which are also removable.
Remark: Also after [1], two header navbars were added in the DOM (for
the desktop view and mobile). Which means that the CTA field is also
duplicated and every change on the CTA buttons in Desktop will be
reflected in the mobile version.
[1]: https://github.com/odoo/odoo/pull/119650
opw-3706902
Forward-Port-Of: odoo/odoo#156164This update resolves an issue where a website tour wasn't functioning correctly when the demo data was not present. The team added necessary data to ensure the tour runs consistently, regardless of whether demo data is installed. This improves the user experience and prevents unexpected tour behavior.
Original PR description
The `course_publisher_standard` tour was missing slide (channel) tags. We are replacing values used in the tour so that the tour runs on the same data whether demo data is installed or not. See runbot build errors 55762 and 55768. Task-3744848 Forward-Port-Of: odoo/odoo#156797 Forward-Port-Of: odoo/odoo#153926
This update streamlines the process of redirecting users to forum questions, making the website more efficient. The change simplifies the handling of URL parameters related to forum questions, reducing complexity and improving performance. This ensures a smoother experience for users navigating to and within the forum.
Original PR description
Don't try to keep extra params and co. Keep it simple... Else we should pop from request.params `forum` and `blog` keys because now they are converted as query param with the slug format: /forum/help-1/question-1?forum=forum.forum(1,)&question=forum.post(1,) Forward-Port-Of: odoo/odoo#156726 Forward-Port-Of: odoo/odoo#156458
This update removes a disruptive reload that occurred when a workcenter was unblocked. This change improves the overall user experience, particularly for applications like the shop floor, by streamlining the process and eliminating unnecessary delays. It’s a simple fix to enhance efficiency.
Original PR description
Unblocking a workcenter incurs a reload which is bad in terms of user experience for other applications like shop floor. And since the reload is no longer needed at any other part, it is removed now. task-3629043 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#153036