Tuesday, March 12, 2024
7 changes · 17.0
Resolved issues and error corrections
When an app or feature is removed, saved custom filters linked to its actions are now cleaned up so they no longer point to something that no longer exists. This prevents confusing or broken entries from appearing in user-defined filters after module uninstallation.
Original PR description
Issue: When deleting an action, we still will preserve the action in the filter even thought this one doesn't exist anymore, this Issue is present in cases where we delete modules that contains filters. Steps to reproduce: 1. Install any module (CRM, Contacts..) 2. Create a custom search (filter) in this module 3. Now uninstall the module 4. Go to User-defined filters Solution: We make sure in the actions unlink that when this action.unlink() is called we also unlink the filters that contains this action by setting their action_id to None. opw-3770569
Survey forms now resize multi-line answer boxes as users add or change content. This prevents long responses from visually overlapping following questions, making one-page surveys easier to read and complete.
Original PR description
Steps to reproduce: - Install `survey` module - Create a survey and add 2 questions as `Multiple Lines Text Box` - In `Options` tab, set `Pagination` to `One page with all the questions` - Open the survey in test mode - Fill de first answer with 10 lines - Increase the size of the text box to display all lines Issue: The text of the first answer overlap the second answer. Cause: When rendering the textarea the first time, we adjust the height of the element AND its parent to the height of the content to avoid having the scroll displayed. The resize is done only once at first rendering. Solution: Set an event on each textarea to resize it (and it's parent) each time we update the content. opw-3704455
This update removes a test for Mexican electronic invoicing (EDI) that was failing consistently due to missing test data. The fix also improves error messages to help diagnose future test failures. This ensures the test suite runs reliably without false failures.
Original PR description
The test for `sw` fails every time because we don't have identifiers. We don't have any, so we just get rid of the test. Also added the message to the error, so we can know why it failed. (Other tests failed some time, but we can't reproduce and know why it failed). Linked to runbot error 25908 Forward-Port-Of: odoo/enterprise#58443
This update fixes a test that was checking the same condition before and after moving an image, which could lead to unpredictable test failures. The test now includes an extra step to refresh the editor panel between actions, ensuring it properly validates that image filters are preserved when images are repositioned in the gallery.
Original PR description
[FIX] website: adapt test tour to avoid undeterministic error Since [1], image options like "Filter" are kept when a user changes the position of an image in an "Image Gallery" snippet. [1] also…
[FIX] website: adapt test tour to avoid undeterministic error Since [1], image options like "Filter" are kept when a user changes the position of an image in an "Image Gallery" snippet. [1] also adapted the `snippet_image_gallery` tour (moved in `snippet_image_gallery_reorder` from version 16) to test this behavior. To do so, the test adds a filter on an image in an "Image Gallery" snippet, checks that the filter is displayed on the editor panel, moves the image, clicks on it and finally checks that the filter is still displayed on the editor panel. The problem is that the steps that check if the filter is displayed on the editor panel are the same before and after the move of the image which means that the second check is true also before the move of the image. This situation is a typical case where an undeterministic error could happen. Indeed, we do not know if the second check tests an old value or an updated one. To solve the problem, the test has been adapted; after the move of the image, the test clicks somewhere else (on the footer in this case), and then back on the moved image to finally check that the filter is still displayed on the editor panel. The goal of the click on the footer is to be sure to have a loaded version of the editor panel. By doing so, we remove the risk of an undeterministic error situation where a condition is already true before an action is done. Note: this problem has been discovered because the test `snippet_image_gallery_reorder` succeeds on version 16.3 without the fix of [1]. Now, the adapted test fails on version 16.3 without the fix of [1]. [1]: https://github.com/odoo/odoo/commit/0fd2477d993e822fe6fd4497aace9f746af7a481 task-3717041 Forward-Port-Of: odoo/odoo#156943 Forward-Port-Of: odoo/odoo#153014
This update corrects how a tax destination field is hidden in the partner view table. The system was using an incorrect display attribute that wasn't working properly in table layouts. The fix ensures the field is properly hidden from users when viewing partner tax information.
Original PR description
In one2many, for the view, the attribute to hide a field should be column_invisible and not invisible --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update resolves a testing issue in the web module where image field tests were failing intermittently due to timing problems. The fix increases the delay in the test to ensure images are fully loaded before validation, improving test reliability and reducing false failures.
Original PR description
Before this commit, the changed test sometimes failed because we expected the image to be set, but it wasn't (yet). This commit increases the delay. Runbot error 56099 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#157335
This update corrects a typo in the stock move module where the cancellation state was incorrectly named. The proper state for cancelled stock moves is now correctly set to "cancel". This ensures inventory operations are properly tracked and reported when orders are cancelled.
Original PR description
Correct state for stock move is "cancel". **opw-3783252**