Friday, March 15, 2024
26 changes
13 changes
Resolved issues and error corrections
This update corrects a previous issue where users could set time off types directly on accrual plans within the system's list views. We've removed this option to simplify the accrual plan configuration process. This change ensures a cleaner and more straightforward experience for managing accrual plans.
Original PR description
In rework of accruals plan, we removed the possibility to set a time off type on the accrual plan directly. The field has been removed from the form view, but not from the list view. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#157366
This update optimizes the process of reconciling accounts by adding a database index. This change speeds up the deletion of records during reconciliation, leading to faster and more efficient account reconciliation operations. The change was driven by a performance issue identified in a previous request.
Original PR description
## Description Add missing index on FKey `tax_cash_basis_rec_id` to speed up deletion of `account.partial.reconcile` records during reconciliation. It's `btree_not_null` as the relationship is sparse. ## Reference opw-3649801 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#157415
This update fixes an issue where currency fields weren't correctly displayed within spreadsheets when linked to a list view. The problem stemmed from a previous change and has been resolved, ensuring accurate currency formatting and names are now consistently shown. This improves the reliability of financial data within spreadsheets.
Original PR description
Get to a list view where there's a monetary field AND the related currency field in the same list. Then insert the list in a spreadsheet. => Either the currency format is not fetched or the currency name, depending on the order in the list. bug introduced by 8777973e opw-3770057 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#157623
This update fixes a potential issue where reports could be generated in a random order. Previously, the system didn't guarantee a consistent order, which could lead to confusion for users. This change ensures reports are always generated in the same order, improving predictability and reliability.
Original PR description
Before this commit, ir.actions.report can be randomed orderer. @rco-odoo --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#157031
This update ensures that when processing online payments for POS orders, the system now prioritizes the customer associated with the order over the logged-in user or a general public user. This change improves the accuracy of payment tracking and reporting for POS transactions, particularly when customers are purchasing through the online portal.
Original PR description
Before this commit: POS online payments uses the logged-in user or the public user, even when a POS order customer might also be present. After this commit: We check the partner_id for POS orders and give it precedence over both the logged-in user and the public user. task-3805695 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#157562
This update resolves an issue where font styles differed depending on whether users selected Google fonts or served them locally. The fix adds a necessary parameter during font download, ensuring consistent font rendering across all website styles. This improves the user experience and visual consistency.
Original PR description
[This other commit] introduced a method to serve Google fonts from the local server. Then it has been back-ported to previous versions with [this commit]. Unfortunately, the font was not identical…
[This other commit] introduced a method to serve Google fonts from the local server. Then it has been back-ported to previous versions with [this commit]. Unfortunately, the font was not identical when the user chose to load the font from Google servers versus from the local server. This discrepancy was due to a missing parameter when downloading the font file to serve it from the local server. This commit fixes the issue by adding the missing parameter. Steps to reproduce the issue fixed by this commit: - Drop a text block onto a website page. - Make the text bold. - Go to the theme tab. - Change the font to https://fonts.google.com/specimen/Poppins => The text style changes depending on whether you checked the "Serve font from Google servers" option or not. [This other commit]: https://github.com/odoo/odoo/commit/b06ce21eba6388ce34bbffffadcb489f0e8557dd [this commit]: https://github.com/odoo/odoo/commit/04ab4e255b7fef1608ee2c70a3a005f3064bc4f3 opw-3775683 Forward-Port-Of: odoo/odoo#157734
The website's search snippets were appearing invisible due to a color mismatch. This update introduces a new setting to ensure the snippets have a visible border and distinct background color, aligning with other search bars within Odoo apps. This improves the user experience when adding search snippets to webpages.
Original PR description
Since this commit [1], the two searchbar snippets are broken. The search bar input seems invisible because it shares the same color as the default snippet background and has no border. This style…
Since this commit [1], the two searchbar snippets are broken. The search bar input seems invisible because it shares the same color as the default snippet background and has no border. This style matches the search inputs used in apps (like the "/shop" search bar), which isn't affected by the "Input fields" settings in the "Theme" tab. To resolve this issue, this commit introduces a new option to choose between the "light" style (similar to "/shop" search bars) and the "default input style" for the 2 "Search" snippets. The "default input style" is automatically applied when the "Search" snippet (excluding saved snippets) is dropped to address the issue caused by the light-on-light color scheme. Steps to Reproduce the Issue: - While in Website edit mode, drag and drop a "Search" snippet onto the page. - Bug: The input appears invisible due to the lack of a border and a background color identical to the snippet's section color. [1]: https://github.com/odoo/odoo/commit/6b1d11a60d8e70b33c63da860bb81b015ce5ea20 task-3662985 Forward-Port-Of: odoo/odoo#154435
This update fixes an issue where the 'My' filters weren't appearing at the top of the timesheet search view. The change reordered the filter placement to ensure users can quickly find timesheets related to themselves. This improves usability and efficiency for managing timesheets.
Original PR description
Steps to reproduce: - Install timesheets - click on all timesheets - open search view Issue: - in search view 'my' filters block should be at the top of the list Cause: - misplacing of the name month filter causes the issue. Solution: - if we replace that filter below the group then the issue will be solved. task-3772684 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#155714
This update resolves an issue where creating a new provider with a specified journal would lead to errors when changing the provider's company. The fix prevents the creation of unnecessary related accounts, streamlining the process and improving data consistency.
Original PR description
During the copy of provider if the journal is set, it create a new account.payment.method.line, and if you change the company of the new provider you have an error when you try to create a new journal. https://www.odoo.com/web#model=project.task&id=3778226 opw-3778226 Forward-Port-Of: odoo/odoo#157715 Forward-Port-Of: odoo/odoo#149423
This update corrects a visual issue where new product templates initially displayed 'Odoo - False' in the tab title instead of the expected 'Odoo - New'. The fix ensures that new product records correctly show 'Odoo - New' until a product name is entered, improving the user experience.
Original PR description
**Current behavior:** When creating a new product template record, the tab title will be *Odoo - False* until a new name is saved rather than *Odoo - New*. **Expected behavior:** When creating a new record in a form view, the tab title will be *Odoo - New* until the `name` field is filled out and the record gets saved (at which point it will be *Odoo - <name>*). **Steps to reproduce:** 1. Install `sale_management` and go to the product list view 2. Create a new product, observe the misnamed tab title **Cause of the issue:** In `product.template`'s _compute_display_name() method, some of the default values can have a 'False' (str) value which will evaluate to True (bool), setting the name to 'False'. **Fix:** Set the display_name field to a False (bool) value if the current record does not have a name field set. opw-3793588 Forward-Port-Of: odoo/odoo#157258
This update resolves an issue where product image reordering caused unexpected swapping or jumping of images. Now, images are correctly inserted and maintained in their relative order, and the main product image always remains in the first position, providing a more stable and intuitive experience for users browsing product listings.
Original PR description
This change fixes the unexpected behavior of product image reordering: 1. Previously, when moving an image to the first or last postion, it was swapped with the first or last image. Now, it is inserted in the first or last postion, while keeping the relative ordering of the other images unchanged. 2. Previously, the main image could be in any position, but as soon as it was reordered, it would jump to the first position. Now, the main image is always in first position. task-3581895 Forward-Port-Of: odoo/odoo#150207
This update improves the Spanish language support within Odoo by correcting and expanding translations. Specifically, the `l10n_es` module has been updated with new translations, ensuring that Odoo's Spanish-speaking users have accurate and comprehensive support. This enhances the overall user experience for our Spanish-speaking customers.
Original PR description
Enterprise: https://github.com/odoo/enterprise/pull/58700 Forward-Port-Of: odoo/odoo#157759
This update fixes a potential issue where discounts on subscription sales were being recalculated unnecessarily after the order was confirmed. This change ensures that discounts are calculated correctly and efficiently, improving the accuracy of subscription sales figures. The update includes a new test to verify this fix.
Original PR description
Add test to cover a problem fixed in `sale_subscription` opw-3740645 See also: https://github.com/odoo/enterprise/pull/58673 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#157699
4 changes
Resolved issues and error corrections
A recent change in the HR app caused some Belgian payroll and salary configuration screens to display incorrectly. This fix restores the expected fields in those Belgian modules, helping users continue managing job-related payroll settings without disruption.
Original PR description
In response to the removal of certain fields from the hr module's job view on Task-3499251, inheritance in l10n_be_hr_payroll and l10n_be_hr_contract_salary views were disrupted. To address this issue, the affected fields have been set to invisible in the hr module and are now conditionally made visible within the dependent modules. Related PR causes issue: https://github.com/odoo/odoo/pull/141770
8 changes
Resolved issues and error corrections
A help message that appears when lxml fails to decode an emoji was providing incorrect installation instructions. The message suggested using the `--nobinary` switch, but the correct syntax is `--no-binary`. This fix ensures users receive accurate guidance if they encounter this error.
Original PR description
If lxml fails to decode an emoji, it indicates to reinstall lxml using `--nobinary` switch, which is incorrect. If you use the suggested command will get a "no such option". The correct switch is `--no-binary`
Images in the Social kanban view now load from the correct address after a recent URL routing change. This prevents broken image previews and keeps social content management visually consistent for users.
Original PR description
Bug === Since odoo/odoo@c63d14a0485a553b74a8457aee158384e9ae6d3f the base URL is /odoo and not /web, but the image route still use /web, so the URL must be absolute, otherwise the browser will try to fetch /odoo/web. Task-3805736
Barcode input fields are now larger in product addition, line editing, and inventory adjustment screens, making them easier to use. An unnecessary link on the location field was also removed to reduce confusion during warehouse operations.
Original PR description
With this commit =============== Enlarged barcode input fields in Add Product, Edit Line, and Inventory Adjustments sections, and removed the useless link to the location field. TaskId: 3516205
This fixes a configuration screen issue in the French payroll module caused by an invalid visibility setting. It helps ensure payroll settings display correctly and reduces the chance of confusion or errors when administrators configure French payroll.
This fix resolves an issue where developers using VSCode were not receiving autocomplete suggestions for OWL (Odoo Web Library) imports in the enterprise codebase. The fix adds a configuration file that properly exposes the OWL module to the TypeScript language server, improving the developer experience and reducing coding errors.
Original PR description
On an IDE (VSCode) with a TypeScript Server. For some reason, it was not possible to have imports suggestion to OWL in enterprise after commit [1]. Our main hypothesis is that, due to commit [1] who…
On an IDE (VSCode) with a TypeScript Server.
For some reason, it was not possible to have imports suggestion to OWL in enterprise after commit [1].
Our main hypothesis is that, due to commit [1] who points to odoo/addons, import lines in those files are resolved first in the scope of the odoo directory.
Consider a file in enteprise:
```js
import { registry } from "@web/core";
import { Component } from "@odoo/owl"
```
From the TSServer point of view it needs to resolve `@web` first, which itself has to resolve `@odoo/owl` in its directory scope, that is, in the scope of odoo community. It then keeps it in cache for later and importantly shadows the one present in enterprise/node_modules. Only then the explicit `@odoo/owl` is resolved with the odoo community's owl module from the cache.
Since that owl module from the cache is not explicitly available in enterprise, there are no imports suggestions.
This commit defines a main.d.ts file that only exposes the community's `@odoo/owl` explicitly. This hypothesis is confirmed by some hints that we discover during debugging:
- delete odoo/nodule_modules in enterprise: @odoo/owl becomes a suggestion again.
- comment the path line of @web/* in enterprise/jsconfig.json, owl is suggested.
- replace the copy of node_modules in enterprise by a symlink to odoo/node_modules, owl is suggested. This last one should also be considered as a valid fix for the current issue, as node_modules in odoo and enterprise *are the same*.
After this commit, owl is proposed for imports in VSCode.
[1]: 62cbb20
Forward-Port-Of: odoo/enterprise#58601This update removes the year value from Hong Kong payroll time off type names. Previously, the year was hardcoded in the name, which meant it wouldn't automatically update when the calendar year changed. By removing the year from the name, the time off types will remain accurate and relevant without requiring manual updates.
Original PR description
Steps to reproduce: - Install l10n_hk_hr_payroll Current behaviour: - Time off type name contain year value Expected behaviour: - Time off type name should not contain year value Explanation: - Year changed will not update the time off type name, therefore better to not include the year value inside the name X-original-commit: 224aa76
This update fixes an issue where users were not prompted to close video previews in the Documents module. The fix adds a missing step to the guided tour that instructs users how to properly close preview windows, improving the user experience when working with document previews.
Original PR description
Before this commit: - We do not get the prompt to close the YOUTUBE video preview. After this commit: - We get the prompt to close the preview. Task-3748193 Forward-Port-Of: odoo/enterprise#58519 Forward-Port-Of: odoo/enterprise#56812
A test for the calendar month view was failing when run before 9:00 AM due to incorrect event duration settings. This fix ensures the test properly sets the event duration when adjusting the start time, making the test reliable regardless of when it runs.
Original PR description
The `test_calendar_month_view_start_hour_displayed` makes sure that start hour is displayed in calendar month view. The test was failing before 09:00 AM because after creating the event, it sets the start time to 10:00 without setting the stop time or duration. So when creating this event before 09:00 with a default duration of 1 hour, the stop time would be before 10:00, and it would raise an error. This commit aims to fix this issue by adding a step to set the duration of the event, avoiding the potential error. fixes runbot-59850
When creating a new product, the browser tab was incorrectly showing "Odoo - False" instead of "Odoo - New" until the product name was saved. This fix corrects the display name logic so new products show the proper "New" label, improving the user experience during product creation.
Original PR description
**Current behavior:** When creating a new product template record, the tab title will be *Odoo - False* until a new name is saved rather than *Odoo - New*. **Expected behavior:** When creating a new record in a form view, the tab title will be *Odoo - New* until the `name` field is filled out and the record gets saved (at which point it will be *Odoo - <name>*). **Steps to reproduce:** 1. Install `sale_management` and go to the product list view 2. Create a new product, observe the misnamed tab title **Cause of the issue:** In `product.template`'s _compute_display_name() method, some of the default values can have a 'False' (str) value which will evaluate to True (bool), setting the name to 'False'. **Fix:** Set the display_name field to a False (bool) value if the current record does not have a name field set. opw-3793588
This update corrects minor inconsistencies in the Portuguese Chart of Accounts to ensure full compliance with official regulatory requirements. The changes align the account structure with the published guidelines from the Portuguese accounting authority, ensuring accurate financial reporting for Portuguese companies.
Original PR description
In #87572, the CoA was refactored to follow the regulation for companies under the general regime, which can be found at https://www.occ.pt/fotos/editor2/taxonomiasplanocontas_fev2019.pdf This commit fixes minor discrepancies between our version and the published regulation. Enterprise PR: https://github.com/odoo/enterprise/pull/58387 taskid:3060790 Forward-Port-Of: odoo/odoo#157131
This update improves the visual presentation of notes in sale order reports by applying text justification. The change ensures that note text is properly aligned and formatted for a more professional appearance when customers receive their sale order documents.
Original PR description
opw-3725405