Saturday, March 16, 2024
2 changes
Resolved issues and error corrections
This fix ensures that preparation printers accurately print the details of product variants on receipts, resolving an issue where only the product template name was displayed. This improves kitchen staff's ability to prepare orders correctly, reducing potential errors and improving order fulfillment. The change was implemented as a result of a previous update and includes new tests for variant name and quantity.
Original PR description
Before this fix: Receipts printed with kitchen/preparation printer does not show the details of variants products. Just the product template name. This is ambigious for kitchen as the variant information is generally necessary in order to prepare the order correctly After this fix: Restore the previous behavior regarding the product name used This bug is a side effect of: https://github.com/odoo/odoo/pull/152213 due to the changes to `set_full_product_name` Was also a good occasion to add some tests on the changes name & qty opw-3755391 Forward-Port-Of: odoo/odoo#156390
This update corrects a potential issue where users could accidentally select incorrect payment method lines when creating payments. The fix prevents outdated values by validating the payment method selection, ensuring data integrity and accurate payment recording. This improves the reliability of financial transactions.
Original PR description
When you create or register a payment, the domain of the payment method lines is based on a computed field dependent of the selected journal. The issue is that the interface isn't blocked when…
When you create or register a payment, the domain of the payment method lines is based on a computed field dependent of the selected journal. The issue is that the interface isn't blocked when waiting for the onchange return. So if the user changes the journal, then select the payment method quickly enough while the onchange is still pending, he will be able to select outdated values. It is a limitation of the js framework, so to avoid the user encoding wrong datas, the fix here is to raise a `ValidationError` telling to re-select the payment method. To reproduce: - create second bank journal, with outbound payment method lines having different names than the ones of the first bank journal (in order to distinct them). - slow down the `_compute_payment_method_line_fields` method - create a vendor payment, switch the journal to the one created and select the second payment method (before the onchange ends). - save the payment. -> The payment has a payment method line from a different journal opw-3587241 Enterprise PR: https://github.com/odoo/enterprise/pull/56602 Forward-Port-Of: odoo/odoo#157872 Forward-Port-Of: odoo/odoo#147583