Monday, March 18, 2024
3 changes · master
Resolved issues and error corrections
The project sharing list now hides the customer/partner column when it does not apply to the project type. This reduces confusion for users viewing shared field service projects by only showing relevant information.
Original PR description
Before this commit, the `hide_partner` context was passed by the python method returning the main action for project sharing feature to be able to hide the `partner_id` column in the main view when the project is not billable and nor fsm one. This commit overrides the list view to add that condition in `column_invisible` attribute of `partner_id` field. task-3615844
The task planning dialog now handles single task selection consistently with the regular Select action instead of auto-planning unexpectedly. It also prevents an error when planning tasks without assigned people, making scheduling more reliable for project teams.
Original PR description
In the Plan dialog of the project tasks gantt view, you can choose to either plan your tasks according to the selected timespan with the "Select" button, or you can choose to Auto Plan them with the "Auto plan" button. However, when you click on a single line, it gets auto planned, which shouldn't happen, it should be planned with the logic of the "Select" button. Plus there was a traceback when trying to plan only tasks with no assignees, because we would do a division by zero without checking beforehand that it mustn't happen. This PR aims to fix these problems.
The preparation display tests were reorganized so each screen only loads the test files it actually needs. This prevents unnecessary dependencies from causing errors and helps keep point of sale and preparation display checks stable.
Original PR description
The `pos_preparation_display` launches tours both in the `point_of_sale` and in `pos_preparation_display` interfaces. Previously, it was importing all the tours files from pos, which is not needed and which lead to erros. For example if one of the tours in pos has a dependency in a different folder, than the preparation display would have to bring this dependency too. The solution is to split the test files in the `pos_preparation_display` module into `point_of_sale` and `pos_preparation_display` folders.