Monday, March 18, 2024
21 changes
13 changes
Resolved issues and error corrections
This update fixes an issue where the 'dropship' option was missing from the 'Deliver To' dropdown in RFQs. The change ensures users can correctly select dropshipping for new purchase orders, aligning with previous functionality. This improves the user experience for dropshipping workflows.
Original PR description
**Current behavior:** When making a new RFQ, dropship is not an available selection for the 'Deliver To' option. **Expected behavior:** As on previous versions, you should 'dropship' should be selectable here which reveals a sub-selection to select the customer who should receive the shipment. **Steps to reproduce:** 1. Enable `Dropshipping` in Purchase settings as well as `Storage Locations` in Inventory settings 2. Create a new RFQ, observe that in the 'Deliver To' dropdown there is no way to select a dropship option **Cause of the issue:** Dropshipping was made into a discrete `stock.picking.type`.code and the domain that constrains the selection menu options was not updated to accomodate this change. **Fix:** Update the domain to show picking types that have the dropship code. opw-3764617 Forward-Port-Of: odoo/odoo#155529
This update resolves a bug in the Website Editor that prevented users from correctly resizing columns within the editor iframe. The issue stemmed from a change in how the editor's preview was structured, specifically after version 16.0. This fix ensures proper column resizing functionality.
Original PR description
**[FIX] web_editor: fix resize column outside of the iframe** Steps to reproduce the bug: - Enter Website edit mode. - Drag and drop an "Image-Text" snippet onto the page. - Grab the right edge of…
**[FIX] web_editor: fix resize column outside of the iframe** Steps to reproduce the bug: - Enter Website edit mode. - Drag and drop an "Image-Text" snippet onto the page. - Grab the right edge of the right column of the snippet and extend it to the right until it overflows the iframe and hovers over the editor panel. - Release the mouse, then hover over the iframe again. - Bug: The "mouseUp" event was not triggered, and the column resizing still occurs. This bug occurs because the "mouseUp" event was attached to the <body> of the iframe and not to the window of the iframe. Indeed, for mouse events to be triggered outside of an iframe, they need to be attached to the iframe's window. This fix is not necessary before the version 16.0. Before V16.0, the page preview and the options panel shared the same window. It's only since this commit [1], where we moved the page preview into an iframe, that the bug occurs. [1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b taks-3562970 Forward-Port-Of: odoo/odoo#157627 Forward-Port-Of: odoo/odoo#156529
This update ensures website images automatically adjust to different screen sizes, preventing overflow issues when the default thumbnail style is removed. By adding the 'img-fluid' class, images will now scale correctly, providing a better user experience across devices. This is a simple fix that improves visual consistency.
Original PR description
Add `img-fluid` class so that image remains responsive when `Shape: Thumbnail` is not applied. task-3266862 Forward-Port-Of: odoo/odoo#118916
This update fixes an issue where changing the label of a link within the website editor would remove any associated styling. The fix ensures that style changes to link labels are correctly preserved, improving the user experience when customizing website content. This resolves a visual inconsistency and allows for more flexible content design.
Original PR description
Issue: ====== When you update the link button label from the sidebar it loses its style. Steps to reproduce the issue: ============================= - Got to website editor - Insert a text block - Added a button in the text block and any label - Click on the button to edit it from the sidebar - Change font size or font color or any style you want - Update the label - The style is lost Origin of the issue: ==================== When updating the label, we search for the first child that has that text, but when we have `ZWS start` it will be considered as the first child and then we update the inner text of the `a` element so we loose the span of the text which has the custom styles. Solution: ========= We search for the first child which is not `ZWS` task-3721686 Forward-Port-Of: odoo/odoo#155038
This update fixes a technical issue preventing users from correctly configuring newsletter subscription blocks. Specifically, the 'Display Thanks Button' option was causing errors when combined with certain 'On Success' settings. This change ensures a smoother user experience when setting up newsletter forms.
Original PR description
When configuring a Newsletter Block snippet to display a subscription form, the option to decide whether a message must be displayed is only available when "On Success" is set to "Show Message" through the button beside that option. Unfortunately, the general option for the "Thanks" message is not disabled for other "On Success" values, for which no outcome can display a message. Trying to combine these triggered an error. This commit fixes this problem by hiding the "Display Thanks Button" option when the "Form Subscription" template is selected. Steps to produce: - Install `website_mass_mailing`. - Drop a "Newsletter Block" snippet. - Change template to "Form Subscription". - Click on "Subscribe" button. - Change "On Success" to "Nothing". - Click on "Display Thanks Button". => An error was displayed. task-3748574 Forward-Port-Of: odoo/odoo#157517
This update resolves an issue where submenus wouldn't display properly when the website's navigation switched to 'Hover' mode. The fix adjusts the offset settings within Bootstrap to ensure submenus appear as expected when hovering over menu items, improving the user experience.
Original PR description
Steps to reproduce: - Go to website > Switch the navbar to "Hover" mode (see: `Submenus` > `On Hover`). - Create a submenu and drag it under a navbar menu item > The submenu will always disappear…
Steps to reproduce: - Go to website > Switch the navbar to "Hover" mode (see: `Submenus` > `On Hover`). - Create a submenu and drag it under a navbar menu item > The submenu will always disappear before being reached after the hover. Since Bootstrap does not provide a built-in way to use the "hover" as a dropdown trigger, a custom implementation was used to handle the "show on hover" scenario (see: `hoverableDropdown`). This code also relies on the submenus being correctly positioned on hover. Starting from [1], the public `menuDirection` widget was completely removed (used to align website navbar submenus in an optimal way) and was replaced by a patch that allows Bootstrap to position dropdowns dynamically inside a navbar (using Popper). A side effect of this patch is the use of BS default offset config to set the positions, leading to a small gap that automatically hides the submenus when hovered. The goal of this commit is to prevent this issue by simply forcing the offset to 0 when the dropdowns are inside a navbar. [1]: https://github.com/odoo/odoo/commit/8689241f86e2d4ddb4e4510951f92b80e115b914 opw-3766516 Forward-Port-Of: odoo/odoo#157804 Forward-Port-Of: odoo/odoo#157281
This update fixes an issue where PDF attachments uploaded via the chatter's drag-and-drop feature weren't correctly displayed in the PDF viewer. The fix ensures that attachments uploaded through the dropzone are properly loaded, improving the user experience when viewing invoices.
Original PR description
Steps to reproduce ================== - Go to Accounting > Customer Invoices - Open any record with no attachments - Drag & drop a pdf attachment on the chatter => The PDF viewer is empty Cause of the issue ================== When uploading an attachment from the FileUploader, the parent view is reloaded. This is not the case when uploading an attachment from the dropzone. opw-3748853 Forward-Port-Of: odoo/odoo#157232
This update fixes a bug where the product configurator wasn't shown for products with only custom attributes, preventing users from customizing these items when adding them to their cart. Now, the configurator will automatically open for any product with configurable attributes, streamlining the customization process for simple products.
Original PR description
Before this commit, the product configurator dialog was not shown when adding to the cart, a product with only no variant attribute values, using the buy button on the '/shop' page. Now, if the product has configurable attributes, the product configurator dialog is shown. opw-3736469 Forward-Port-Of: odoo/odoo#157737
This update resolves an issue where the calendar month view incorrectly displayed event start times before 9:00 AM. The fix ensures that event start times are accurately shown, regardless of the event creation time, by setting the event duration. This improves the overall usability of the calendar feature.
Original PR description
The `test_calendar_month_view_start_hour_displayed` makes sure that start hour is displayed in calendar month view. The test was failing before 09:00 AM because after creating the event, it sets the start time to 10:00 without setting the stop time or duration. So when creating this event before 09:00 with a default duration of 1 hour, the stop time would be before 10:00, and it would raise an error. This commit aims to fix this issue by adding a step to set the duration of the event, avoiding the potential error. fixes runbot-59850 Forward-Port-Of: odoo/odoo#157263
A technical issue preventing users from opening the P&L report when using a specific grouping option has been resolved. This fix corrects a typo in a database constraint, ensuring the report functionality works as intended. The change was a result of a minor oversight during a report improvement.
Original PR description
Steps to reproduce: - accounting report > P&L > net profit: set the 'groupby' to 'account_id' - save - try to open the P&L -> Invalid Operation Cause: During the improvement of the report a small change has been forgotten The `groupby` has been changed to `user_groupby` https://github.com/odoo/enterprise/commit/99c82df3d24209de12e2442fd15d2472d9e968f6#diff-bc8d6ed5aa6dab6b7ba46566170cdb7297104580d9b8d6c7081f72e3c2a5a9c4R187-R191 and we forgot to change the `api.constrains`'s args opw-3714626 Forward-Port-Of: odoo/odoo#156879
This update ensures that employees and users automatically have an avatar displayed when a picture isn't manually set. Previously, a blank space was shown. This enhancement provides a more professional and consistent user experience, especially for new internal users.
Original PR description
Improve avatar picture : if no picture is set, initials will be displayed. task : 3637523 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#147446
This update fixes an issue where notes on sale orders weren't consistently formatted in the sale order report. The change ensures that notes are properly aligned and readable, improving the clarity and professionalism of the reports generated for sales data. This enhances the user experience when reviewing sales information.
Original PR description
opw-3725405 Forward-Port-Of: odoo/odoo#157859
This update fixes a visual issue where 'false' was incorrectly displayed next to recipients in the system when their email address was missing. Now, users without email addresses are shown with their name followed by '(no email address)', improving the user experience and ensuring accurate recipient information is presented.
Original PR description
'false' is displayed in the popover next to the recipients in the absence of an email address as well as the title of the recipients If the partner has no email, it should show something like "[name] (no email address)]" task-3787703 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#157850 Forward-Port-Of: odoo/odoo#157431
2 changes
Resolved issues and error corrections
The project sharing list now hides the customer/partner column when it does not apply to the project type. This reduces confusion for users viewing shared field service projects by only showing relevant information.
Original PR description
Before this commit, the `hide_partner` context was passed by the python method returning the main action for project sharing feature to be able to hide the `partner_id` column in the main view when the project is not billable and nor fsm one. This commit overrides the list view to add that condition in `column_invisible` attribute of `partner_id` field. task-3615844
The preparation display tests were reorganized so each screen only loads the test files it actually needs. This prevents unnecessary dependencies from causing errors and helps keep point of sale and preparation display checks stable.
Original PR description
The `pos_preparation_display` launches tours both in the `point_of_sale` and in `pos_preparation_display` interfaces. Previously, it was importing all the tours files from pos, which is not needed and which lead to erros. For example if one of the tours in pos has a dependency in a different folder, than the preparation display would have to bring this dependency too. The solution is to split the test files in the `pos_preparation_display` module into `point_of_sale` and `pos_preparation_display` folders.
6 changes
Resolved issues and error corrections
This update improves the performance of the Brazilian EDI module by fixing how certain features are calculated and displayed. The changes separate visibility logic from email field processing and remove unnecessary system triggers, resulting in faster and more efficient document handling without affecting user-facing functionality.
Original PR description
- Whether the option is visible or not shouldn't depend on the `mail_extra_fields` compute. Use a separate compute to avoid useless processing. - Wrong moves used in the warning computation. - Remove useless trigger in `api.depends` to avoid unecessary computations.
This update corrects the positioning of the message that appears when marking timesheets as billable or non-billable in project tasks. The message was appearing in the wrong location due to an imprecise technical selector, which has now been fixed to display correctly.
Original PR description
Versions: --------- - 17.0 Issue: ------ Message for flag timesheet from project as billable/non-billable is misplaced. Cause: ------ Xpath given for Message placed in sale_timsheet is not very specific. Solution: --------- Give accurate xpath for message div. task-3630449
This update corrects the display order of company identification numbers in Czech Republic reports to match local standards. The Company ID (IČO) now appears before the VAT ID (DIČ), and the label has been clarified to "Company ID" for better clarity. This is a minor formatting adjustment to report templates with no impact on system functionality.
Original PR description
In Czech republic, the standard is to first render Company ID (IČO), and then to render VAT ID (DIČ). What I did in this commit is: - changing the position to before (not after), so company ID renders before VAT ID - I changed a label from ID to Company ID (so it is obvious in what ID it is) - This should not cause any harm, as we are just doing tiny changes in a view, not changing any logic. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update corrects the display order of company identification fields on Czech invoices to comply with local standards. The Company ID (IČO) now appears before the VAT ID (DIČ), and the label has been clarified to "Company ID" for better clarity. This is a minor formatting adjustment to the invoice report template with no impact on business logic or data.
Original PR description
In Czech republic, the standard is to first render Company ID (IČO), and then to render VAT ID (DIČ). What I did in this commit is: changing the position to before (not after), so company ID renders before VAT ID I changed a label from ID to Company ID (so it is obvious in what ID it is) This should not cause any harm, as we are just doing tiny changes in a view, not changing any logic. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes a test that was failing intermittently due to timing issues. The test now properly waits for WebSocket connections to be fully established before checking results, ensuring more reliable testing and fewer false failures in our quality assurance process.
Original PR description
Before this commit, the `test_websocket_instances_weak_set` was sometimes failing. Indeed, this test doesn't wait for the connection to be fully established before making its assertions. This commit fixes this issue. fixes runbot-55037,55035 Forward-Port-Of: odoo/odoo#157433
This update fixes the display order of company identification numbers on Czech invoices to match local standards. Company ID (IČO) now appears before VAT ID (DIČ), and the label has been clarified from "ID" to "Company ID" for better clarity. This ensures invoices comply with Czech business practices.
Original PR description
In Czech republic, the standard is to first render Company ID (IČO), and then to render VAT ID (DIČ). - Changing the position to before (not after), so company ID renders before VAT ID. - Changed label from "ID" to "Company ID" (so it is obvious in what ID it is). Original fixes by @cunivca: odoo/odoo#149339, odoo/odoo#149340, merged into one. Related: https://github.com/odoo/odoo/commit/d0704a19de31e0251d343081ae6b3da9991a248e