Tuesday, March 19, 2024
7 changes · 17.0
Enhancements to existing features
This update removes redundant code from the subscription module that was accidentally duplicated during a recent update. By eliminating this duplicate method, the code is cleaner and easier to maintain without affecting any customer-facing functionality.
Resolved issues and error corrections
Creating a new attendee from an event now automatically keeps the correct event filled in, even when Event Social and Event Sale are both installed. This prevents manual re-entry and reduces the chance of attendees being linked to the wrong or no event.
Original PR description
**Steps to reproduce:** - Open an event form - Open the list of attendees through the stat button - Click on 'New' to add an attendee. - The value of event field is not set by default. The issue mentioned above is faced only when both `event_social` and `event_sale` are installed together. **Cause:** The `onchange` method is called twice when both modules are installed. When `default_get` is called for the second time, 'default_event_id' is missing from the context and hence, the field 'event_id' is not set by default. **Fix:** This PR adds a default attribute to the field `event_id` to ensure that the field is always set by default. Task: [3596663](https://www.odoo.com/web#id=3596663&menu_id=4722&cids=2&action=333&active_id=10888&model=project.task&view_type=form)
This update improves the visual feedback when users interact with appointment scheduling forms. It fixes the focus state styling on calendar buttons and appointment cards, ensuring users receive clear visual indicators when navigating through the appointment booking interface.
Original PR description
This commit fixes focuses state on the calendar buttons and on cards in the appointment form task-3607520 Community PR: https://github.com/odoo/odoo/pull/144186
The automated test for amount rounding in financial reports was failing inconsistently due to timing issues. The fix improves the test's reliability by using more robust detection methods, ensuring the test accurately validates that amounts are rounded correctly in accounting reports.
Original PR description
The amount rounding tour was broken. As it used `:contains(), it was always checking for a substring of the current value of a line. Since it has to wait for the change to open (rpc call), there was a lot of indeterminism. It is fixed by adding more robust extra triggers.
This update fixes a visual alignment issue in the portal where the page navigation (pager) was missing proper spacing from the bottom. The fix ensures the portal pages display with correct formatting and improved user experience.
Original PR description
The pager was not getting the margin from the bottom. This PR fixes the issue by providing the appropriate margin to the pager. Task-3792586
This fix addresses a test failure in the website menu editing functionality. When a menu has no extra items initially but gains them after switching to edit mode, the menu would close unexpectedly, causing tests to fail. The fix restores a step that opens the extra menu while being smart enough not to close it if it's already open.
Original PR description
Starting from The "unbreakable menu fix" on `16.0` (see: [1]), the state of the website extra menu was stored before every "resize" adaptation, so it can be possible to reopen it if it was already…
Starting from The "unbreakable menu fix" on `16.0` (see: [1]), the state of the website extra menu was stored before every "resize" adaptation, so it can be possible to reopen it if it was already opened. On `17.0`, the same behaviour was fixed using the `odooEditor` > `withoutRollback()` mechanism (see: [2]), and a step was added to the `edit_menus` test (`clickOnExtraMenuItem`) to open the extra menu after the "edit mode resize" [3]. The forward port of [1], on `17.0` was adapted to keep the main fix from [2], and removed the tour step since the extra menu will be automatically opened if it was already open before the "resize". Now, if we have a menu with no overflowing items before the resize, and after switching to "edit" mode an extra menu was added, this menu will be closed by default which makes the test fail without the step in [3]. The goal of this commit is to fix this behaviour by simply restoring the `clickOnExtraMenuItem` step with a simple tweak: We don't click if the extra menu is already opened to prevent closing it again. Remark: the test failed on `17.0` but the commit is targeting `16.0` to prevent any test failure linked to the "extra menu auto open" feature. [1]: https://github.com/odoo/odoo/commit/2598cc9ef7fe89a0ce5e375bca6f6a781f6ffdf7 [2]: https://github.com/odoo/odoo/commit/cbed990924887eb529056d89a042a92ba27b825b Related to opw-3484742 Related to task-3439226 Forward-Port-Of: odoo/odoo#155559
This update removes the "amount_to_invoice" field from the Quotations list view, as it displays empty values for quotations and serves no purpose. The fix corrects the display attribute used in the view configuration to properly hide this column from users.
Original PR description
In the Quotations list view, it is possible to show "amount_to_invoice" field. However, this field is empty for quotations and therefore useless. It should be set as invisible for quotations. An inherited view was already taking care of it, but was using "invisible" attribute instead of "column_invisible" attribute. opw-3722037 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr