Tuesday, March 19, 2024
4 changes · saas-17.1
Resolved issues and error corrections
This update resolves a bug where the survey join link wasn't copying to the clipboard when accessed within a live session. The issue was due to a technical problem with how the link was being targeted, and has now been corrected. Users can now reliably copy and share the survey link.
Original PR description
Steps to reproduce =================== - Launch a survey in a live session. - Start the survey. - Click on the link to join. - The link didn't copy to the clipboard. Technical =========== Here the target element is the input tag so 'textcontent' will not work for that moved the 'o_survey_session_copy_url' class in span tag. This commit has resulted in a breakdown of the feature's https://github.com/odoo/odoo/commit/b62eff731b06520f9669684635cbed408e0fc35c After this commit ================== The link will be copied to the clipboard. Task-3792666
This update resolves an issue where the website's extra menu editing test was failing in version 17.0. The fix ensures the test remains stable by preventing the extra menu from being closed automatically after resizing, addressing a previous state management problem.
Original PR description
Starting from The "unbreakable menu fix" on `16.0` (see: [1]), the state of the website extra menu was stored before every "resize" adaptation, so it can be possible to reopen it if it was already…
Starting from The "unbreakable menu fix" on `16.0` (see: [1]), the state of the website extra menu was stored before every "resize" adaptation, so it can be possible to reopen it if it was already opened. On `17.0`, the same behaviour was fixed using the `odooEditor` > `withoutRollback()` mechanism (see: [2]), and a step was added to the `edit_menus` test (`clickOnExtraMenuItem`) to open the extra menu after the "edit mode resize" [3]. The forward port of [1], on `17.0` was adapted to keep the main fix from [2], and removed the tour step since the extra menu will be automatically opened if it was already open before the "resize". Now, if we have a menu with no overflowing items before the resize, and after switching to "edit" mode an extra menu was added, this menu will be closed by default which makes the test fail without the step in [3]. The goal of this commit is to fix this behaviour by simply restoring the `clickOnExtraMenuItem` step with a simple tweak: We don't click if the extra menu is already opened to prevent closing it again. Remark: the test failed on `17.0` but the commit is targeting `16.0` to prevent any test failure linked to the "extra menu auto open" feature. [1]: https://github.com/odoo/odoo/commit/2598cc9ef7fe89a0ce5e375bca6f6a781f6ffdf7 [2]: https://github.com/odoo/odoo/commit/cbed990924887eb529056d89a042a92ba27b825b Related to opw-3484742 Related to task-3439226 Forward-Port-Of: odoo/odoo#155559
This update resolves an issue where the filtering of work locations in the HR module was incorrectly restricted. The previous change caused problems with how employees were assigned to their work locations. This fix ensures accurate location filtering within the HR system.
Original PR description
With this commit, the domain of work location domain is reintroduced. It was a mistake introduced by this PR : odoo/odoo#129308 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#157441
This update resolves an issue where automatic invoice creation would trigger errors and tracebacks. The fix ensures invoices are correctly handled, preventing errors during payment processing and improving the reliability of invoice generation. This improves the overall customer experience.
Original PR description
Before this commit, when the automatic invoice setting is enabled, a traceback would be shown when customers pay and the post-processing of the transaction tries to create an invoice. The problem is that the invoice is created in sudo, but it's unsudoed before logging invoices in the chatter. Now, the invoice will stay sudoed if the method is called in sudo. opw-3700576 Forward-Port-Of: odoo/odoo#157779