Daily updates from Odoo
Tuesday, March 19, 2024
12 changes
1 change
Resolved issues and error corrections
This fix prevents duplicate or unnecessary chat notifications during message posting. It reduces timing-related issues that could cause inconsistent behavior, helping messaging work more reliably for users.
Original PR description
Currently, the message post is done in two steps: first writing the last_interest_dt to the channel, then creating the message, second triggering the notify_thread to send the message to the followers. In the first step, the last_interest_dt will be directly sent to the client if it differs from the old value. So there is no need to send the message to the client if the last_interest_dt has not changed in the second step. Also, this can lead to a racing condition in the testing files. This commit removes the notif in the second step and changes the testing files related. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
3 changes
Resolved issues and error corrections
This update resolves a bug where the survey join link wasn't copying to the clipboard when accessed within a live session. The issue was due to a technical problem with how the link was being targeted, and has now been corrected. Users can now reliably copy and share the survey link.
Original PR description
Steps to reproduce =================== - Launch a survey in a live session. - Start the survey. - Click on the link to join. - The link didn't copy to the clipboard. Technical =========== Here the target element is the input tag so 'textcontent' will not work for that moved the 'o_survey_session_copy_url' class in span tag. This commit has resulted in a breakdown of the feature's https://github.com/odoo/odoo/commit/b62eff731b06520f9669684635cbed408e0fc35c After this commit ================== The link will be copied to the clipboard. Task-3792666
This update resolves an issue where the website's extra menu editing test was failing in version 17.0. The fix ensures the test remains stable by preventing the extra menu from being closed automatically after resizing, addressing a previous state management problem.
Original PR description
Starting from The "unbreakable menu fix" on `16.0` (see: [1]), the state of the website extra menu was stored before every "resize" adaptation, so it can be possible to reopen it if it was already…
Starting from The "unbreakable menu fix" on `16.0` (see: [1]), the state of the website extra menu was stored before every "resize" adaptation, so it can be possible to reopen it if it was already opened. On `17.0`, the same behaviour was fixed using the `odooEditor` > `withoutRollback()` mechanism (see: [2]), and a step was added to the `edit_menus` test (`clickOnExtraMenuItem`) to open the extra menu after the "edit mode resize" [3]. The forward port of [1], on `17.0` was adapted to keep the main fix from [2], and removed the tour step since the extra menu will be automatically opened if it was already open before the "resize". Now, if we have a menu with no overflowing items before the resize, and after switching to "edit" mode an extra menu was added, this menu will be closed by default which makes the test fail without the step in [3]. The goal of this commit is to fix this behaviour by simply restoring the `clickOnExtraMenuItem` step with a simple tweak: We don't click if the extra menu is already opened to prevent closing it again. Remark: the test failed on `17.0` but the commit is targeting `16.0` to prevent any test failure linked to the "extra menu auto open" feature. [1]: https://github.com/odoo/odoo/commit/2598cc9ef7fe89a0ce5e375bca6f6a781f6ffdf7 [2]: https://github.com/odoo/odoo/commit/cbed990924887eb529056d89a042a92ba27b825b Related to opw-3484742 Related to task-3439226 Forward-Port-Of: odoo/odoo#155559
This update resolves an issue where the filtering of work locations in the HR module was incorrectly restricted. The previous change caused problems with how employees were assigned to their work locations. This fix ensures accurate location filtering within the HR system.
Original PR description
With this commit, the domain of work location domain is reintroduced. It was a mistake introduced by this PR : odoo/odoo#129308 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#157441
3 changes
Resolved issues and error corrections
New employee and internal user records now receive a generated avatar based on their name when no image is provided during creation. This keeps profiles visually consistent and avoids blank images in employee and user-related workflows.
Original PR description
Ensure an avatar is generated based on the employee/user name if no image is provided at the record creation (for internal users only). Taskid: 3637523 X-original-commit: 9d11d2087378e1a56333e11daa18e6dc1b8c655e
This fixes the French Intrastat module so it relies on the correct French accounting module. It prevents installation or setup issues caused by pointing to an outdated dependency after recent localization changes.
Original PR description
This commit https://github.com/odoo/enterprise/commit/dbc8be11dacb24cd431d87936dff71d8d7c73e45, merged very recently in master (17.2), added a wrong dependency. l10n_fr is no longer the module that handles the accounting of the French localization, this role now belongs to l10n_fr_account.
The US payroll module no longer requires an accounting localization module that is not needed for core HR payroll use. This prevents upgrade problems for customers who use HR payroll without the related accounting module installed.
Original PR description
Fix the dependencies of the module by removing the one with l10n_us. Base hr modules should not depend on account modules, and it causes issues during upgrades if the hr module is installed in 17.1 without the account module.
5 changes
Resolved issues and error corrections
This update improves the visual feedback when users interact with appointment scheduling forms. It fixes the focus state styling on calendar buttons and appointment cards, ensuring users receive clear visual indicators when navigating through the appointment booking interface.
Original PR description
This commit fixes focuses state on the calendar buttons and on cards in the appointment form task-3607520 Community PR: https://github.com/odoo/odoo/pull/144186
The automated test for amount rounding in financial reports was failing inconsistently due to timing issues. The fix improves the test's reliability by using more robust detection methods, ensuring the test accurately validates that amounts are rounded correctly in accounting reports.
Original PR description
The amount rounding tour was broken. As it used `:contains(), it was always checking for a substring of the current value of a line. Since it has to wait for the change to open (rpc call), there was a lot of indeterminism. It is fixed by adding more robust extra triggers.
This update fixes a visual alignment issue in the portal where the page navigation (pager) was missing proper spacing from the bottom. The fix ensures the portal pages display with correct formatting and improved user experience.
Original PR description
The pager was not getting the margin from the bottom. This PR fixes the issue by providing the appropriate margin to the pager. Task-3792586
This fix addresses a test failure in the website menu editing functionality. When a menu has no extra items initially but gains them after switching to edit mode, the menu would close unexpectedly, causing tests to fail. The fix restores a step that opens the extra menu while being smart enough not to close it if it's already open.
Original PR description
Starting from The "unbreakable menu fix" on `16.0` (see: [1]), the state of the website extra menu was stored before every "resize" adaptation, so it can be possible to reopen it if it was already…
Starting from The "unbreakable menu fix" on `16.0` (see: [1]), the state of the website extra menu was stored before every "resize" adaptation, so it can be possible to reopen it if it was already opened. On `17.0`, the same behaviour was fixed using the `odooEditor` > `withoutRollback()` mechanism (see: [2]), and a step was added to the `edit_menus` test (`clickOnExtraMenuItem`) to open the extra menu after the "edit mode resize" [3]. The forward port of [1], on `17.0` was adapted to keep the main fix from [2], and removed the tour step since the extra menu will be automatically opened if it was already open before the "resize". Now, if we have a menu with no overflowing items before the resize, and after switching to "edit" mode an extra menu was added, this menu will be closed by default which makes the test fail without the step in [3]. The goal of this commit is to fix this behaviour by simply restoring the `clickOnExtraMenuItem` step with a simple tweak: We don't click if the extra menu is already opened to prevent closing it again. Remark: the test failed on `17.0` but the commit is targeting `16.0` to prevent any test failure linked to the "extra menu auto open" feature. [1]: https://github.com/odoo/odoo/commit/2598cc9ef7fe89a0ce5e375bca6f6a781f6ffdf7 [2]: https://github.com/odoo/odoo/commit/cbed990924887eb529056d89a042a92ba27b825b Related to opw-3484742 Related to task-3439226 Forward-Port-Of: odoo/odoo#155559
This update removes the "amount_to_invoice" field from the Quotations list view, as it displays empty values for quotations and serves no purpose. The fix corrects the display attribute used in the view configuration to properly hide this column from users.
Original PR description
In the Quotations list view, it is possible to show "amount_to_invoice" field. However, this field is empty for quotations and therefore useless. It should be set as invisible for quotations. An inherited view was already taking care of it, but was using "invisible" attribute instead of "column_invisible" attribute. opw-3722037 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr