Friday, March 22, 2024
10 changes · saas-17.2
Resolved issues and error corrections
This update improves and modernizes internal automated tests for the Gantt view, reducing timing-related test failures. It helps keep future changes safer and more reliable without changing the user-facing product behavior.
Original PR description
Part 1: https://github.com/odoo/odoo/pull/152930 Part 2: https://github.com/odoo/odoo/pull/153018 Part 3: https://github.com/odoo/odoo/pull/153023 Part 4: https://github.com/odoo/odoo/pull/153203…
Part 1: https://github.com/odoo/odoo/pull/152930 Part 2: https://github.com/odoo/odoo/pull/153018 Part 3: https://github.com/odoo/odoo/pull/153023 Part 4: https://github.com/odoo/odoo/pull/153203 Part 5: https://github.com/odoo/odoo/pull/153425 Part 6: https://github.com/odoo/odoo/pull/153700 Part 7: https://github.com/odoo/odoo/pull/154054 Part 8: https://github.com/odoo/odoo/pull/154579 Part 9: https://github.com/odoo/odoo/pull/155073 Part 10: https://github.com/odoo/odoo/pull/155639 Part 11: https://github.com/odoo/odoo/pull/156255 / https://github.com/odoo/enterprise/pull/58135 Part 12: https://github.com/odoo/odoo/pull/156869 Community: https://github.com/odoo/odoo/pull/158384 This pull requests brings various improvements and fixes to Hoot and the Odoo unit test ecosystem. See the different commit messages for more details. Note: these changes are made in stable to avoid having to support multiple versions of the HOOT API. As such, these changes are intended to be strictly limited to unit tests as to not put the rest of the code base at risk. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed broken links on the Barcode app homepage and barcode-related print links in Inventory and Manufacturing settings. Users can now access these pages and documents without encountering missing action errors.
Original PR description
The purpose of this PR is to fix the broken links on the homepage of the barcode app in addition to the print links in the settings of Inventory and Manufacturing apps related to barcodes. Before, clicking on these links led to an error of `The action ... does not exist`. As dictated by odoo/enterprise#58078, urls now have to start with a "/" in order to work properly. Task-3821539
This fixes an access issue that could occur when branch invoices were reconciled with refunds from the parent company. Moroccan reporting can now retrieve the related payment information without blocking users due to branch access restrictions.
Original PR description
Since this pr: https://github.com/odoo/enterprise/pull/51954, multiples test from test_company_branch were failing due to access rights. The reason is that in l10n_ma_report, we used a function called _get_reconciled_payments, that is a helper to retrieve the reconciled payments on a journal entry. This method will call _get_reconciled_amls (to retrieve the reconciled move lines on a journal entry) and then return the payment_id from the move. When being in the branch environment with an invoice from the branch and a refund from the root company, doing the reconciliation between the two will cause an access right error. The way we solved this, is to add a sudo so that we can access the move without having an error. Task: 3802369
Message posting in discussion channels now avoids sending a duplicate update when the channel activity timestamp has not changed. This reduces race-condition issues in tests and helps keep WhatsApp discussion behavior more stable.
Original PR description
Currently, posting a message to discuss channels is done in two steps: first writing the last_interest_dt to the channel, then creating the message, second triggering the notify_thread to send the message to the followers. In the first step, the last_interest_dt will be directly sent to the client if it differs from the old value. So there is no need to send the message to the client if the last_interest_dt has not changed in the second step. Also, this can lead to a racing condition in the testing files. This commit removes the notif in the second step. Also, adapting the mock_models to the new behavior as the follow-up of https://github.com/odoo/odoo/pull/155569 https://github.com/odoo/odoo/pull/158134
Fixed an issue where pasting content from the operating system clipboard could fail or behave incorrectly when working with spreadsheet comments. This helps users move information into spreadsheets more reliably and reduces friction during everyday editing.
Original PR description
The clipboard handler of the comments did not account properly for the pasting from the OS clipboard. Task: 3813759
Posting messages in Discuss channels now avoids sending a duplicate update when the channel activity timestamp has not changed. This reduces race-condition errors and makes chat and live chat behavior more stable for users.
Original PR description
Currently, posting a message to discuss channels is done in two steps: first writing the last_interest_dt to the channel, then creating the message, second triggering the notify_thread to send the message to the followers. In the first step, the last_interest_dt will be directly sent to the client if it differs from the old value. So there is no need to send the message to the client if the last_interest_dt has not changed in the second step. Also, this can lead to a racing condition in the testing files. This commit removes the notif in the second step. Also, adapting the mock_models to the new behavior as the follow-up of https://github.com/odoo/odoo/pull/155569 https://github.com/odoo/enterprise/pull/59130 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The calendar year view now keeps month header backgrounds visible when users scroll. This prevents overlapping text and makes the calendar easier to read, especially in smaller browser windows.
Original PR description
In Odoo in the custom `year` FullCalendar view we embed twelve custom `month` FullCalendar views, and it has the option `height` set to `auto`. In FullCalendar (V6), when the `dayGrid` FullCalendar…
In Odoo in the custom `year` FullCalendar view we embed twelve custom `month` FullCalendar views, and it has the option `height` set to `auto`.
In FullCalendar (V6), when the `dayGrid` FullCalendar view as the option `height`/`viewHeight` equals to `auto` it is the same to have the option `stickyHeaderDates` set to `true`.
When the option `stickyHeaderDates` is enabled, the class `fc-scrollgrid-section-sticky` is added to the header of the FullCalendar view. This class as the following rule:
```css
.fc .fc-scrollgrid-section-sticky > * {
background: var(--fc-page-bg-color);
position: sticky;
z-index: 3;
}
```
And since the upgrade of FullCalendar to version 6[1], we have added the following CSS rule.
```css
.o_calendar_widget {
--fc-page-bg-color: none;
}
```
As we have set the `color` to `none`, the `background-color` of the element is `transparent` and so the text overlaps the text behind.
This commit simplifies the CSS rules and fixes the issue.
PS: the old override of the `--fc-page-bg-color` color was to support the dark theme.
From FullCalendar doc[2]
> stickyHeaderDates
> Whether to fix the date-headers at the top of the calendar to the
> viewport while scrolling.
Steps to reproduce:
* Open the Calendar App
* Select the "Year" FullCalendar view
* Resize the window to have a vertical scrollbar if needed
* Scroll down => BUG some day headers have `position` `sticky` with no background.
[1]: odoo/odoo@90f85a19deaea33cd747c969762ff20f1d59ef4c
[2]: https://fullcalendar.io/docs/stickyHeaderDates
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe manufacturing Bill of Materials overview now works correctly when Odoo is used in debug mode. This prevents an error that could interrupt troubleshooting or advanced configuration work, and adds coverage to ensure the overview appears properly in guided tests.
Original PR description
In this [commit](https://github.com/odoo/odoo/commit/3ad4fd65387f60b524e5f786556963ead8ae9dfe#diff-552aefb62246b1f4fe6a2607ec8f0a01773e53de2d68293266b38bc99c5cb56dR569-R577), the updateResId has been added to the action props. This did not trigger any error as the props are not validated, except if in debug mode. Adding the standardActionServiceProps solves this problem. This bug highlighted another problem: the component does not appear in a tour. opw-3822623 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where creating a planned task from the Gantt view could miss allocated hours when Timesheets was not installed. The task form now includes the needed field so planning calculations run reliably for Project users.
Original PR description
Before this commit, when only project and project_enterprise are instaleld and we try to plan a new task in the gantt view. The compute allocated_hours is not triggered during the onchange because the field is not defined in the form view used by the gantt view. This commit makes sure the allocated_hours field of `project.task` is defined even if `hr_timesheet` is not installed to be sure the compute of that field is triggered during the onchange when we create a task. runbot-58150
Spreadsheet users now receive a more helpful error message when a pivot formula uses an invalid measure. The message shows the available measures, making it easier to correct the formula without extra troubleshooting.
Original PR description
Before this commit, applying a pivot formula with an invalid measure returns an error message without showing possible measures. This commit fixed that Task 3754942 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr