Daily updates from Odoo
Friday, March 22, 2024
16 changes
5 changes
Resolved issues and error corrections
Posting messages in Discuss channels now avoids sending a duplicate update when the channel activity timestamp has not changed. This reduces race-condition errors and makes chat and live chat behavior more stable for users.
Original PR description
Currently, posting a message to discuss channels is done in two steps: first writing the last_interest_dt to the channel, then creating the message, second triggering the notify_thread to send the message to the followers. In the first step, the last_interest_dt will be directly sent to the client if it differs from the old value. So there is no need to send the message to the client if the last_interest_dt has not changed in the second step. Also, this can lead to a racing condition in the testing files. This commit removes the notif in the second step. Also, adapting the mock_models to the new behavior as the follow-up of https://github.com/odoo/odoo/pull/155569 https://github.com/odoo/enterprise/pull/59130 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The calendar year view now keeps month header backgrounds visible when users scroll. This prevents overlapping text and makes the calendar easier to read, especially in smaller browser windows.
Original PR description
In Odoo in the custom `year` FullCalendar view we embed twelve custom `month` FullCalendar views, and it has the option `height` set to `auto`. In FullCalendar (V6), when the `dayGrid` FullCalendar…
In Odoo in the custom `year` FullCalendar view we embed twelve custom `month` FullCalendar views, and it has the option `height` set to `auto`.
In FullCalendar (V6), when the `dayGrid` FullCalendar view as the option `height`/`viewHeight` equals to `auto` it is the same to have the option `stickyHeaderDates` set to `true`.
When the option `stickyHeaderDates` is enabled, the class `fc-scrollgrid-section-sticky` is added to the header of the FullCalendar view. This class as the following rule:
```css
.fc .fc-scrollgrid-section-sticky > * {
background: var(--fc-page-bg-color);
position: sticky;
z-index: 3;
}
```
And since the upgrade of FullCalendar to version 6[1], we have added the following CSS rule.
```css
.o_calendar_widget {
--fc-page-bg-color: none;
}
```
As we have set the `color` to `none`, the `background-color` of the element is `transparent` and so the text overlaps the text behind.
This commit simplifies the CSS rules and fixes the issue.
PS: the old override of the `--fc-page-bg-color` color was to support the dark theme.
From FullCalendar doc[2]
> stickyHeaderDates
> Whether to fix the date-headers at the top of the calendar to the
> viewport while scrolling.
Steps to reproduce:
* Open the Calendar App
* Select the "Year" FullCalendar view
* Resize the window to have a vertical scrollbar if needed
* Scroll down => BUG some day headers have `position` `sticky` with no background.
[1]: odoo/odoo@90f85a19deaea33cd747c969762ff20f1d59ef4c
[2]: https://fullcalendar.io/docs/stickyHeaderDates
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe manufacturing Bill of Materials overview now works correctly when Odoo is used in debug mode. This prevents an error that could interrupt troubleshooting or advanced configuration work, and adds coverage to ensure the overview appears properly in guided tests.
Original PR description
In this [commit](https://github.com/odoo/odoo/commit/3ad4fd65387f60b524e5f786556963ead8ae9dfe#diff-552aefb62246b1f4fe6a2607ec8f0a01773e53de2d68293266b38bc99c5cb56dR569-R577), the updateResId has been added to the action props. This did not trigger any error as the props are not validated, except if in debug mode. Adding the standardActionServiceProps solves this problem. This bug highlighted another problem: the component does not appear in a tour. opw-3822623 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where creating a planned task from the Gantt view could miss allocated hours when Timesheets was not installed. The task form now includes the needed field so planning calculations run reliably for Project users.
Original PR description
Before this commit, when only project and project_enterprise are instaleld and we try to plan a new task in the gantt view. The compute allocated_hours is not triggered during the onchange because the field is not defined in the form view used by the gantt view. This commit makes sure the allocated_hours field of `project.task` is defined even if `hr_timesheet` is not installed to be sure the compute of that field is triggered during the onchange when we create a task. runbot-58150
Spreadsheet users now receive a more helpful error message when a pivot formula uses an invalid measure. The message shows the available measures, making it easier to correct the formula without extra troubleshooting.
Original PR description
Before this commit, applying a pivot formula with an invalid measure returns an error message without showing possible measures. This commit fixed that Task 3754942 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
2 changes
Resolved issues and error corrections
This update resolves an issue preventing sale reports from generating correctly when multiple bank accounts were used for a payment. The previous system required a single account payment, which is now corrected. This ensures accurate reporting for all sales transactions, regardless of payment method.
Original PR description
Following commit https://github.com/odoo/odoo/commit/d9190e34543c4a1151656859acb41556bcb3a364, generating a sale report became impossible if a session had more than one account payment. This was due to a ValueError: Expected singleton. opw-3799171 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#157426
This update fixes a default setting in the restaurant POS module that was incorrectly configured for US customers in the SaaS environment. Previously, the system automatically enabled tipping after payment, regardless of the user's country. This change ensures a better experience for all users by removing the US-specific default.
Original PR description
In SaaS, the DB is pre-prepared with the generic chart of accounts before the new user finishes the form. Since the default country of the generic chart of accounts is the US, then `set_tip_after_payment` option in the pre-created pos.config is set to True. Now, when the form is submitted, the country is identified but the said option remains to be True. This is a problem because not all customers are creating an odoo instance for a US company. So customers from other countries will have the option activated by default which is not a good default for them. We introduced this behavior in aa1c5b53bf131c6df96ad621e00bd2ee3d44c6c0 and in this commit we won't set the option by default anymore. Forward-Port-Of: odoo/odoo#149542
3 changes
Resolved issues and error corrections
This update rewrites complex reporting queries in a safer internal format so automated checks can handle them reliably. It helps reduce false alarms and maintenance risk in accounting and localization reports without changing day-to-day user workflows.
Original PR description
After some improvements the SQL checker now sees those queries, and can't cope with their complexity. Also deprecate `AccountReport._query_get`, literally all it does is unwrap `_get_table_expression` making things harder to check.
Users can now duplicate read-only Sign templates without encountering an error. This makes it easier to reuse existing templates and continue document workflows without interruption.
Original PR description
Before this commit, when duplicating a read-only template a traceback was being triggered since we were passing a single template to the copy method. After this commit, we call the copy function passing a batch of a single element, which will return a list of templates containing a single template. After that, we call the action to open this copied template. task-3790206
The Helpdesk team setup screen now displays the Team Members label correctly when automatic assignment is enabled. This small visual fix makes the configuration form look cleaner and easier to read for administrators.
Original PR description
Steps to reproduce: - install helpdesk - under configuration, click on helpdesk teams - In helpdesk teams form view enable automatic assignment Issue: - under automatic assignment, the 'team members' label is not centered Solution: - By giving d-flex to the div tag of label the issue will be solved. task-3683976
6 changes
Resolved issues and error corrections
The Swedish tax report has been updated with new values for specific report sections (blocks F and G). This change updates the corresponding test cases to ensure they accurately validate the new report calculations. This ensures the tax reporting functionality continues to work correctly with the updated report structure.
Original PR description
The values of blocks F and G have been changed on the sweedish tax report on the `l10n_se` module. This commit adapt the tests accordingly. Forward-Port-Of: odoo/enterprise#58870 Forward-Port-Of: odoo/enterprise#58508
This update refreshes the X (formerly Twitter) logo and branding colors throughout the social media integration module. The changes ensure that Odoo's social media features display the current X branding, keeping the platform aligned with the rebranded service.
Original PR description
*: website_twitter_wall This commit involves adjustments to a few images and SVG files to incorporate the new X (previously called Twitter) logo. related to: https://github.com/odoo/odoo/pull/148126 task-3463530 Forward-Port-Of: odoo/enterprise#59056 Forward-Port-Of: odoo/enterprise#53644
This fix addresses a test that was failing unpredictably in the Mexican POS invoicing feature. The test was relying on demo data that could vary depending on what other modules were installed, causing inconsistent results. The fix uses a dedicated test partner and removes unnecessary configuration steps to ensure the test runs reliably every time.
Original PR description
Since 39a0542b6505e18e3fdfbefba4210d8ba87bae3c, the value of `l10n_mx_edi_cfdi_to_public` depends on the partner linked to the pos_order. For instance, a mexican partner without VAT will have…
Since 39a0542b6505e18e3fdfbefba4210d8ba87bae3c, the value of `l10n_mx_edi_cfdi_to_public` depends on the partner linked to the pos_order. For instance, a mexican partner without VAT will have `l10n_mx_edi_cfdi_to_public` to True by default.
The tour `test_mx_pos_invoice_previous_order` is failing undeterministically. The tour proceeds as follows:
- create an order without partner, and validate it
- later, go the list of paid orders, select the last one and invoice it
- the list of partners opens to allow setting one
- then, a dialog opens to set the `l10n_mx_edi_usage` and `l10n_mx_edi_cfdi_to_public`
Currently, we simply select the first partner in the list ("(AR) Exento" if l10n_ar is installed...). When selecting this partner, we trigger the compute which will set a value on `l10n_mx_edi_cfdi_to_public`. Then, we can input `l10n_mx_edi_usage` and `l10n_mx_edi_cfdi_to_public` in the dialog. But the values filled in that dialog are not always saved to the database before ending the tour.
This fix uses a new partner to no longer depends on demo data. In addition, we leave the default values in the dialog to make sure the test will not fail no matter if the dialog's values are saved or not in the database (in a proper subsequent fix, we should ensure that we always end the tour after the dialog's values are saved).
runbot build error 60671This update adjusts how the system logs certain asset-related issues. Instead of marking them as errors, the system now logs them as warnings, which better reflects that these are not actual problems with the codebase but rather expected situations that should be tracked differently. This helps reduce noise in error monitoring systems and provides clearer visibility into actual system problems.
Original PR description
Currently, log level error mesage occur when`ValueError` is catched by line [1]. This commit changes 'logger.error' to 'logger.warning' with filename to log message instead of error since this is not an actual error of the codebase. [1]-https://github.com/odoo/odoo/blob/3932c46f914c40be4b0629771d1981cdf289df26/addons/web/controllers/binary.py#L131 sentry-4657682601 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update refreshes the X/Twitter logo throughout the Odoo platform to reflect the new design. The change affects visual elements in the web interface, website builder, and mass mailing features, ensuring consistent branding across all user-facing components.
Original PR description
*: website, website_twitter This commit introduces an update to the Font Awesome library, specifically replacing the X/Twitter icon with its new design. It also involves adjustments to a few images and SVG files to incorporate the updated X/Twitter logo. Technical note: It updates an existing file, originally modified for the addition of the TikTok icon, which was not available in Font Awesome 4. Related to: https://github.com/odoo/enterprise/pull/53644 task-3463530 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#158454 Forward-Port-Of: odoo/odoo#148126
This update removes unnecessary warning alerts that appeared when viewing posted invoices or bills with archived currencies. The alert will now only display for draft documents, preventing confusion when reviewing finalized transactions that cannot be edited.
Original PR description
Steps to reproduce: * Activate multi-currency (Company currency `USD`, another currency activated 'EUR') * Create invoice/bill in `EUR` and post it * Archive `EUR` * Open Invoice/Bill Issue: * Alert for inactivated currency is always displayed Fix: * Alert for inactivated currency should be displayed in draft state only Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: -- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#158639 Forward-Port-Of: odoo/odoo#98341