Odoo Changelog — 2024-03-29

Friday, March 29, 2024

3 changes · saas-17.2

Bug Fixes(3)

Resolved issues and error corrections

[FIX] website_sale_loyalty: ewallet application fix

Coresaas-17.2website_sale_loyaltyMedium

This fixes issues that prevented customers from applying eWallet credit during online checkout. It also ensures loyalty rewards meant for future orders are clearly shown, reducing checkout confusion and missed promotional benefits.

Original PR description

Due to https://github.com/odoo/odoo/commit/994ee3f514d55c5c01975d3c0d77663eb173e775 commit, ewallet could no
longer be applied.

#ewallet#loyalty#checkout#ecommerce

[FIX] web: fix multiple run of server action

PR #159413

Coresaas-17.2webMedium

Odoo now runs server actions once when loading them and directly returns the resulting screen. This prevents duplicate executions when users navigate back through breadcrumbs, reducing unexpected repeated actions and improving navigation labels.

Original PR description

Before this commit, when an action is loaded, the server is called to find all the information of the action, if the action is a server action kind, a new call to the server is executed to run the…

Before this commit, when an action is loaded, the server is called to
find all the information of the action, if the action is a server action
kind, a new call to the server is executed to run the server action, the
result of this running is a new action (close action or window action).

Since [1], when a server action is found in the url, it will be executed
to retrieve the window action when is the current action.

If the server action is found in multiple places in the url, it will be
executed each time it becomes the current action.

For instance, /crm/12, will execute the server action crm to retrieve
the window action at the first load, and the same server action will be
executed again when clicking on the breadcrumb to go back to the
multi-record view.

Now, when an action is loaded, if the action is a server action, the
server will execute the action directly and return the resulting action.

This is to avoid a back and forward between the client side and the
server side.

Note that, this will also use the correct display name on the breadcrumb, the
one of the window action.

[1] https://github.com/odoo/odoo/commit/c63d14a0485a553b74a8457aee158384e9ae6d3f

[FIX] purchase: fix broken catalog on non-empty POs

PR #159668

Coresaas-17.2purchaseMedium

This fixes an error that prevented buyers from opening the product catalog after products had already been added to a purchase request. Users can now continue adding products from the catalog without disruption, improving the purchasing workflow.

Original PR description

Steps to reproduce:
- Open purchase app.
- Create an RFQ and add any product(s) to it.
- Click on "Catalog" button in products tab to add products from the catalog.

=> Expected behavior: Catalog opens with a list of products to choose
   from.
=> Current behavior: An error is triggered: `TypeError:
   PurchaseOrderLine._get_product_catalog_lines_data() got an
   unexpected keyword argument 'parent_record'`

This is because `_get_product_catalog_lines_data` in `purhcase.order.line` model is the only override of this function that does not accept keyword arguments. So when
`_get_product_catalog_order_line_info` in `product.catalog.mixin` calls this function with any keyword argument, this error is triggered.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#purchase#catalog#rfq#buyer workflow

Before this commit, when an action is loaded, the server is called to find all the information of the action, if the action is a server action kind, a new call to the server is executed to run the server action, the result of this running is a new action (close action or window action). Since [1], when a server action is found in the url, it will be executed to retrieve the window action when is the current action. If the server action is found in multiple places in the url, it will be executed each time it becomes the current action. For instance, /crm/12, will execute the server action crm to retrieve the window action at the first load, and the same server action will be executed again when clicking on the breadcrumb to go back to the multi-record view. Now, when an action is loaded, if the action is a server action, the server will execute the action directly and return the resulting action. This is to avoid a back and forward between the client side and the server side. Note that, this will also use the correct display name on the breadcrumb, the one of the window action. [1] https://github.com/odoo/odoo/commit/c63d14a0485a553b74a8457aee158384e9ae6d3f

Steps to reproduce: - Open purchase app. - Create an RFQ and add any product(s) to it. - Click on "Catalog" button in products tab to add products from the catalog. => Expected behavior: Catalog opens with a list of products to choose from. => Current behavior: An error is triggered: `TypeError: PurchaseOrderLine._get_product_catalog_lines_data() got an unexpected keyword argument 'parent_record'` This is because `_get_product_catalog_lines_data` in `purhcase.order.line` model is the only override of this function that does not accept keyword arguments. So when `_get_product_catalog_order_line_info` in `product.catalog.mixin` calls this function with any keyword argument, this error is triggered. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr