Odoo Changelog — 2024-03-29

Friday, March 29, 2024

8 changes · saas-17.2

Bug Fixes(8)

Resolved issues and error corrections

[FIX] website: correct typo in Livechat setting description

Coresaas-17.2website

A spelling mistake in the Website Livechat settings description was corrected from “Alow” to “Allow.” This improves clarity and professionalism in the settings interface without changing any functionality.

Original PR description

Description:
Small typo in the Livechat setting description.

Desired behavior after PR is merged:
Change 'Alow' to 'Allow' in description.

opw-3817716

#livechat#settings#typo

[FIX] website_sale_loyalty: ewallet application fix

PR #159356

Coresaas-17.2website_sale_loyaltyMEDIUM

This fixes issues that prevented customers from applying eWallet credit during online checkout. It also ensures loyalty rewards meant for future orders are clearly shown, reducing checkout confusion and missed promotional benefits.

Original PR description

Due to https://github.com/odoo/odoo/commit/994ee3f514d55c5c01975d3c0d77663eb173e775 commit, ewallet could no
longer be applied.

#ewallet#loyalty#checkout#ecommerce

[FIX] mail: failing race condition tests

PR #159684

Coresaas-17.2im_livechat

This fixes an issue where automated live chat sidebar tests could fail unpredictably because a channel member timestamp was missing. The change improves test reliability and helps prevent false failures during development without affecting end users.

Original PR description

missing last_interest_dt of channel member can
lead to unwanted unpinned channel in test due to
race condition.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#livechat#tests#reliability

[FIX] web: fix multiple run of server action

PR #159413

Coresaas-17.2webMEDIUM

Odoo now runs server actions once when loading them and directly returns the resulting screen. This prevents duplicate executions when users navigate back through breadcrumbs, reducing unexpected repeated actions and improving navigation labels.

Original PR description

Before this commit, when an action is loaded, the server is called to find all the information of the action, if the action is a server action kind, a new call to the server is executed to run the…

Before this commit, when an action is loaded, the server is called to
find all the information of the action, if the action is a server action
kind, a new call to the server is executed to run the server action, the
result of this running is a new action (close action or window action).

Since [1], when a server action is found in the url, it will be executed
to retrieve the window action when is the current action.

If the server action is found in multiple places in the url, it will be
executed each time it becomes the current action.

For instance, /crm/12, will execute the server action crm to retrieve
the window action at the first load, and the same server action will be
executed again when clicking on the breadcrumb to go back to the
multi-record view.

Now, when an action is loaded, if the action is a server action, the
server will execute the action directly and return the resulting action.

This is to avoid a back and forward between the client side and the
server side.

Note that, this will also use the correct display name on the breadcrumb, the
one of the window action.

[1] https://github.com/odoo/odoo/commit/c63d14a0485a553b74a8457aee158384e9ae6d3f

#server actions#navigation#breadcrumbs

[FIX] purchase: fix broken catalog on non-empty POs

PR #159668

Coresaas-17.2purchaseMEDIUM

This fixes an error that prevented buyers from opening the product catalog after products had already been added to a purchase request. Users can now continue adding products from the catalog without disruption, improving the purchasing workflow.

Original PR description

Steps to reproduce:
- Open purchase app.
- Create an RFQ and add any product(s) to it.
- Click on "Catalog" button in products tab to add products from the catalog.

=> Expected behavior: Catalog opens with a list of products to choose
   from.
=> Current behavior: An error is triggered: `TypeError:
   PurchaseOrderLine._get_product_catalog_lines_data() got an
   unexpected keyword argument 'parent_record'`

This is because `_get_product_catalog_lines_data` in `purhcase.order.line` model is the only override of this function that does not accept keyword arguments. So when
`_get_product_catalog_order_line_info` in `product.catalog.mixin` calls this function with any keyword argument, this error is triggered.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#purchase#catalog#rfq#buyer workflow

[FIX] account(_tax_python): Some fixes

PR #159723

Coresaas-17.2accountaccount_tax_python

This update fixes a small accounting issue caused by an extra comma and improves how tax-related Python rules are processed. The changes reduce the chance of minor accounting configuration problems and make repeated tax rule checks more efficient.

Original PR description

[FIX] account: Fix trailing comma

[IMP] account_tax_python: Compile the regex

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#accounting#taxes#performance#cleanup

[FIX] web: tests: fix issues in mock_model and mock_server

PR #159348

Coresaas-17.2web

This fix makes Odoo's web test tools handle simulated data and server calls more accurately. It helps prevent test failures caused by incorrect mock behavior, improving confidence in future web changes without affecting end users directly.

Original PR description

This commit fixes two issues.

The first one was in the mocked Model, in _unityReadRecords. When reading reference fields, we must read a related record, whose model and id are encoding in the value of the reference fields. Before this commit, we read the record on the wrong model (the main one, not the one of the reference field).

The second issue was in the MockServer. Commit [1] recently introduced the function stepAllNetworkCalls to call expect.step() for each server method/route called during the test. However, this didn't work properly for the route /web/dataset/call_kw/<path>. First because of a small mistake ("===" instead of "startswith" to match the route). Second because we didn't call the regular mock function for those routes, leading to crashes as the server always returned undefined.

[1] e721f1c7ce923b8f74abc3fef57ee5e9dd4c43ed

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#tests#mock-server#quality

[FIX] mail: failing race condition tests

PR #159620

Coresaas-17.2im_livechatmail

This fixes unstable automated tests around mail and live chat sidebar behavior caused by timing issues. The change helps prevent false test failures, improving confidence in future updates without changing user-facing functionality.

Original PR description

missing last_interest_dt of channel member can
lead to unwanted unpinned channel in test due to
race condition.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#tests#mail#livechat#reliability

missing last_interest_dt of channel member can lead to unwanted unpinned channel in test due to race condition. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Before this commit, when an action is loaded, the server is called to find all the information of the action, if the action is a server action kind, a new call to the server is executed to run the server action, the result of this running is a new action (close action or window action). Since [1], when a server action is found in the url, it will be executed to retrieve the window action when is the current action. If the server action is found in multiple places in the url, it will be executed each time it becomes the current action. For instance, /crm/12, will execute the server action crm to retrieve the window action at the first load, and the same server action will be executed again when clicking on the breadcrumb to go back to the multi-record view. Now, when an action is loaded, if the action is a server action, the server will execute the action directly and return the resulting action. This is to avoid a back and forward between the client side and the server side. Note that, this will also use the correct display name on the breadcrumb, the one of the window action. [1] https://github.com/odoo/odoo/commit/c63d14a0485a553b74a8457aee158384e9ae6d3f

Steps to reproduce: - Open purchase app. - Create an RFQ and add any product(s) to it. - Click on "Catalog" button in products tab to add products from the catalog. => Expected behavior: Catalog opens with a list of products to choose from. => Current behavior: An error is triggered: `TypeError: PurchaseOrderLine._get_product_catalog_lines_data() got an unexpected keyword argument 'parent_record'` This is because `_get_product_catalog_lines_data` in `purhcase.order.line` model is the only override of this function that does not accept keyword arguments. So when `_get_product_catalog_order_line_info` in `product.catalog.mixin` calls this function with any keyword argument, this error is triggered. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

This commit fixes two issues. The first one was in the mocked Model, in _unityReadRecords. When reading reference fields, we must read a related record, whose model and id are encoding in the value of the reference fields. Before this commit, we read the record on the wrong model (the main one, not the one of the reference field). The second issue was in the MockServer. Commit [1] recently introduced the function stepAllNetworkCalls to call expect.step() for each server method/route called during the test. However, this didn't work properly for the route /web/dataset/call_kw/<path>. First because of a small mistake ("===" instead of "startswith" to match the route). Second because we didn't call the regular mock function for those routes, leading to crashes as the server always returned undefined. [1] e721f1c7ce923b8f74abc3fef57ee5e9dd4c43ed Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr