Daily updates from Odoo
Friday, March 29, 2024
18 changes
5 changes
Resolved issues and error corrections
A spelling mistake in the Website Livechat settings description was corrected from “Alow” to “Allow.” This improves clarity and professionalism in the settings interface without changing any functionality.
Original PR description
Description: Small typo in the Livechat setting description. Desired behavior after PR is merged: Change 'Alow' to 'Allow' in description. opw-3817716
This fixes an issue where automated live chat sidebar tests could fail unpredictably because a channel member timestamp was missing. The change improves test reliability and helps prevent false failures during development without affecting end users.
Original PR description
missing last_interest_dt of channel member can lead to unwanted unpinned channel in test due to race condition. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes a small accounting issue caused by an extra comma and improves how tax-related Python rules are processed. The changes reduce the chance of minor accounting configuration problems and make repeated tax rule checks more efficient.
Original PR description
[FIX] account: Fix trailing comma [IMP] account_tax_python: Compile the regex --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix makes Odoo's web test tools handle simulated data and server calls more accurately. It helps prevent test failures caused by incorrect mock behavior, improving confidence in future web changes without affecting end users directly.
Original PR description
This commit fixes two issues. The first one was in the mocked Model, in _unityReadRecords. When reading reference fields, we must read a related record, whose model and id are encoding in the value…
This commit fixes two issues.
The first one was in the mocked Model, in _unityReadRecords. When reading reference fields, we must read a related record, whose model and id are encoding in the value of the reference fields. Before this commit, we read the record on the wrong model (the main one, not the one of the reference field).
The second issue was in the MockServer. Commit [1] recently introduced the function stepAllNetworkCalls to call expect.step() for each server method/route called during the test. However, this didn't work properly for the route /web/dataset/call_kw/<path>. First because of a small mistake ("===" instead of "startswith" to match the route). Second because we didn't call the regular mock function for those routes, leading to crashes as the server always returned undefined.
[1] e721f1c7ce923b8f74abc3fef57ee5e9dd4c43ed
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis fixes unstable automated tests around mail and live chat sidebar behavior caused by timing issues. The change helps prevent false test failures, improving confidence in future updates without changing user-facing functionality.
Original PR description
missing last_interest_dt of channel member can lead to unwanted unpinned channel in test due to race condition. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
4 changes
Resolved issues and error corrections
The Swiss payroll setup now points to the correct employee view after a duplicate payroll section was removed. This prevents related payroll information from being placed incorrectly and helps keep employee payroll screens consistent.
Original PR description
Before this commit, and the commit introduced in odoo/odoo#158508, two group named "payroll_group" were present on the employee view. The group introduced in hr has been removed and the one in payroll kept. This commit changes the xml_id used as inheritance in l10n_ch_hr_payroll to inherit the view defined in payroll rather than the view from hr_contract to allow inserting some content after the group mentionned above.
The field service task signing pop-up now appears above the page header as intended. This prevents confusion for workers signing worksheets from the customer portal and removes a visual overlay gap at the top of the page.
Original PR description
Steps: Install industry_fsm, worksheet and website. Create a task, set Joel Willis as assignee and add a worksheet. Log in as Joel Willis, got to that task and click sign. Issue: Z-wise, the modal isn't above the header. Cause: The modal is at the same level as the sign button, that is in the sidebar, which has `position: sticky;`. This fixes the `z-index` to the default value (even setting it manually has no impact). The fact that the modal's z-index is greater than the header's doesn't matter, as its container limits it. Solution: Put the modal div in the main content, which will never be sticky. Also, `mt-5 pt-5` were creating a "non grayed" stripe in the upper part of the page (where the header is at), so we delete it. task-3644729
Website form submissions to existing helpdesk tickets no longer add confusing HTML tags or irrelevant text in the ticket chatter. This keeps ticket history clearer for support teams reviewing customer requests.
Original PR description
**Steps:** - Open website and go to contact us - Using web editor option click on existing form and change its action - In create task action > select an existing ticket - Fill and submit the form - Open Ticket and go to the ticket given in create task action - Open the ticket created from the website - Have a glance at the chatter **Issue:** - Chatter is showing irrelevant information. (namely html tags) **Cause:** - Regrettably, due to last-minute changes preceding the merge, the review process for PR(https://github.com/odoo/enterprise/pull/47278) was unintentionally skipped. As a result, certain modifications were pushed that do not align with the expected standards. **Fix:** - Taking corrective action by adding proper if condition and assigning values correctly which will resolve this issue promptly. **Task**-3674768
This fix prevents a system error in Mexican electronic invoicing for Point of Sale orders by checking whether invoice information is available before using it. It helps keep automated validation and related POS invoicing flows stable without changing user-facing behavior.
Original PR description
### Commit 1: Fix the runbot issue number 60914 by verifying that the field to_invoice exists in the pos.order dict before trying to access it. Runbot error ID: 60914
9 changes
Resolved issues and error corrections
Fixed a confusing error message that appeared when users added companies to a worksheet template that previously had no companies assigned. The error message now clearly explains the issue instead of displaying blank company names, making it easier for users to understand what went wrong and how to fix it.
Original PR description
This commit's purpose is to improve the error message when a user is adding new company to a template that had none set before. Steps to reproduce: - open fsm app - open configuration menu, worksheet template - select the 'Device installation and maintenance' worksheet (it is the one with tasks linked to it) - add a new company 'my company (chicago)' and save. A validation error message pops up. That is fine and the expected behavior, since the new companies of the template are not consistent with the task already linked to it. Source: the generic message is using the old values of the companies of the worksheet, but since there were none, no names are displayed and the error message is confusing. Solution: check if the worksheet used to have companies set before the user changes. If not, display a relevant error message task - 3749225
This fix corrects test validation values for eco voucher calculations in the Belgian payroll module. The expected test values were not updated in a previous change that excluded parental time off from eco voucher eligibility. This ensures payroll tests run correctly without demo data.
Original PR description
Expect value for test without demo data wasn't changed in this PR :odoo/enterprise#50794 Fixed with this commit. task: 3837296
This update fixes appointment scheduling tests that were failing when demo data wasn't available. The system now properly handles timezone settings and removes dependencies on specific demo user accounts, making tests more reliable and independent of sample data.
Original PR description
* With no demo data, the current user does not have a timezone set. As the default value of appointment_tz is based on that, it leads to an error. We now set manually the appointment_tz for the appointment type created. * Remove the use of demo data (Mitchell Admin and Joe Willis) for test tour.
This fix ensures that product tracking is properly enabled in barcode scanning tests, preventing test failures when demo data is not available. The change ensures that test lines are correctly grouped during barcode operations, maintaining test reliability across different environments.
Original PR description
The product tracking is enabled by default in the demo data. Running the test without those data will break, as the 2 lines in the tour won't be grouped. runbot 54158 Forward-Port-Of: odoo/enterprise#59647
A test in the Planning module was failing due to daylight saving time changes. This fix ensures the test consistently uses UTC timezone throughout, eliminating failures caused by seasonal time changes. This makes the test more reliable and easier to maintain.
Original PR description
Before this commit, the test fails since 23 March 2024 because next week the hours changed (summer time). The problem is there if the timezone is not UTC. This commit ensures the whole test uses the same timezone and only UTC one to avoid having to manage summer/winter time in the test. runbot-60932 Forward-Port-Of: odoo/enterprise#59366
This update adds a missing Spanish translation for a term used in Chilean invoices. The translation was previously unavailable, which could have caused display issues for Spanish-speaking users in the Latin American region. This fix ensures all invoice text displays correctly in the appropriate language.
Original PR description
Issue ----- A term doesn't have a translation available. Note: no Transifex project associated. **opw-3816657** Forward-Port-Of: odoo/odoo#159147
This fix improves the user experience when someone accidentally tries to upload a folder instead of a file using the /file command in Knowledge. Previously, the upload would fail silently with no error message. Now users will see a clear error notification explaining that only files can be uploaded, not folders.
Original PR description
**Steps to reproduce:** **OS:** Ubuntu 20.04.4 LTS with nautilus **Browser:** Google Chrome Version 123.0.6312.58 - type /file command in knowledge - select a folder and click on open - traceback occurs **Current behavior before PR:** When a user attempts to upload a folder using /file command, the processing begins, but the folder is not uploaded because the `getDataURLFromFile` return promise is not fulfilled. Additionally, there is no indication of any warnings or errors during the folder upload process. **Desired behavior after PR is merged:** If a user attempts to upload a folder instead of a file using the /file command, it results in an error message in the toaster notification. task-3690847 Forward-Port-Of: odoo/odoo#151755
This update corrects inaccurate information in the Stripe payment module's documentation. The README contained an incorrect description of the payment flow process, which has been fixed to accurately reflect how Stripe payments are processed in Odoo. This ensures users and administrators have reliable documentation when setting up and managing Stripe payments.
Original PR description
Forward-Port-Of: odoo/odoo#159621
This update fixes a test failure in the inventory system's test suite that was causing errors when running the unpacking and quantity history test. The fix ensures the test runs reliably without encountering index errors, improving the stability of the inventory testing process.
Original PR description
Test 'test_unpack_and_quants_history' may fail with error
```
ERROR: StockQuant.test_unpack_and_quants_history
Traceback (most recent call last):
File "/data/build/odoo/addons/stock/tests/test_quant.py", line 926, in test_unpack_and_quants_history
dst_location = stock_location.child_ids[0]
File "/data/build/odoo/odoo/models.py", line 6189, in __getitem__
return self.browse((self._ids[key],))
IndexError: tuple index out of range
```
Forward-Port-Of: odoo/odoo#159611