Tuesday, April 2, 2024
3 changes · saas-17.1
Resolved issues and error corrections
Posting a vendor bill with possible duplicates now takes users to the duplicate bills list without an error. This prevents a confusing crash and helps accounting teams review duplicate warnings smoothly.
Original PR description
When we want to post a vendor bill having duplicates, we show a `RedirectError` that should bring us to the list of duplicate bills. However, the action domain contained records instead of record ids, causing a traceback when clicking the button. The issue was introduced in 64a7a80bd8a87e984b73504113b1c31926557c05. This commit fixes that by providing a valid domain for the moves. task-3797825
New employee contracts now use the job and department selected in the salary offer before falling back to the contract template. This keeps the generated contract aligned with the signed offer and avoids incorrect employee details.
Original PR description
Since when we generate an offer, we can provide a specific job and department, that will be set on the user and used in the pdf contract signed. We should also get this job and departement correctly set on the new contract which is not the case for now. So we first choose to use the info comming from the offer before the one from the contract template.
This update resolves an issue where users couldn't modify or remove products from the catalog view when multiple line items were added. The fix adds a necessary condition to allow updates and removals, ensuring a smoother user experience when managing multiple items within the catalog.
Original PR description
**Before this PR:** When more than 1 line item is added, users are unable to update or remove products from the catalog view. **Technical Reason:** There is a function _is_readonly() that returns True if there are multiple line items, and because of this, the value of props.readOnly becomes True which prevents users from updating the products in catalog view. **Solution:** Adding one more condition in account_move_line to satisfy the desired behavior. **After this PR:** The users can update or remove the products from the catalog view if there are multiple line items. **Task**-3806509