Wednesday, April 3, 2024
16 changes · master
Enhancements to existing features
Creating a new appointment from the Gantt view now starts from the current time rounded to the nearest hour instead of defaulting to midnight. This makes new bookings faster and more relevant for users scheduling appointments during the day.
Original PR description
Purpose ========= Currently when we click on the new button on Gantt view the default start is set to today's midnight which is not relevant. After this PR ================== The current DateTime with rounded hour will be set as a default start while creating a new booking through the Gantt view. Task-3820387
This change adds automated checks to make sure sensitive employee fields keep the correct access restrictions across several HR-related apps. It helps reduce the risk of accidental exposure of private employee information as the system evolves.
Miscellaneous changes
Before this commit, the ticket field is displayed in the sublist view of timesheet when the user is in ticket form view with timesheets feature enabled. This commit hides the ticket field as it was the case base. issue found during the testing of task-2276015 Forward-Port-Of: odoo/enterprise#59891
Original PR description
Before this commit, the ticket field is displayed in the sublist view of timesheet when the user is in ticket form view with timesheets feature enabled. This commit hides the ticket field as it was the case base. issue found during the testing of task-2276015 Forward-Port-Of: odoo/enterprise#59891
During this commit: https://github.com/odoo/enterprise/pull/45792/commits/3a3d9c877f3e8bd2db9e66cd8120d889fd09f125 a xpath was refactored to add the closing attribute for the belgian tax report. Before this commit the xpath wasn't working but didn't cause a traceback. By adding the parenthesis, the last operator can get the last div of the pdf_export_filters template and put after it the different closing attribute. no task id Forward-Port-Of: odoo/enterprise#59453
Original PR description
During this commit: https://github.com/odoo/enterprise/pull/45792/commits/3a3d9c877f3e8bd2db9e66cd8120d889fd09f125 a xpath was refactored to add the closing attribute for the belgian tax report. Before this commit the xpath wasn't working but didn't cause a traceback. By adding the parenthesis, the last operator can get the last div of the pdf_export_filters template and put after it the different closing attribute. no task id Forward-Port-Of: odoo/enterprise#59453
Previously, splitting an order did not cancel the split order line in the preparation display. This commit ensures that the preparation display is updated correctly when an order is split. opw-3809693 Forward-Port-Of: odoo/enterprise#59655 Forward-Port-Of: odoo/enterprise#59554
Original PR description
Previously, splitting an order did not cancel the split order line in the preparation display. This commit ensures that the preparation display is updated correctly when an order is split. opw-3809693 Forward-Port-Of: odoo/enterprise#59655 Forward-Port-Of: odoo/enterprise#59554
Since when we generate an offer, we can provide a specific job and department, that will be set on the user and used in the pdf contract signed. We should also get this job and departement correctly set on the new contract which is not the case for now. So we first choose to use the info comming from the offer before the one from the contract template. Forward-Port-Of: odoo/enterprise#59662
Original PR description
Since when we generate an offer, we can provide a specific job and department, that will be set on the user and used in the pdf contract signed. We should also get this job and departement correctly set on the new contract which is not the case for now. So we first choose to use the info comming from the offer before the one from the contract template. Forward-Port-Of: odoo/enterprise#59662
# Description When opening the balance sheet in the cash basis method, the queries, generated by `_compute_formula_batch_with_engine_domain`, for the report can be slow. The issue is that they filter by date, which can be slower the more data the `temp_account_move_line` table contains. # Fix To speed up these queries, I added a composite index on the date and a few other fields. Since the index is added to a temporary table, it will be removed when the table is dropped. # Benchmark
Original PR description
# Description When opening the balance sheet in the cash basis method, the queries, generated by `_compute_formula_batch_with_engine_domain`, for the report can be slow. The issue is that they filter by date, which can be slower the more data the `temp_account_move_line` table contains. # Fix To speed up these queries, I added a composite index on the date and a few other fields. Since the index is added to a temporary table, it will be removed when the table is dropped. # Benchmark (in 17.0) | Cash Basis | Before | After | |------------|-------:|------:| | 1K | 250ms | 200ms | | 80K | 22s | 4s | | 180K | 30s | 4s | | 280K | 54s | 4s | (In this case, the 4 seconds come mainly from the SELECT for payment_table). # Reference opw-3782652 Forward-Port-Of: odoo/enterprise#59376 Forward-Port-Of: odoo/enterprise#59005
Account 1611 Crediti per ritenute subite (appoggio) which is created by the l10n_it_edi_withholding module was not referenced in the Balance Sheet. We fix this now. taskid: 3060790 Forward-Port-Of: odoo/enterprise#59148
Original PR description
Account 1611 Crediti per ritenute subite (appoggio) which is created by the l10n_it_edi_withholding module was not referenced in the Balance Sheet. We fix this now. taskid: 3060790 Forward-Port-Of: odoo/enterprise#59148
Open customer form view Issue : Name for the field 'l10n_mx_edi_operator_licence' is not visible This occurs because the xpath position the field after the vat which is inside a div made to show the Tax information opw-3819273 Forward-Port-Of: odoo/enterprise#59807
Original PR description
Open customer form view Issue : Name for the field 'l10n_mx_edi_operator_licence' is not visible This occurs because the xpath position the field after the vat which is inside a div made to show the Tax information opw-3819273 Forward-Port-Of: odoo/enterprise#59807
follow up to https://github.com/odoo/enterprise/pull/58895 Steps to reproduce: - Install ups_rest - Configure the new ups shipping method as admin - Create an SO and try to add ups delivery as demo - Access error Bug: if a new acces token is requested we need sudo accesn to update the carrier access token opw-3771840 Forward-Port-Of: odoo/enterprise#59811
Original PR description
follow up to https://github.com/odoo/enterprise/pull/58895 Steps to reproduce: - Install ups_rest - Configure the new ups shipping method as admin - Create an SO and try to add ups delivery as demo - Access error Bug: if a new acces token is requested we need sudo accesn to update the carrier access token opw-3771840 Forward-Port-Of: odoo/enterprise#59811
The computed stored field l10n_mx_edi_payment_method_id of account_move in l10n_mx_edi can lead to MemoryErrors during module installation in some large databases. To fix that, this commit first creates the field's column in _auto_init, avoiding the recomputations that overfill the field_cache and lead to MemoryErrors. Then, since inside the field's compute method the field should be set to a specific payment_method defined in the module's data files, change the post_init_hook to set the paym
Original PR description
The computed stored field l10n_mx_edi_payment_method_id of account_move in l10n_mx_edi can lead to MemoryErrors during module installation in some large databases. To fix that, this commit first creates the field's column in _auto_init, avoiding the recomputations that overfill the field_cache and lead to MemoryErrors. Then, since inside the field's compute method the field should be set to a specific payment_method defined in the module's data files, change the post_init_hook to set the payment_method to the correct id in the database after data files loading. I missed it in PR odoo/enterprise#30929 because this field was changed to a computed field starting v15. opw-3018535 Forward-Port-Of: odoo/enterprise#59069 Forward-Port-Of: odoo/enterprise#34974
When a task and a ticket share the same ID, the _search_user_timer_id method will not work and provide the wrong result when using User Timer as the filter. Steps to reproduce: Having a task and a ticket with the same ID. Start the timer in the task. Go to the ticket and filter by "User Timer is set" There will be a ticket without a timer running but still showing in the search result. Cause The search method did not take into consideration of model. Solution Add model as a condi
Original PR description
When a task and a ticket share the same ID, the _search_user_timer_id method will not work and provide the wrong result when using User Timer as the filter. Steps to reproduce: Having a task and a ticket with the same ID. Start the timer in the task. Go to the ticket and filter by "User Timer is set" There will be a ticket without a timer running but still showing in the search result. Cause The search method did not take into consideration of model. Solution Add model as a condition when searching timer records Forward-Port-Of: odoo/enterprise#59398
Chilean ecommerce checkout flow was consistently breaking when automatic invoice was enabled (Sale settings), for customers choosing the 'Ticket' option (not the 'Invoice' one). Indeed, choosing the 'Ticket' options sets a generic 'Anonymous' customer as billing address, but since this address is incomplete, the customer is redirected to the page to complete it, even though they don't have the rights to update that address since it's not theirs. This commit makes sure to consider this 'ano
Original PR description
Chilean ecommerce checkout flow was consistently breaking when automatic invoice was enabled (Sale settings), for customers choosing the 'Ticket' option (not the 'Invoice' one). Indeed, choosing the 'Ticket' options sets a generic 'Anonymous' customer as billing address, but since this address is incomplete, the customer is redirected to the page to complete it, even though they don't have the rights to update that address since it's not theirs. This commit makes sure to consider this 'anonymous' billing address as being always complete, even if some fields are empty. opw-3792844 Forward-Port-Of: odoo/enterprise#59351
The issue: Go to Accounting > Reporting > Journal Report, if you have a tax with a distribution invoice/refund line that has a zero percent line, this will cause a Division By Zero traceback The fix: Ignore the lines with the zero percent opw-3785700 Forward-Port-Of: odoo/enterprise#58444
Original PR description
The issue: Go to Accounting > Reporting > Journal Report, if you have a tax with a distribution invoice/refund line that has a zero percent line, this will cause a Division By Zero traceback The fix: Ignore the lines with the zero percent opw-3785700 Forward-Port-Of: odoo/enterprise#58444
…cess Because of Ponto that puts its consent expiration date in _get_accounts we need to move the _get_consent_expiring_date flow after the success call so that the expiration date is set correctly. task-id: 3619486 odoofin: https://github.com/odoo/odoofin/pull/236 Forward-Port-Of: odoo/enterprise#59683 Forward-Port-Of: odoo/enterprise#52319
Original PR description
…cess Because of Ponto that puts its consent expiration date in _get_accounts we need to move the _get_consent_expiring_date flow after the success call so that the expiration date is set correctly. task-id: 3619486 odoofin: https://github.com/odoo/odoofin/pull/236 Forward-Port-Of: odoo/enterprise#59683 Forward-Port-Of: odoo/enterprise#52319
**Coverage for community fix** https://github.com/odoo/odoo/pull/157515 opw-3754297 Forward-Port-Of: odoo/enterprise#59301 Forward-Port-Of: odoo/enterprise#58264
Original PR description
**Coverage for community fix** https://github.com/odoo/odoo/pull/157515 opw-3754297 Forward-Port-Of: odoo/enterprise#59301 Forward-Port-Of: odoo/enterprise#58264