Daily updates from Odoo
Thursday, April 4, 2024
9 changes · master
Resolved issues and error corrections
The Helpdesk ticket activity view now handles tickets without an assigned user more cleanly. This prevents a broken empty picture placeholder and gives users a smoother, more consistent ticket view.
Original PR description
issue: If you don't have a picture on the assign, display is broken Without the assign in the ticket, the empty image placeholder is not shown properly. I display the O2M widget rather than an empty image holder. A side effect of this commit- https://github.com/odoo/odoo/commit/13382398d2ebeb3df52fb67d9963c292372031d1 task-3706742
Code cleanup and technical improvements
The website editor's snippet menu has been reworked in the appointment and enterprise website areas to use Odoo's newer interface technology. This keeps the visible editing experience consistent while making the menu easier to maintain and evolve.
Original PR description
*: website_appointment, website_enterprise
As explained in the community commit:
This commit also takes advantage of the OWL rendering engine by moving most of the SnippetsMenu UI into a static frontend template (previously it was a backend view). The view is kept, to generate the list of snippets and still generate the options' HTML.
The structure of the list of snippets is now the following:
```
<snippets>
<category>
<title>Base Structure
<snippets>
<t t-snippet=""...../>
</snippets>
</category>
</snippets>
```
task-3323657
Community PR: https://github.com/odoo/odoo/pull/121295Miscellaneous changes
In `pos_enterprise` we alias `is_posbox` as `module_pos_iot`. If the value is True we install the module `pos_iot` when a write in pos.config model happens: https://github.com/odoo/odoo/blob/f7ee5633a8c80afca05074b8574e9c2a720e4bc9/addons/point_of_sale/models/pos_config.py#L496 Steps to reproduce: 1. Install PoS and IoT applications -- will install `pos_enterprise` module. 2. Set is_posbox = True, via the PoS settings. 3. Uninstall IoT application -- will uninstall `iot` and `pos_iot` mod
Original PR description
In `pos_enterprise` we alias `is_posbox` as `module_pos_iot`. If the value is True we install the module `pos_iot` when a write in pos.config model happens:…
In `pos_enterprise` we alias `is_posbox` as `module_pos_iot`. If the value is True we install the module `pos_iot` when a write in pos.config model happens:
https://github.com/odoo/odoo/blob/f7ee5633a8c80afca05074b8574e9c2a720e4bc9/addons/point_of_sale/models/pos_config.py#L496
Steps to reproduce:
1. Install PoS and IoT applications -- will install `pos_enterprise` module.
2. Set is_posbox = True, via the PoS settings.
3. Uninstall IoT application -- will uninstall `iot` and `pos_iot` modules.
4. Try to install a module that writes in a column of the pos_config with is_posbox=True
We get an error like:
```
...
File "/home/odoo/src/odoo/17.0/odoo/addons/base/models/ir_module.py", line 569, in _button_immediate_function
raise UserError(_('The method _button_immediate_install cannot be called on init or non loaded registries. Please use button_install instead.'))
odoo.exceptions.UserError: El método _button_immediate_install no puede ser llamado en registros init o no cargados. Por favor, utilice button_install en su luga
```
The issue is that when we uninstall `iot` module the flag is never reset. This then causes issues if we try to install a module that writes on any value of `pos.config`. Observed during upgrades, e.g `l10n_es_pos` at xml load of data files. Other modules also affected.
The solution we propose here is to introduce a _soft_ dependency between pos_iot -- which is an enterprise module -- and pos_enterprise. The former checks at uninstall if the latter is installed to clear the `is_posbox` flag.
Forward-Port-Of: odoo/enterprise#59810Current behavior: After this refactor https://github.com/odoo/odoo/pull/142566 the use_proxy became undefined. And so the pos is not able to connect to the proxy and use the printer connected to the IoT Box. Steps to reproduce: - Install the PoS IoT module - Configure the IoT Box with a printer - Select the printer from the IoT Box in the PoS configuration - Try to print a receipt - Nothing happens, it only try to print via the browser print popups Note: There was also an issue in t
Original PR description
Current behavior: After this refactor https://github.com/odoo/odoo/pull/142566 the use_proxy became undefined. And so the pos is not able to connect to the proxy and use the printer connected to the IoT Box. Steps to reproduce: - Install the PoS IoT module - Configure the IoT Box with a printer - Select the printer from the IoT Box in the PoS configuration - Try to print a receipt - Nothing happens, it only try to print via the browser print popups Note: There was also an issue in the StatusLoop that was not correctly getting the ids of the devices. This was fixed in the same commit. opw-3800437 Forward-Port-Of: odoo/enterprise#59570 Forward-Port-Of: odoo/enterprise#59433
**Step to reproduce:** - Install `Knowledge` and `Documents` modules (for test purpose) - Go to Documents app - Click on Action button -> Knowledge -> Insert view in article - Select any article **Issue:** View is not loaded correctly in the article. Error message: Something went wrong! The view does not exist or you are not allowed to access to it. **Cause:** In the imported view, we try to retrieve the selected Folders, but this last one need the search model
Original PR description
**Step to reproduce:** - Install `Knowledge` and `Documents` modules (for test purpose) - Go to Documents app - Click on Action button -> Knowledge -> Insert view in article - Select any article…
**Step to reproduce:**
- Install `Knowledge` and `Documents` modules (for test purpose)
- Go to Documents app
- Click on Action button -> Knowledge -> Insert view in article
- Select any article
**Issue:**
View is not loaded correctly in the article.
Error message: Something went wrong! The view does not exist or you
are not allowed to access to it.
**Cause:**
In the imported view, we try to retrieve the selected Folders, but this last one need the search model to retrieve the data.
https://github.com/odoo/enterprise/blob/11daa694d4ca51939c2b458bced8ab9d48030ef8/documents/static/src/views/documents_controller_mixin.xml#L5
The method called to retrieve the folders (`getSelectedFolder`) is set on the documents search model (`DocumentsSearchModel`), however, the search model set in the embedded_view is the knowledge search model (`KnowledgeSearchModel`).
**Solution:**
Change the `KnowledgeSearchModel` class into a mixin so it can extend the (potentially) custom search model defined for any embedded view during the mounting process (default to the generic search model), instead of overwriting it.
opw-3752927
Forward-Port-Of: odoo/enterprise#59758Issue - Edit Payslip Lines are reset to previous value Steps: go to -> payroll / all payslip create a payslip compute payslip action -> Edit Payslip Lines edit a line Issue: it is reset to previous value Forward-Port-Of: odoo/enterprise#59665
Original PR description
Issue - Edit Payslip Lines are reset to previous value Steps: go to -> payroll / all payslip create a payslip compute payslip action -> Edit Payslip Lines edit a line Issue: it is reset to previous value Forward-Port-Of: odoo/enterprise#59665
During this PR: https://github.com/odoo/enterprise/pull/51954 tests were not added directly. This PR will add test for the following: - Simple export with no moves - Simple export with moves - Non critical errors - Critical errors task-3794278 Forward-Port-Of: odoo/enterprise#59431
Original PR description
During this PR: https://github.com/odoo/enterprise/pull/51954 tests were not added directly. This PR will add test for the following: - Simple export with no moves - Simple export with moves - Non critical errors - Critical errors task-3794278 Forward-Port-Of: odoo/enterprise#59431
When installing module l10n_eu_oss, account 2205 Output VAT (Sales) OSS was not referenced in the Balance Sheet. taskid: 3060790 Forward-Port-Of: odoo/enterprise#59137
Original PR description
When installing module l10n_eu_oss, account 2205 Output VAT (Sales) OSS was not referenced in the Balance Sheet. taskid: 3060790 Forward-Port-Of: odoo/enterprise#59137
On the buttons bar of the account reports, the button was smaller than the dropdown item and so when clicking on the dropdown nothing happens. This Pr will move the actions on the dropdown. task-3826440 Forward-Port-Of: odoo/enterprise#59350
Original PR description
On the buttons bar of the account reports, the button was smaller than the dropdown item and so when clicking on the dropdown nothing happens. This Pr will move the actions on the dropdown. task-3826440 Forward-Port-Of: odoo/enterprise#59350