Monday, April 8, 2024
4 changes · 17.0
Resolved issues and error corrections
This update fixes a visual issue in the field service task report where a horizontal line was overlapping other content. The fix improves the report's appearance by adjusting the display layering, making the document cleaner and easier to read when signing off on completed tasks.
Original PR description
17.0 Steps to reproduce: - install field service - check worksheet option from setting in field service - complete worksheet of any task and click on sign report - click on sign button on portal Issue: - horizontal line is getting overlapped on Sing task report. Solution: - Add z-index property on horizontal line to have better ui. Task: 3770835
This update fixes code issues that were not previously detected by the older pylint version. The changes prepare the system for an upcoming pylint upgrade as part of the transition to ruff for code analysis. This ensures the codebase remains clean and maintainable as development tools are modernized.
Original PR description
We are planning to upgrade the pylint version since ruff is now fully deployed. This will fix some of the issue that where not detected with the previous version Note: self.transaction_ids could raise, this is why we have no garantee that existing_transactions will be defined. But the try except does not look to manage this case, this is why it should be safe to move this line outside the try. This will be merged in 17.2 with 60233 to allow a faster forward-port and adaptation of the docker image
This update removes unnecessary warning messages when users encounter missing pages (404 errors) in Odoo. The system now relies on color-coded status indicators in logs instead, which are easier to spot. This cleanup removes redundant code that was being skipped anyway due to how the error handling was structured.
Original PR description
The conditionnal `isinstance(exc, NotFound)` is shadowed by the conditionnal `isinstance(exc, HTTPException)` two lines above. Nobody ever complained that the warning for NotFound error was gone. Since werkzeug 1.0.0, the status code in the response log is colored, 404 is colored yellow which should catch the eye. The explicit warning line isn't really necessary. Forward-Port-Of: odoo/odoo#159665
This fix corrects how the HSN (Harmonized System of Nomenclature) field displays on sales orders when your company uses multiple localizations. Previously, the HSN field would appear regardless of which localization was active. Now it only shows when relevant to the current localization, matching the behavior of other reports like purchase orders and invoices.
Original PR description
Don't show HSN value for sale.order not linked to this localization. Before this commit, if you have multi company with multi localization, you see this field whatever the current localization. It uses the same condition than other report: purchase/invoice/... Forward-Port-Of: odoo/odoo#160766