Monday, April 8, 2024
4 changes · saas-17.1
Resolved issues and error corrections
This fix prevents task titles from being cleared when an assignee is added or removed in timesheet-enabled projects. It improves reliability while creating and managing project tasks in the kanban view.
Original PR description
### Steps to reproduce issue: 1. In settings, activate Timesheets and Project Stages 2. Create Project with Timesheets enabled 3. In the project, create a new task in the kanban view 4. Give the task…
### Steps to reproduce issue: 1. In settings, activate Timesheets and Project Stages 2. Create Project with Timesheets enabled 3. In the project, create a new task in the kanban view 4. Give the task a title 5. Choose an Asignee 6. The title disappeared ### Explanation: The title field, `display_name`, is a computed field that gets its value from `name`. This compute has dependencies coming from other computed values. One of them, `allocated_hours` has a dependency to user_ids, making the whole chain trigger when a user is added to or removed from the Assignees. https://github.com/odoo/enterprise/blob/c2dde10834b1ef31fe4564a49c90c461a348b392/project_enterprise/models/project_task.py#L83-L84 ### Suggested fix: `display_name` is used in very few situations, either in the kanban view or in a dropdown menu. Those two cases do not require reactiveness from the compute method. As a matter of fact, except for the current issue, `_compute_display_name` does not seem to be called by another field's onchange. Fix in Community, Test in Enterprise opw-3823040
This fix prevents task titles from disappearing when a user is assigned during quick task creation in project kanban views. It keeps task creation smoother for teams using Timesheets and Project Stages by avoiding unnecessary title recalculations.
Original PR description
### Steps to reproduce issue: 1. In settings, activate Timesheets and Project Stages 2. Create Project with Timesheets enabled 3. In the project, create a new task in the kanban view 4. Give the task…
### Steps to reproduce issue: 1. In settings, activate Timesheets and Project Stages 2. Create Project with Timesheets enabled 3. In the project, create a new task in the kanban view 4. Give the task a title 5. Choose an Asignee 6. The title disappeared ### Explanation: The title field, `display_name`, is a computed field that gets its value from `name`. This compute has dependencies coming from other computed values. One of them, `allocated_hours` has a dependency to user_ids, making the whole chain trigger when a user is added to or removed from the Assignees. https://github.com/odoo/enterprise/blob/c2dde10834b1ef31fe4564a49c90c461a348b392/project_enterprise/models/project_task.py#L83-L84 ### Suggested fix: `display_name` is used in very few situations, either in the kanban view or in a dropdown menu. Those two cases do not require reactiveness from the compute method. As a matter of fact, except for the current issue, `_compute_display_name` does not seem to be called by another field's onchange. Fix in Community, Test in Enterprise opw-3823040
Users with referral-only recruitment access can now view the applicant records needed in the Referral app without hitting an access error. This restores expected referral workflows for viewing ongoing and successful referrals while keeping broader recruitment permissions restricted.
Original PR description
### Steps to reproduce: - Change Marc Demo's Recruitment access rights of to "Referral only" - Login as Marc Demo - Open the Referral Module and click on Referrals, Ongoing or Successful #### >…
### Steps to reproduce: - Change Marc Demo's Recruitment access rights of to "Referral only" - Login as Marc Demo - Open the Referral Module and click on Referrals, Ongoing or Successful #### > "Access Error: you are note allowed to access applicant records" ### Cause of the issue: The access error will be raised for any user whose recruitment access rights are lower than "interviewer" and trying to access only "referral fields" of the hr.applicant model: https://github.com/odoo/enterprise/blob/be076a9203d1717d6e93b0be1e7b64b6909ae8c4/hr_referral/models/hr_applicant.py#L75-L79 Since referral fields represents IMO the fields that should be available to any type of users, the 2 conditions are contradictory. ### Note: In 17.0, users with an access rights lower than "interviewer" were able to access these records correctly because the condition to raise the error was that you tried to access a "non-referral field" and did not have enough access rights to do so: https://github.com/odoo/enterprise/blob/5d2bad19358d7df63b3298e26952ff200b758202/hr_referral/models/hr_applicant.py#L73 opw-3830443
UBL invoice files sent by email are now recognized even when they arrive as plain text rather than XML. This helps prevent document processing from missing valid electronic invoices and reduces manual follow-up.
Original PR description
Bug === When we send a UBL file by email, it is not detected as a UBL file. Technical ========= Since odoo/odoo@8214247 the XML files are imported as plain text. But the check for the UBL file check only the mimetype XML. Task-3792364