Tuesday, April 9, 2024
7 changes · 17.0
Resolved issues and error corrections
This change prevents users from saving product documents configured as web links for placement inside PDF quotes. It avoids a printing error when generating sales quote PDFs, helping sales teams produce quotes reliably.
Original PR description
Issue: Traceback error is raised when printing the PDF quote of a sales order with products that have documents that have `attached_on` = `inside` with `type` = `url` Purpose: This PR blocks the ability to create or change product documents that are `url` type with `attached_on` = `inside`. Steps to Reproduce on Runbot: 1) Install sale_pdf_quote_builder 2) Go to a product > documents > create a new document with type `url` and set visibility to `Inside quote` 3) Create Sale Order with product > Action > Print > PDF Quote 4) Traceback is raised. opw-3802795
This change ensures the WhatsApp delivery feature installs with the required delivery tracking component. It prevents setup errors in cases where that component was previously removed, making installation more reliable for users.
Original PR description
The module uses the field `stock_picking.carrier_tracking_url`, defined in module `stock_delivery`, which is not listed as dependency. Although it is auto-installed, if it gets uninstalled before `whatsapp_delivery` is installed, it will trigger an error as the field is missing. Steps to reproduce: - On a fresh 17.0 db, install `stock` and `delivery`. `stock_delivery` will be auto-installed. - Uninstall `stock_delivery`. - Install `whatsapp_delivery` or just `whatsapp`.
This update fixes the error dialog window to be wider, allowing error messages and tracebacks to display properly without being cut off. Users will now be able to see complete error information when issues occur in the system.
Original PR description
The dialog width for errors is to small to properly display the traceback. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update removes unnecessary technical attributes (t-key) from template files that don't require them. These attributes were previously added but aren't needed for templates that don't use the Owl framework, and removing them eliminates warning messages during system operation.
Original PR description
-Since [1] we have add t-key for some template, but some aren't necessary because they not load via Owl, therefore remove it to avoid warning : "Unknown directives or unused attributes" [1]: https://github.com/odoo/odoo/pull/130467/commits/a9b577dfcbd6c01abdc649a3ea61f80e9018832d#diff-0ba40f64ee7d28c08bdbb7273985adc0d2d2b63d8c3233aa2630e6ba4bde4df9 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes a visual issue where two scrollbars would appear when editing tables in notes. When users stretched table columns beyond the visible area and scrolled, an unnecessary second scrollbar would appear. The fix hides the overflow in the editor field and lets the main editable area handle scrolling, resulting in a cleaner, single scrollbar experience.
Original PR description
Issue: ===== double scrollbar appears in notes. Steps to reproduce the issue: ============================= - Go to notes - Insert a table - Add some columns and try to stretch the last one to the right until it goes outside the width of the editable. - Click on the last cell to the right in the table and scroll left - Another scrollbar will appear. Origin of the issue: ==================== The part of the table that is invisible in the editor is considered as overflow for the `html_field` so it will show a scrollbar which is not needed since we already have a scrollbar in the edtibale. Solution: ========= We mark hide the overflow in `html_field` and let the editable takes care of the overflow. task-3721794 Forward-Port-Of: odoo/odoo#160674 Forward-Port-Of: odoo/odoo#157675
This fix corrects an issue where the website menu editing tutorial incorrectly referenced the "Shop" menu item, which is only available when the website_sale module is installed. The tour now works properly with just the website app, making it more accessible to users who haven't installed the sales features.
Original PR description
The tour mentioned the "Shop" menu item since [1]. This is obviously a mistake: the tour should work when only the website app is installed. [1]: https://github.com/odoo/odoo/commit/a4b1c268131ed771dd68616a26a9f1ce50a189f0 runbot-60696
This update fixes code quality issues where variables were being used before being properly assigned in several modules. These issues were not caught by the previous version of the code checking tool, but are now being corrected to ensure the system runs more reliably and prevents potential runtime errors.
Original PR description
Fix various "Using variable xxx before assignment". It was not detected by pylint <= 2.5.0 which was the version enforced on runbot. ``` AssertionError: pylint test failed: ************* Module…
Fix various "Using variable xxx before assignment". It was not detected by pylint <= 2.5.0 which was the version enforced on runbot. ``` AssertionError: pylint test failed: ************* Module odoo.addons.base.tests.test_qweb Using variable 'error_msg' before assignment (E0601) at odoo/odoo/addons/base/tests/test_qweb.py:667 ************* Module odoo.tests.common Using variable 'message' before assignment (E0601) at odoo/odoo/tests/common.py:1137 ************* Module addons.fetchmail.models.fetchmail Using variable 'connection' before assignment (E0601) at odoo/addons/fetchmail/models/fetchmail.py:155 ************* Module addons.hw_escpos.controllers.main Using variable 'escpos' before assignment (E0601) at odoo/addons/hw_escpos/controllers/main.py:147 Using variable 'error' before assignment (E0601) at odoo/addons/hw_escpos/controllers/main.py:190 ************* Module addons.account.models.account_reconcile_model Using variable 'current_regex' before assignment (E0601) at odoo/addons/account/models/account_reconcile_model.py:35 ************* Module addons.point_of_sale.models.pos_session Using variable 'balance' before assignment (E0601) at odoo/addons/point_of_sale/models/pos_session.py:358 ``` Forward-Port-Of: odoo/odoo#161051 Forward-Port-Of: odoo/odoo#160886