Tuesday, April 9, 2024
11 changes
5 changes
Resolved issues and error corrections
This fix centralizes a key background communication method used by Odoo's web services. It helps messaging, live chat, and related interface actions run more consistently, reducing the risk of errors in day-to-day communication workflows.
This fix ensures test communication channels are closed after each test run. It helps prevent memory buildup and keeps the test environment stable over repeated runs.
Original PR description
Before this PR, broadcast channels opened during a test would never be closed. This can lead to memory leak. Moreover, subscriptions to the message event are not cleaned as well so subscriptions would keep growing test after test. This PR ensures the channels are properly closed at the end of each test.
This fix corrects how message notification IDs are tracked in testing and mail-related services, preventing older notifications from overriding newer unread message counts. It helps ensure more reliable behavior and test coverage for messaging features.
Original PR description
Follow up of https://github.com/odoo/odoo/pull/160700 Follow up of HOOT commits In hoot mock server, values are stored "per model", which means the counter is stored in bus model and not in `this`. This issue made impossible to detect the last value (always undefined) and basically "diff" notifications were never discarded, which was not covered by any test, but it is better to fix it for future tests. `lastBusNotificationId` should be incremented before and not after assigning the id, as the initial counter should be 0, and the first notif should be 1. This is what was done on the legacy mock server. This becomes an issue in this commit as fixing the read of the last value (first point of commit) means "diff" notif were always discarded. Forgot to check the bus id with `needaction_inbox_counter` in `mail.message/mark_as_read`. Old `mail.message/mark_as_read` notifications could therefore alter the result of a more recent init value.
This fix makes Odoo's web test environment better match the real system when loading actions. It helps prevent misleading test results by supporting action lookup by both internal ID and XML identifier, including server actions that run immediately.
Original PR description
Before this commit, the mocked route was only able to load actions from their id. The actual route also allows to load them from their xml_id. Moreover, since a recent commit [1], server actions are directly run. [1] odoo/odoo@c3bfdfb0ae51e083e46b3d084d5f86e7083fcdd6 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes an internal test timing issue in the Mail app so automated checks run more reliably. It helps prevent false test failures and supports smoother delivery of future mail-related updates, with no direct change for end users.
Original PR description
HOOT currently does not isolate tests, and the promise used in `loadEmoji` is never discarded, leading to the RPC potentially being called after the end of the test. Waiting for the message to be present ensures the RPC is done within the correct test. runbot-60638 runbot-60673 runbot-61164 runbot-61261
1 change
Resolved issues and error corrections
This update fixes an issue where some payroll, planning, timesheet forecasting, and sales calculations could handle empty filter conditions incorrectly. It helps prevent incorrect results or unexpected behavior in affected business workflows.
Original PR description
Companion of https://github.com/odoo/odoo/pull/160979.
5 changes
Resolved issues and error corrections
This update fixes the error dialog window to be wider, allowing error messages and tracebacks to display properly without being cut off. Users will now be able to see complete error information when issues occur in the system.
Original PR description
The dialog width for errors is to small to properly display the traceback. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update removes unnecessary technical attributes (t-key) from template files that don't require them. These attributes were previously added but aren't needed for templates that don't use the Owl framework, and removing them eliminates warning messages during system operation.
Original PR description
-Since [1] we have add t-key for some template, but some aren't necessary because they not load via Owl, therefore remove it to avoid warning : "Unknown directives or unused attributes" [1]: https://github.com/odoo/odoo/pull/130467/commits/a9b577dfcbd6c01abdc649a3ea61f80e9018832d#diff-0ba40f64ee7d28c08bdbb7273985adc0d2d2b63d8c3233aa2630e6ba4bde4df9 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes a visual issue where two scrollbars would appear when editing tables in notes. When users stretched table columns beyond the visible area and scrolled, an unnecessary second scrollbar would appear. The fix hides the overflow in the editor field and lets the main editable area handle scrolling, resulting in a cleaner, single scrollbar experience.
Original PR description
Issue: ===== double scrollbar appears in notes. Steps to reproduce the issue: ============================= - Go to notes - Insert a table - Add some columns and try to stretch the last one to the right until it goes outside the width of the editable. - Click on the last cell to the right in the table and scroll left - Another scrollbar will appear. Origin of the issue: ==================== The part of the table that is invisible in the editor is considered as overflow for the `html_field` so it will show a scrollbar which is not needed since we already have a scrollbar in the edtibale. Solution: ========= We mark hide the overflow in `html_field` and let the editable takes care of the overflow. task-3721794 Forward-Port-Of: odoo/odoo#160674 Forward-Port-Of: odoo/odoo#157675
This fix corrects an issue where the website menu editing tutorial incorrectly referenced the "Shop" menu item, which is only available when the website_sale module is installed. The tour now works properly with just the website app, making it more accessible to users who haven't installed the sales features.
Original PR description
The tour mentioned the "Shop" menu item since [1]. This is obviously a mistake: the tour should work when only the website app is installed. [1]: https://github.com/odoo/odoo/commit/a4b1c268131ed771dd68616a26a9f1ce50a189f0 runbot-60696
This update fixes code quality issues where variables were being used before being properly assigned in several modules. These issues were not caught by the previous version of the code checking tool, but are now being corrected to ensure the system runs more reliably and prevents potential runtime errors.
Original PR description
Fix various "Using variable xxx before assignment". It was not detected by pylint <= 2.5.0 which was the version enforced on runbot. ``` AssertionError: pylint test failed: ************* Module…
Fix various "Using variable xxx before assignment". It was not detected by pylint <= 2.5.0 which was the version enforced on runbot. ``` AssertionError: pylint test failed: ************* Module odoo.addons.base.tests.test_qweb Using variable 'error_msg' before assignment (E0601) at odoo/odoo/addons/base/tests/test_qweb.py:667 ************* Module odoo.tests.common Using variable 'message' before assignment (E0601) at odoo/odoo/tests/common.py:1137 ************* Module addons.fetchmail.models.fetchmail Using variable 'connection' before assignment (E0601) at odoo/addons/fetchmail/models/fetchmail.py:155 ************* Module addons.hw_escpos.controllers.main Using variable 'escpos' before assignment (E0601) at odoo/addons/hw_escpos/controllers/main.py:147 Using variable 'error' before assignment (E0601) at odoo/addons/hw_escpos/controllers/main.py:190 ************* Module addons.account.models.account_reconcile_model Using variable 'current_regex' before assignment (E0601) at odoo/addons/account/models/account_reconcile_model.py:35 ************* Module addons.point_of_sale.models.pos_session Using variable 'balance' before assignment (E0601) at odoo/addons/point_of_sale/models/pos_session.py:358 ``` Forward-Port-Of: odoo/odoo#161051 Forward-Port-Of: odoo/odoo#160886