Wednesday, April 10, 2024
2 changes · 17.0
Resolved issues and error corrections
This fix resolves a critical issue where clicking on product description fields in edit mode caused the page to freeze due to an infinite loop. The problem occurred when editing empty content areas, and this update prevents the system from repeatedly re-selecting these areas, allowing users to edit product pages without interruption.
Original PR description
Steps to reproduce the bug: - Install e-commerce. - Open a product page in edit mode. - Click on the "product.description_ecommerce" field. - Bug: an infinite loop starts. The "selectionchange" event is triggered in an endless loop, causing various issues such as the page freezing after a while. This issue was introduced by this commit [1]. Since this other commit [2], when a selection itself is the main container of the editable area, we replace this selection to only include the content of it. With commit [1], this has been modified to take into account "oe_structure" and "[contenteditable]" elements. As these elements can be empty, clicking on them would reselect them, creating an endless loop since we'd never leave the condition that replaces the selection. [1]: https://github.com/odoo/odoo/commit/e93fa23c29421ffe8917d9650330585d6dad210f [2]: https://github.com/odoo/odoo/commit/10c5a16cd44b8d8e54082df90166f2309dfa788d task-3830033
This update fixes a critical issue that prevented users from upgrading their system after a previous change. The fix reverts a technical modification in the website sales module to restore normal upgrade functionality. This ensures customers can successfully update their Odoo system without encountering errors.
Original PR description
After odoo/odoo#154035 users were unable to upgrade resolves https://github.com/odoo/odoo/issues/160816 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr