Odoo Changelog — 2024-04-12

Friday, April 12, 2024

5 changes · saas-17.2

Bug Fixes(5)

Resolved issues and error corrections

[FIX] web: lang on the url should stay after reload

Coresaas-17.2web

The web interface now keeps a language selected through the page URL after the browser is reloaded. This prevents users from unexpectedly returning to their default language when they refresh or continue navigating.

Original PR description

Since [1], it's possible to override the language of the user by adding the language to the query string : `lang=en_US`.
Since [2], all the key, values pairs that were on the fragment of the url, are now on the query string, and they are manipulated by the router. The information that was previously on the query string, are marked as a lockedKeys to avoid losing them when reloading the page or when a new state is push (as for example the debug key).  Unfortunately, lang was forgotten in this list, which lead to a lost of the override language when we reload the browser.

[1] : https://github.com/odoo/odoo/commit/286cc97dd45a218ce763f9f15bc34f3226e13296
[2] : https://github.com/odoo/odoo/commit/c63d14a0485a553b74a8457aee158384e9ae6d3f

#language#url#reload#user experience

[FIX] stock: batch ir.property insert for new companies

PR #161675

Coresaas-17.2stock

Creating a new company is now faster in databases with many companies because related stock location settings are saved in batches. This reduces setup delays while preserving the same vendor and customer location behavior.

Original PR description

Since #146458, when a new company is inserted, we set the 'Inter-company transit' location as its Vendor and Customer location. As this field is company-dependant, we need to assign it from the PoV of each company, which will create a ton of ir.property as the number of company grows.

This commit improves a bit the perfs at a high company count by batching the first write.

Comparison with a DB with 200 companies, to insert a new company:
- Before: 9.43s
- After: 6.77s

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#performance#company setup#inventory

[FIX] hr_appraisal_survey: prevent the TypeError error when uninstalling module

PR #60612

Enterprisesaas-17.2hr_appraisal_survey

Uninstalling the Appraisal Survey module no longer fails because of an outdated setup reference left after a previous code change. This helps administrators remove the module cleanly when it is no longer needed, without requiring technical intervention.

Original PR description

Currently, an error occurs when the user tries to uninstall the `hr_appraisal_survey` module.

error: `AttributeError: module 'odoo.addons.hr_appraisal_survey' has no attribute 'uninstall_hook'`

This is because the recently refactored code with https://github.com/odoo/enterprise/commit/8487fc4e7464316539c3ecaebd1844a556ed0c86 in saas-17.2 removes the `uninstall_hook` method, but its reference is still present in the manifest.

This commit will fix the above issue by removing `uninstall_hook` from the manifest.

sentry-5174558827

#uninstall#appraisal#survey

[FIX] helpdesk_timesheet: ensure the timesheet date is the current one

PR #60502

Enterprisesaas-17.2helpdesk_timesheet

This fix prevents timezone differences between users from causing helpdesk timesheet tests to behave inconsistently. It ensures the same user creates and validates the timesheets, so validated records keep the expected project link when a ticket changes.

Original PR description

Before this commit, the timesheets created inside `test_timesheet_ticket_consistency_when_helpdesk_team_change`
and `test_timesheet_check_warning_when_helpdesk_team_change` tests could
be unvalidated even after calling `action_timesheet_validate`.
The reason is because the timesheets are created by the current user
(OdooBot) is our case and his timezone could be different than the user
who validates the timesheets and so the timesheets date could be
tomorrow for the timesheet approver used inside that test becaue of the
timezone is not the same for the both users.

To avoid timezone issue, this commit makes sure the same user creates and
validates those timesheets since the goal of that test is to check the
`project_id` field is unchanged for validated timesheets even if the
ticket changed.

runbot-61592

#timesheets#helpdesk#timezone#tests

[FIX] core: use logger exception instead error to show exception details

PR #160348

Coresaas-17.2core

This update improves how system errors are recorded so support and engineering teams receive more complete diagnostic details. Better error reports help teams understand failures faster and reduce time spent investigating issues.

Original PR description

This commit ensures that the complete exception information is captured by Sentry with the use of logger exception.

This modification improves the error reporting functionality by providing more comprehensive information about the encountered exceptions. This will aid in debugging and diagnosing issues, enabling faster resolution of potential problems.

see-https://github.com/odoo/odoo/commit/ff9da0e9e20a1c4ba682af40fecd23bac121b5d1

#error reporting#diagnostics#Sentry

Since [1], it's possible to override the language of the user by adding the language to the query string : `lang=en_US`. Since [2], all the key, values pairs that were on the fragment of the url, are now on the query string, and they are manipulated by the router. The information that was previously on the query string, are marked as a lockedKeys to avoid losing them when reloading the page or when a new state is push (as for example the debug key). Unfortunately, lang was forgotten in this list, which lead to a lost of the override language when we reload the browser. [1] : https://github.com/odoo/odoo/commit/286cc97dd45a218ce763f9f15bc34f3226e13296 [2] : https://github.com/odoo/odoo/commit/c63d14a0485a553b74a8457aee158384e9ae6d3f

Since #146458, when a new company is inserted, we set the 'Inter-company transit' location as its Vendor and Customer location. As this field is company-dependant, we need to assign it from the PoV of each company, which will create a ton of ir.property as the number of company grows. This commit improves a bit the perfs at a high company count by batching the first write. Comparison with a DB with 200 companies, to insert a new company: - Before: 9.43s - After: 6.77s --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Currently, an error occurs when the user tries to uninstall the `hr_appraisal_survey` module. error: `AttributeError: module 'odoo.addons.hr_appraisal_survey' has no attribute 'uninstall_hook'` This is because the recently refactored code with https://github.com/odoo/enterprise/commit/8487fc4e7464316539c3ecaebd1844a556ed0c86 in saas-17.2 removes the `uninstall_hook` method, but its reference is still present in the manifest. This commit will fix the above issue by removing `uninstall_hook` from the manifest. sentry-5174558827

Before this commit, the timesheets created inside `test_timesheet_ticket_consistency_when_helpdesk_team_change` and `test_timesheet_check_warning_when_helpdesk_team_change` tests could be unvalidated even after calling `action_timesheet_validate`. The reason is because the timesheets are created by the current user (OdooBot) is our case and his timezone could be different than the user who validates the timesheets and so the timesheets date could be tomorrow for the timesheet approver used inside that test becaue of the timezone is not the same for the both users. To avoid timezone issue, this commit makes sure the same user creates and validates those timesheets since the goal of that test is to check the `project_id` field is unchanged for validated timesheets even if the ticket changed. runbot-61592

This commit ensures that the complete exception information is captured by Sentry with the use of logger exception. This modification improves the error reporting functionality by providing more comprehensive information about the encountered exceptions. This will aid in debugging and diagnosing issues, enabling faster resolution of potential problems. see-https://github.com/odoo/odoo/commit/ff9da0e9e20a1c4ba682af40fecd23bac121b5d1