Saturday, April 13, 2024
9 changes · saas-17.1
Miscellaneous changes
[This first commit] made it possible to have an error when there was no comparator for a field with conditional visibility. [This second commit] prevented an error from occurring in this case. The purpose of this commit is to prevent the user from getting a conditional visibility configuration for a form field where there is no comparator. Steps to reproduce the problem: - Go to /contactus. - Edit page. - Click on the "Your Company" field. - Select "Visible Only If" for the "Visibilit
Original PR description
[This first commit] made it possible to have an error when there was no comparator for a field with conditional visibility. [This second commit] prevented an error from occurring in this case. The…
[This first commit] made it possible to have an error when there was no comparator for a field with conditional visibility. [This second commit] prevented an error from occurring in this case. The purpose of this commit is to prevent the user from getting a conditional visibility configuration for a form field where there is no comparator. Steps to reproduce the problem: - Go to /contactus. - Edit page. - Click on the "Your Company" field. - Select "Visible Only If" for the "Visibility" option. - Click on "Visible Only If" again. => The comparator is not defined. Another way to have the issue was: - Drop a form on a page. - Click on the "Your Company" field. - Select "Visible Only If" for the "Visibility" option. - Set visible only if Your Name is equal to "test" as condition. - Click on Your Name field. - Change the field type to Radio Buttons. => The comparator is not defined. This commit fixes those two cases. Technical information: When we change the field's visibility to conditional (`setVisibility`), we add a default visibility dependency (`_setVisibilityDependency`). At this point, the comparator is removed and added in `_renderCustomXML`. `_renderCustomXML` was only called if the visibility dependency had changed. [This first commit]: https://github.com/odoo/odoo/commit/910897fc97d87b08f01627094ec8c159f5267628 [This second commit]: https://github.com/odoo/odoo/commit/808780c89cfba940957f7410f787de31e31bda27 opw-3806409 Forward-Port-Of: odoo/odoo#161527 Forward-Port-Of: odoo/odoo#160464
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#161548
Original PR description
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#161548
This commit will make a `willDrag` information available to the draggable_hook_builder context. This is needed to fix a resize issue in the gantt view. See correlated enterprise pull request. Forward-Port-Of: odoo/odoo#161446 Forward-Port-Of: odoo/odoo#161096
Original PR description
This commit will make a `willDrag` information available to the draggable_hook_builder context. This is needed to fix a resize issue in the gantt view. See correlated enterprise pull request. Forward-Port-Of: odoo/odoo#161446 Forward-Port-Of: odoo/odoo#161096
**Steps to reproduce:** - Enable debug mode. - Select a document (say a pdf file). - Replace it with a non-pdf file (say png). **Issue:** Currently, the file extension is not updated on replacing a document according to the newly uploaded document. **Cause:** The compute method of file extension fetched and set its value only if it was not set already. As a result, the extension was never updated as the field already had a set value (of the older file). **Fix:** This PR alters th
Original PR description
**Steps to reproduce:** - Enable debug mode. - Select a document (say a pdf file). - Replace it with a non-pdf file (say png). **Issue:** Currently, the file extension is not updated on replacing a document according to the newly uploaded document. **Cause:** The compute method of file extension fetched and set its value only if it was not set already. As a result, the extension was never updated as the field already had a set value (of the older file). **Fix:** This PR alters the code of `_compute_file_extension` to ensure that the extension is recomputed and set every time the name of a document file changes. Task: [3801686](https://www.odoo.com/web#id=3801686&menu_id=4722&cids=2&action=333&active_id=10888&model=project.task&view_type=form) Forward-Port-Of: odoo/enterprise#58656
Steps to reproduce ================== - Go to consolidation - Open a record from the dashboard - Go to "trial balance grid" by clicking on the edit button - Clicks on any consolidation account => It gives the traceback Cause of the issue ================== The value of the "range" variable is undefined, thus giving the traceback while trying to access the "name". Forward-Port-Of: odoo/enterprise#60442
Original PR description
Steps to reproduce ================== - Go to consolidation - Open a record from the dashboard - Go to "trial balance grid" by clicking on the edit button - Clicks on any consolidation account => It gives the traceback Cause of the issue ================== The value of the "range" variable is undefined, thus giving the traceback while trying to access the "name". Forward-Port-Of: odoo/enterprise#60442
### Steps to reproduce * install `l10n_lu` * open the Tax Report * create a tax closing and attempt to post it You will be met with a traceback: `Trying to dispatch an action on a report not compatible with the provided options` ### Cause The bug occurs when attempting to post a tax closing for a tax report that includes sections. This issue originates from the behavior of the `get_options()` method, which, when invoked on a report containing sections, retrieves the `report_id` o
Original PR description
### Steps to reproduce * install `l10n_lu` * open the Tax Report * create a tax closing and attempt to post it You will be met with a traceback: `Trying to dispatch an action on a report not…
### Steps to reproduce * install `l10n_lu` * open the Tax Report * create a tax closing and attempt to post it You will be met with a traceback: `Trying to dispatch an action on a report not compatible with the provided options` ### Cause The bug occurs when attempting to post a tax closing for a tax report that includes sections. This issue originates from the behavior of the `get_options()` method, which, when invoked on a report containing sections, retrieves the `report_id` of a section instead of the main report's ID. This discrepancy occurs because of a feature in the code known as 'rerouting', which intentionally changes the `report_id` to that of the section. Consequently, when an action is dispatched to the main report using these options, an error is triggered due to the mismatch between the expected report ID and the one provided through the options. ### Fix To resolve this issue, the fix involves utilizing the `on_sections_source` parameter when dispatching the action for tax closing. By setting this parameter to true for composite reports, it effectively disables the rerouting behavior, ensuring that the action is directed to the correct report ID, thus avoiding the error. opw-3816175 opw-3833979 Forward-Port-Of: odoo/enterprise#59472
Added partners tax id to DateV export. When exporting the DateV zip file from the General Ledger (in Germany namely), the Customers and Vendors CSV files miss the TAX ID of the partners. The auditors demand it to check the validity of the taxes applied to each transaction. VAT number should be added to the csv files (10th column) according to the DATEV documentation: https://developer.datev.de/datev/platform/de/dtvf/formate/debitoren_kreditoren task-3806969 Forward-Port-Of: odoo/enterp
Original PR description
Added partners tax id to DateV export. When exporting the DateV zip file from the General Ledger (in Germany namely), the Customers and Vendors CSV files miss the TAX ID of the partners. The auditors demand it to check the validity of the taxes applied to each transaction. VAT number should be added to the csv files (10th column) according to the DATEV documentation: https://developer.datev.de/datev/platform/de/dtvf/formate/debitoren_kreditoren task-3806969 Forward-Port-Of: odoo/enterprise#59333
Current request to mapbox matrix API is failing because the matrix requested have a size of 1. Based on their documentation: "The minimum number of elements per request is two (one source × two destinations, or two sources × one destination); requests with single-element results are not supported." Therefore we add the first coordinate point as destination. First distance received by API will be 1st to 1st point then second one is 1st to 2nd point. opw-3845936 Forward-Port-Of: odoo/en
Original PR description
Current request to mapbox matrix API is failing because the matrix requested have a size of 1. Based on their documentation: "The minimum number of elements per request is two (one source × two destinations, or two sources × one destination); requests with single-element results are not supported." Therefore we add the first coordinate point as destination. First distance received by API will be 1st to 1st point then second one is 1st to 2nd point. opw-3845936 Forward-Port-Of: odoo/enterprise#60598
**Before this commit** At the start of a pill resize sequence, if you go fast and your pointer enters an adjacent pill right before the sequence starts you may end up resizing the wrong record. **After this commit** The draggable_hook_builder has been improved in order to inform us when a drag sequence will start. We take advantage of this in order to fix the above issue. Forward-Port-Of: odoo/enterprise#60510 Forward-Port-Of: odoo/enterprise#60328
Original PR description
**Before this commit** At the start of a pill resize sequence, if you go fast and your pointer enters an adjacent pill right before the sequence starts you may end up resizing the wrong record. **After this commit** The draggable_hook_builder has been improved in order to inform us when a drag sequence will start. We take advantage of this in order to fix the above issue. Forward-Port-Of: odoo/enterprise#60510 Forward-Port-Of: odoo/enterprise#60328