Tuesday, April 16, 2024
34 changes
Resolved issues and error corrections
This update corrects an internal logic issue in how credit limits are calculated for customer accounts. The fix ensures that company information is properly handled during the calculation process, improving the accuracy and reliability of credit limit determinations.
Original PR description
While in practice you would never get this inverse called with more than one record at a time, it is still wrong to get the company of self in the loop. Fixing it to keep good conscience :) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#161815
The Greek VAT number format has been corrected to use the proper EL prefix (EL123456783) instead of the incorrect GR prefix. This ensures that Greek company VAT numbers are validated correctly in the system, preventing validation errors for Greek businesses.
Original PR description
According to https://www.easytax.co/en/countries/greece the vat number format for Greece is EL123456783 instead of GR12345670. We also delete the line for country code `el` from `_ref_vat` dict as we use `gr` for Greece. opw-3845662 Forward-Port-Of: odoo/odoo#161278
This update fixes a bug in the accounting system that was causing errors when processing custom taxes. The system now correctly handles tax mapping by focusing only on standard taxes from the core accounting module, preventing crashes when custom taxes don't follow the standard naming format. This resolves upgrade issues for affected customers.
Original PR description
Rewrite the mapping from xmlid to tax to only take into account standard taxes from the 'account' module
Related to blocking upgrade request [upg-1494099](https://upgrade.odoo.com/web#id=1494099&model=upgrade.request)
If there is a custom tax created by the user with a external id that doesn't contain '_', the mapping fails.
Traceback:
```
File "/home/odoo/src/odoo/17.0/addons/account/models/chart_template.py", line 280, in <dictcomp>
xml_id.split('.')[1].split('_', maxsplit=1)[1]: self.env['account.tax'].browse(record)
IndexError: list index out of range
```
Only standard taxes (from `account` module) should be taken into account.
Forward-Port-Of: odoo/odoo#161877This update removes a duplicate styling class that was appearing twice in the Record Selector component, which could cause inconsistent styling behavior. By cleaning up this duplication, the component now applies styles more predictably and reliably, improving the overall user interface consistency.
Original PR description
This commit removes the unnecessary duplicate of the 'o-input' class being present in the template of the (Multi)RecordSelector components. As the RecordAutocomplete component uses the Autocomplete component, which already set this classname on its <input> node, the class was present twice in the DOM. This could affect the style when trying to write a rule on .o_input since both elements would get the style. Now, only the input keep the class, which makes things easier and more predictable.
Fixed a bug where the powerbox menu (used in the Notes app) would continuously grow in size when navigating with arrow keys in right-to-left languages like Arabic. The fix ensures the powerbox displays at its correct size immediately by properly calculating its width before positioning, improving the user experience when using the editor in RTL languages.
Original PR description
Issue: ====== The powerbox keep increasing in size when you input. Steps to reproduce the issue: ============================= - Install arabic - Go to notes - write `/`, you can see the powerbox is…
Issue: ====== The powerbox keep increasing in size when you input. Steps to reproduce the issue: ============================= - Install arabic - Go to notes - write `/`, you can see the powerbox is a bit smal - use `down/up`arrows to navigate in the powerbox. - The powerbox width increase until finally gets to it's intended position. Origin of the issue: ==================== Since we are providing that `marginRigh` should be equals to `20` in `getRangePosition` we will move the powerbox to the left a bit and then with the style property `max-width=100%` it will increase in size because the current size is a bit small for it. So at every key pressed it will increase by 20px until it gets to a point where everything is set and the `marginRight=20` is finally visible. Soltuion: ========= We set min-width as max-content so we can position correctly the powerbox knowing it's final width. task-3721794 Forward-Port-Of: odoo/odoo#161089 Forward-Port-Of: odoo/odoo#157668
This fix prevents database constraint records from being accidentally deleted when modules are loaded. The system now properly preserves existing constraint data that was previously being removed due to a technical oversight in how constraints are tracked during the module loading process.
Original PR description
When we load a module and the SQL constraints exist both in the table and in `ir_model_constraint` we need to ensure the xmlid is loaded. Otherwise the record in `ir_model_constraint` is removed. Since 4c9968397b0714bc90a9c94c4673bd3148db4010 we skip returning existing non-updated constraint records in `_reflect_constraint`. This leads to them being removed by the ORM. At the end of the load the ORM sees the record in `ir_model_data` but not in the xmlid pool, thus it removes it. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#161893
This update corrects a bug where column visibility settings were being incorrectly overwritten in the language management interface tree view. The fix ensures that column visibility preferences are properly preserved and displayed as intended, improving the user experience when managing language configurations.
This fix resolves an error that occurred when customers selected a Mondial Relay pickup location during checkout and then reloaded the page. The system was incorrectly trying to validate mandatory fields (like phone number) on Mondial Relay addresses, which cannot be edited. The fix removes this validation check for Mondial Relay partners, allowing customers to complete their checkout process without errors.
Original PR description
Steps to reproduce: 1) Set up mondial relay and publish it 2) Go to /shop, add a product and checkout 3) Choose a pickup location of mondial relay 4) Reload the page 5) Observe an error 'You cannot edit the address of a Point Relais' Reason: a partner was created without mandatory field 'phone` for the shipping address Solution: do not check mandatory fields for mondial relay partners as it is not allowed to edit them
A performance test for the website blog module was causing random failures and wasn't providing meaningful results. This update removes the problematic test to improve system reliability and reduce false test failures.
Original PR description
Since [this commit], the `test_10_perf_sql_blog_standard_data` test failed randomly. As testing sql perf for website without cache doesn't really make sense (as explained in [this other commit]) we can can just remove the test without cache. [this commit]: https://github.com/odoo/odoo/commit/88b016fdc407e318c43c96df9b582853512f04fa [this other commit]: https://github.com/odoo/odoo/commit/dad8dca0da23143eb2f28debde5139e907368a2e runbot-55755