Wednesday, April 17, 2024
10 changes · 17.0
Resolved issues and error corrections
This update improves the appointment booking experience by adding a 'More Options' button that lets users access the complete appointment form without opening a new tab. It also fixes an issue where the wrong person was being set as the organizer when booking through the calendar view. These changes make the booking process more efficient and accurate.
Original PR description
1>To activate the complete form view, allowing additional details beyond the fields in the 'calendar_event_view_form_gantt_booking' view to be included without requiring users to open a new tab and search for the event separately, which is highly inefficient. 2>The logged user was being set as an organizer by default even though a particular attendee's slot had been clicked on the gantt view. so the attendee will be set as an organizer by default when clicking on the slot. A test case has been added to ensure the above functionality for the gantt view does not break. Task-3679307
This fix resolves an error that occurred when employees tried to request signatures for multiple contracts at once from the contracts list. The signature request action has been removed from the bulk actions menu to prevent this issue, ensuring users can only request signatures for individual contracts.
Original PR description
STEP TO REPRODUCE:
=================
* Go on Employee App
* Select contracts menu item
* Select two contracts
* Click on actions
* Select "signature request"
You will have a traceback due to multiple selection.
task: 3802377This update removes outdated code from the IoT module that was generating warning messages in system logs. The change replaces an older method for checking if required libraries are available with a newer, recommended approach. This cleanup helps maintain system stability and keeps the codebase current with Odoo's latest standards.
Original PR description
Currently, iot module uses `get_resource_path` to check whether a Worldline libeasyctep.so library is present on the IoT Box. It is currently provoking a deprecation warning in logs: ``` 2024-04-16…
Currently, iot module uses `get_resource_path` to check whether a Worldline libeasyctep.so library is present on the IoT Box.
It is currently provoking a deprecation warning in logs:
```
2024-04-16 09:34:02,574 2873 WARNING ? py.warnings: /home/pi/odoo/odoo/modules/module.py:167: DeprecationWarning: Since 17.0: use tools.misc.file_path instead of get_resource_path(hw_driver>
File "/usr/lib/python3.11/threading.py", line 995, in _bootstrap
self._bootstrap_inner()
File "/usr/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
self.run()
File "/home/pi/odoo/addons/hw_drivers/main.py", line 106, in run
helpers.load_iot_handlers()
File "/home/pi/odoo/addons/hw_drivers/tools/helpers.py", line 400, in load_iot_handlers
spec.loader.exec_module(module)
File "/home/pi/odoo/addons/hw_drivers/iot_handlers/interfaces/CTEPInterface_L.py", line 15, in <module>
if not get_resource_path("hw_drivers", "iot_handlers", "lib", "ctep", "libeasyctep.so"):
File "/home/pi/odoo/odoo/modules/module.py", line 167, in get_resource_path
warnings.warn(
```
Since `get_resource_path` is deprecated as of v17.0, this PR replaces it by `file_path` to remain up to date.
Apart from replacing the deprecated `get_resource_path`, this PR also replaces `subprocess.check_call` by the `subprocess.run` in the corresponding code as suggested by subprocess documentation starting from Python v3.5
Finally, it prettifies the modified lines of code a little by changing a variable name and modifying the logger message in case of an error to make it more specific
task-3872853This fix prevents crashes when users try to add access rights category fields to the Users view in Odoo Studio. These fields are dynamic and change based on group hierarchy, so they are no longer offered as available fields to add. This improves the stability and user experience when customizing user management views.
Original PR description
…or res.users Open the base action for res.users (Settings => Users) Unfold the Existing fields list, and search for a field reprensenting an access rights category. Before this commit, adding such field crashed because some meta data were missing in the fields_get. Since those fields are dynamic and may change with any changes in groups' hierarchy, it doesn't really make sense to make them available to add on a view. Before this commit, those fields are not proposed any more. opw-3842879 Forward-Port-Of: odoo/enterprise#60719 Forward-Port-Of: odoo/enterprise#60321
This fix resolves an issue where e-invoices submitted from Rio Grande do Sul were being rejected by tax authorities due to missing recipient name information. The system now correctly includes the location name attribute when required by specific Brazilian states, allowing invoices to be successfully submitted and processed.
Original PR description
Some states (e.g. Rio Grande do Sul) require the name attribute to be set, others (e.g. Paraná) do not and will take the businessName. Before this, submitting an e-invoice for Rio Grando do Sul results in "Rejeicao: NF-e sem o nome do destinatario" (code: 724). After this, submitting the invoice succeeds. opw-3793773
Portal users will now receive a clear notification message when they try to open embedded views in Knowledge articles, informing them that only internal team members can access this feature. This prevents confusion and improves the user experience by explaining why the view cannot be opened.
Original PR description
**Steps to reproduce:** 1) Open any view of any module. 2) Click on insert a link in the article from Favorites. 3) Now publish the article from the share panel. 4) Copy that link and open it from the portal user. 5) Click on the embedded link(if only read access), double click on it(if write access). **Solution:** Notify the portal user with a toaster notification that only internal members can open that view. **Task**-3082042 Forward-Port-Of: odoo/enterprise#57347
This fix resolves issues with how the accounting system handles dependencies across multiple companies. The change ensures that account move line records properly respect company boundaries, preventing data conflicts and ensuring accurate financial reporting when using multiple company configurations.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix resolves a critical issue where Safari 16.5 crashes when customers view their shopping cart on the website. The problem was caused by a circular color reference in the horizontal line styling that Safari couldn't handle. The fix simplifies the color styling to prevent the crash while maintaining the same visual appearance.
Original PR description
__Current behavior before commit:__ The `color` attribute of `hr` is set to `$hr-color`[1]. `$hr-color` is equal to `$border-color`[2] which itself is equal to `--o-border-color`[3]. Finally…
__Current behavior before commit:__ The `color` attribute of `hr` is set to `$hr-color`[1]. `$hr-color` is equal to `$border-color`[2] which itself is equal to `--o-border-color`[3]. Finally `--o-border-color` is set using `fade-currentColor()`[4] which uses the `color-mix` css function on `currentColor`[5]. In short, the `color` of `hr` depends on itself. This creates a circular reference that makes Safari 16.5 crash. This bug is caused by WebKit. There seems to be a commit to fix[6] this bug but it looks like it was not backported to this version of Safari. __Description of the fix:__ Set `$hr-color` to a fixed value by introducing `--o-hr-color` which is set to the same value of the already existing fallback of `--o-border-color`. __Steps to reproduce the issue on runbot:__ 1. Go to the website shop using Safari 16.5 2. Add an item to the cart 3. Open the cart view 4. Safari crashes opw-3806725 [1]: https://github.com/odoo/odoo/blob/1154556/addons/web/static/lib/bootstrap/scss/_reboot.scss#L71 [2]: https://github.com/odoo/odoo/blob/1154556/addons/website/static/src/scss/bootstrap_overridden.scss#L333 [3]: https://github.com/odoo/odoo/blob/1154556/addons/website/static/src/scss/bootstrap_overridden.scss#L91 [4]: https://github.com/odoo/odoo/blob/1154556/addons/website/static/src/scss/website.scss#L35 [5]: https://github.com/odoo/odoo/blob/1154556/addons/website/static/src/scss/primary_variables.scss#L2219 [6]: https://github.com/WebKit/WebKit/commit/0d0b884
This fix removes unnecessary and non-functional border width size options (small and large) from the website theme editor's input field styling controls. These options were displaying empty and serving no purpose, so they have been cleaned up to simplify the user interface and reduce confusion when customizing website themes.
Original PR description
Steps to reproduce : 1. click on edit website. 2. click on THEME tab from snippet options. 3. scroll down to input fields. 4. the border width has options for small and large size, which serves no purpose and were displayed empty. Purpose: This PR aims to remove the changes made on [[1]](https://github.com/odoo-dev/odoo/commit/6c0d2da07d2df2a27155678f58a6ffc79351e543) which added 2 sub-levels options for Border Width for Input Field which served no purpose. After this PR : The Border Width option will not have sub options small and large. task-3771146 Forward-Port-Of: odoo/odoo#157374
This fix resolves a bug where autocomplete fields (like the salesperson field in CRM) could get stuck with invalid values that couldn't be saved. When users typed an invalid value and clicked away, scrolled, or pressed escape, the field would remain in a broken state. Now the field properly reverts to the last valid value, ensuring data integrity and preventing confusing situations where changes appear unsaved.
Original PR description
This commit fixes a bug where the value of an autocomplete with autoselect could go into an undefined state where the model value doesn't match the input value but no change is detected. This would…
This commit fixes a bug where the value of an autocomplete with autoselect could go into an undefined state where the model value doesn't match the input value but no change is detected. This would happen on escape press, scroll and more recently due to https://github.com/odoo/odoo/pull/159333 on click out. To fix this issue, the commit introduces some change in the autocomplete behavior so that it will no longer select the active option on click out (blur) when autoselect is active and instead it will revert the input value to the one stored into the model. Also applies this behavior on escape key press and scroll for the before mentioned reasons. Steps to reproduce: - Go to CRM form view - Edit the salesperson name to some non existant one and click out (or scroll or press escape) Before the fix, the name was stuck to the invalid one but no change was detected so we couldnt save it. Before https://github.com/odoo/odoo/pull/159333, click out would select the active option of the dropdown instead (and launch a dialog for quick create). This is removed because the behavior is neither intuitive nor practical. After the fix, the name is reset to its previous valid value instead. This applies to all autocomplete components with autoselect prop set to true. Forward-Port-Of: odoo/odoo#161913 Forward-Port-Of: odoo/odoo#161251