Thursday, April 18, 2024
23 changes · 17.0
Enhancements to existing features
This update adds coverage for Italian e-invoicing when a received supplier bill contains negative amounts. It helps ensure users are guided to create a credit note instead of posting an invalid negative bill.
Original PR description
Added a test to verify the behaviour when receiving a negative bill. The invoice gets imported with negative amounts, but it can't be posted. When the user tries to post it, they are prompted to turn it into a credit note with a UserError.
The notification center activity labels now display with text truncation instead of breaking into multiple lines, ensuring a cleaner and more consistent visual appearance across all languages. This improvement maintains the design integrity of the interface and prevents awkward line wrapping when activity text is longer.
Original PR description
**Current behavior before PR:** In systray activity, for some languages, when there were few activities (exceeded a certain length of text), it would break the line to display the labels.  **Desired behavior after PR is merged:** Now, to maintain the design integrity, the text has been truncated to visually display the labels like "aujourd'hu.." and maintain the design consistency. **Task**-3869856
Resolved issues and error corrections
Fixed an issue in Events where clearing an email template in the communication tab made that field impossible to click again. Users can now reselect or update the template without needing a workaround, keeping event communication setup smooth.
Original PR description
Steps to reproduce: - Install events - Go in events - Select any events - Go to communication tab - Remove template field in a line Issues: The field is now unclickable for that line. opw-3727038
Miscellaneous changes
The `:` introduced by https://github.com/odoo/odoo/pull/160337 should be an assignment. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#162150
Original PR description
The `:` introduced by https://github.com/odoo/odoo/pull/160337 should be an assignment. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#162150
Spanish invoice labels for Ecuadorian withholding taxes were corrected so invoices show the right wording. This helps businesses issue clearer, more accurate tax documents and reduces confusion for customers and accountants.
Original PR description
Fix errors in some of the spanish invoice_labels for withholding taxes. Thanks to @AlmustafaNET odoo/odoo/#147867
PDF exports of account reports now show the correct VAT number. If no tax unit is used, the company VAT is displayed; when tax units are used, the tax unit VAT is shown instead.
Original PR description
Before this commit: When exporting a report to a pdf if we were not using tax units there was no VAT After this commit: When exporting a report as pdf company VAT is shown if no tax unit is used. If we are using tax units, then tax units VAT will be shown instead task: 3864218 see: odoo#58361
The message prompting Peruvian e-invoicing users to buy extra credits now shows a proper clickable link instead of visible HTML code and a raw URL. This makes the guidance clearer and easier for users to act on when they need additional credits.
Original PR description
The message to buy extra credits is escaped and instead of displaying the message with a link it displays the message with a html and a url, not very human user like. We have to unescape the < and > symbols so that the frontend can propery display the message opw-3864033
This update fixes failing automated tests in the mail and WhatsApp modules by correcting test dependencies and ensuring proper data cleanup before tests run. The changes resolve build failures in the testing system and improve test reliability without affecting end-user functionality.
This update improves the reliability of appointment scheduling tests by making them less dependent on timing issues and interference from other system components. The changes include resetting test data before running tests, updating test performance metrics, and fixing naming conflicts that were causing test failures. This helps ensure the appointment feature works consistently across different environments.
This fix removes a duplicate "Skills" title that was appearing on the resume page in employee profiles. The issue was caused by an ineffective label setting that still displayed the label despite being configured to hide it. Users will now see the Skills section with only one title instead of two.
Original PR description
Steps to reproduice: -go to myprofile with hr installed -go to resume page -> skills title is duplicated Reason: The no_label attribute is set to True but the widget will still display a label. Expected behavior: The label should only be displayed once Fix: Remove the effectless no_label attribute and remove the separator task: 3815381 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The product variant form view was incorrectly counting archived pricelists in the "Extra Price" smart button. This fix ensures that only active pricelists are counted and displayed, giving users an accurate view of available pricing options for each product variant.
Original PR description
Problem: When we are in the form view of a product variant, the smart button "Extra Price" shows the number of pricelists for this variant including the archived ones Steps to reproduce: - Install "Sales" app and activate the pricelists - Create a product and some variants - Create at least one pricelist for a variant - Archive at least one of these pricelist - Go on the form view of the variant and take a look at the smart button which shows the number of pricelists including the archived ones Cause: The domain that filters the pricelists doesn't take in consideration whether the pricelist is active opw-3836973 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update fixes automated tests in the portal module that were failing when the system runs without demo data. The tests have been made independent from demo data requirements, and additional tour tests have been updated to handle scenarios where portal users have limited address information. This ensures the portal functionality works reliably in all configurations.
Original PR description
Followup of odoo/odoo@d6d6bee087fe2d3dc17974054353430c2662aecf : test was not written to be independent from demo data. Also update other tour that fails in no-demo mode as portal user has not enough address value set to continue the tour, compared to demo mode. Task-3871642 Runbot-56554 Runbot-56553 Runbot-61488
This fix ensures that the main company's country is properly configured in mail module tests to prevent issues when running tests without demo data. This improves test reliability and prevents failures in non-demo mode environments.
Original PR description
Just to avoid some issues in no demo mode. Task-3871781
This update fixes issues with test performance counters and automated build processes in the mail and messaging modules. The changes ensure tests properly flush data before running and update counter expectations, which improves the reliability of automated testing and prevents build failures.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update adds the missing translation file for the sales async emails module that was previously added to the system. By including the translation template file, the module can now be properly translated into different languages, ensuring a consistent user experience across all supported locales.
Original PR description
Commit f0016849 added the module `sale_async_emails` but not the .pot file.
This fix improves the efficiency of the digest system by preventing unnecessary write operations to the default digest configuration. The change reduces database load and improves system performance when digest settings are processed, ensuring updates only occur when actual changes are needed.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A bug was found where the website configurator was using an incorrect environment reference that could cause failures in certain testing scenarios. This fix corrects the environment reference to use the proper method context, ensuring the configurator works reliably both in normal website operations and in automated tests.
Original PR description
Commit [1] in 17 introduced a `request.env` instead of `self.env` in `configurator_apply()`. It was not seen and went through the merge. It should not have any bad impact in real use cases as the method is always called from the frontend context and `request` is bound but we have this test [1] which was introduced in 17.1 which is calling `configurator_apply()` in a python standalone unit test, where `request` is unbound. It allowed us to detect the mistake since the nightly was red because of it. [1]: https://github.com/odoo/odoo/commit/9f319cbc95f8f4cb76df6f2b82e4b43a74f4b753 [2]: https://github.com/odoo/design-themes/commit/b8aae07df41b44aa78cf39ff6104136556199130
This fix improves the readability of selected project examples when using dark mode. Previously, the selected example name appeared in black text, which was difficult to read against the dark background. The text color has been changed to white to ensure proper contrast and visibility for all users.
Original PR description
Steps to reproduce the issue: ---------------------------- 1. Enable dark mode 2. Go to Project app 3. Create a new project 4. Click on `See examples` in the kanban 5. Select an example. Actual Behavior: --------------- The name of the selected example is in black instead of white. Expected Behavior: ----------------- The name of the selected example should be in white. Solution: -------- Update the font color of the selected example name to white for better contrast in dark mode. task-3602610 Forward-Port-Of: odoo/odoo#146815
Fixed an unreliable test in Google Calendar that was incorrectly assuming the order of event attendees. The test now properly identifies the invited attendee regardless of the order in which attendees are stored, ensuring consistent and reliable test results when syncing recurring event acceptances from Google Calendar to Odoo.
Original PR description
The `test_accepting_recurrent_event_*` tests make sure that accepting recurrent events on google side reflect in odoo. The test was failing because of the following: when retrieving the invited attendee, the test used `self.assertEqual(event.attendee_ids[1].state, expected_states[i])` assuming that organizer will be at index `0` and invited user at index `1`. However the list of `event.attendee_ids` is ordered by create_date. And we create both organizer and attendee with the same command at the same time: `partner_ids=[Command.set([self.organizer_user.partner_id.id, self.attendee_user.partner_id.id])]` So we might have organizer at index `1` and invited attendee at index `0`. This resulted in the indeterministic behavior of the test. To fix this issue: This commit changes how the invited attendee is retrieved, making sure that we always get the right attendee. fixes runbot-61527 Forward-Port-Of: odoo/odoo#161451
This update corrects an incorrect logging argument in the email server connection test within the base module. The fix ensures that error messages are properly logged when testing SMTP connections, improving the reliability of email configuration diagnostics.
Original PR description
[task-3703209](https://www.odoo.com/web#id=3703209&cids=1&menu_id=4720&action=333&active_id=10888&model=project.task&view_type=form)
This update removes an unnecessary parameter that was being sent to the AI text generation service, which was causing warnings. The fix cleans up the communication with the external service to ensure smooth operation without error messages.
Original PR description
Since [this other commit], web_editor can call IAP to generate text via chatGPT. Unfortunately, an unnecessary param (`version`) was given to IAP leading to a warning on the IAP side `generate_content_from_conversation> called ignoring args <version=X>`. This commit removes this useless param. [this other commit]: https://github.com/odoo/odoo/commit/386a2fdebf429b0318473e596ed9ac0966d9a8b5 Related to task-3383324
This fix removes clickable links for servers that haven't been configured yet in the IoT device homepage. Previously, users could click on unconfigured servers and be redirected to an unreachable page, creating a poor user experience. Now, unconfigured servers are displayed as non-clickable text, preventing users from attempting to access unavailable pages.
Original PR description
Actually if a server is not configured we can click on it and we are redirect to not reachable page With this commit it is not possible to click if server is not configured Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update removes a confusing certificate error message that appears when the POS device operates without a connection to an Odoo server. Since certificates cannot be obtained without a server connection, this error message was unnecessary and caused customer concern. The fix hides this message when the device is not connected to a server.
Original PR description
When the iot run without server we display an certificate error. This error is useless because we can't get a certificate without server. Some customer a worry about this error With this commit we hide this comment if we not connected to a Odoo server Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr