Odoo Changelog — 2024-04-18

Thursday, April 18, 2024

42 changes · saas-17.1

Bug Fixes(3)

Resolved issues and error corrections

[FIX] portal: prevent error while country is not selected

Coresaas-17.1portal

This fixes an error that could prevent users from saving their portal information when no country was selected. The portal now handles an empty country field safely, avoiding a frustrating crash during profile updates.

Original PR description

Currently, the error arises when saving details in the portal view without selecting a country

Steps to reproduce:

- Install the 'account' module and turn on developer mode.
- Navigate to Settings > Users & Companies > Users and open the current user.
- Open the related partner.
- Click on 'Invoice' and create a new invoice.
- Add a product and confirm it.
- Go to portal view and click on 'Edit information'.
- Click on the 'Save' button.

Stack Trace

```
ValueError: invalid literal for int() with base 10: 'False'
  File "<453>", line 531, in template_453
  File "<453>", line 416, in template_453_content
QWebException: Error while render the template
ValueError: invalid literal for int() with base 10: 'False'
Template: ir.ui.view(453,)
Path: /t/div[13]/select/t/option
Node: <option t-att-value="country.id" t-att-selected="country.id == int(country_id) if country_id else country.id == partner.country_id.id"/>
  File "odoo/http.py", line 2252, in __call__
    response = request._serve_db()
  File "odoo/http.py", line 1828, in _serve_db
    return self._transactioning(_serve_ir_http, readonly=ro)
  File "odoo/http.py", line 1848, in _transactioning
    return service_model.retrying(func, env=self.env)
  File "odoo/service/model.py", line 134, in retrying
    result = func()
  File "odoo/http.py", line 1826, in _serve_ir_http
    return self._serve_ir_http(rule, args)
  File "odoo/http.py", line 1833, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "odoo/http.py", line 1971, in dispatch
    return self.request.registry['ir.http']._dispatch(endpoint)
  File "odoo/addons/base/models/ir_http.py", line 224, in _dispatch
    result.flatten()
  File "odoo/http.py", line 1321, in flatten
    self.response.append(self.render())
  File "odoo/http.py", line 1313, in render
    return request.env["ir.ui.view"]._render_template(self.template, self.qcontext)
  File "addons/website/models/ir_ui_view.py", line 442, in _render_template
    return super()._render_template(template, values=values)
  File "odoo/addons/base/models/ir_ui_view.py", line 2023, in _render_template
    return self.env['ir.qweb']._render(template, values)
  File "odoo/tools/profiler.py", line 302, in _tracked_method_render
    return method_render(self, template, values, **options)
  File "odoo/addons/base/models/ir_qweb.py", line 594, in _render
    result = ''.join(rendering)
  File "<454>", line 86, in template_454
  File "<454>", line 68, in template_454_content
  File "<454>", line 41, in template_454_t_call_0
  File "<453>", line 539, in template_453
```

The issue occurs when attempting to save details in the portal view without selecting a country. At this point [1], a string "False" is passed as the 'country_id', and the system attempts to convert it into an integer using typecasting (int()).

link[1] : https://github.com/odoo/odoo/blob/fc55cd0ecb9e79ee4491537cc77baa0d57f1f3c7/addons/portal/views/portal_templates.xml#L500

To resolve this issue, the condition is added to ensure that only integer values are passed as a 'country_id'.

sentry-4959817278

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#portal#profile#country#error prevention

[REV] web: blacklist customer statements menu in clickall

PR #162390

Coresaas-17.1web

This change reverts a previous web automation adjustment and keeps the customer statements menu out of broad automated click testing. It helps avoid a known issue while the proper fix is handled in the related Enterprise change.

Original PR description

This reverts commit 05c669876a58afa450b946c35e6567d362b2afb5. The issue should be solve with the enterprise commit.


https://github.com/odoo/enterprise/pull/60951

#customer-statements#automation#clickbot

[FIX] account_followup: remove 'CREATE TEMP TABLE'

PR #60951

Enterprisesaas-17.1account_followup

This fix changes how follow-up payment reminder data is temporarily stored so read-only customer searches are handled correctly. It prevents an internal database write from blocking or interfering with read-only operations, improving reliability without changing user workflows.

Original PR description

The readonly flag on `res_partner`.`search` was not respected because
of `CREATE TEMP TABLE followup_data_cache`. It was used to create a
transactional cache. Instead of putting this cache on the database
side, put it on the Python side. On the Python side, the memory spike
should be the same (we've retrieved all the data at some point), but
the memory won't be free until the end of the transaction/cursor.

If the memory problem still occurs, we can easily reduce the memory
usage by 3 by avoiding  the use of dict and dictfetchall usages.

https://github.com/odoo/odoo/pull/162390

#follow-up#read-only#reliability

Other(39)

Miscellaneous changes

[FW][FIX] google_calendar: accepting recurrent event tests

PR #162286

Coresaas-17.1google_calendar

Original PR description

The `test_accepting_recurrent_event_*` tests make sure that accepting recurrent events on google side reflect in odoo. The test was failing because of the following:
when retrieving the invited attendee, the test used `self.assertEqual(event.attendee_ids[1].state, expected_states[i])` assuming that organizer will be at index `0` and invited user at index `1`. However the list of `event.attendee_ids` is ordered by create_date. And we create both organizer and attendee with the same command at the same time: `partner_ids=[Command.set([self.organizer_user.partner_id.id, self.attendee_user.partner_id.id])]` So we might have organizer at index `1` and invited attendee at index `0`. This resulted in the indeterministic behavior of the test.

To fix this issue:
This commit changes how the invited attendee is retrieved, making sure that we always get the right attendee.

fixes runbot-61527

Forward-Port-Of: odoo/odoo#161451

Currently, the error arises when saving details in the portal view without selecting a country Steps to reproduce: - Install the 'account' module and turn on developer mode. - Navigate to Settings > Users & Companies > Users and open the current user. - Open the related partner. - Click on 'Invoice' and create a new invoice. - Add a product and confirm it. - Go to portal view and click on 'Edit information'. - Click on the 'Save' button. Stack Trace ``` ValueError: invalid literal for int() with base 10: 'False' File "<453>", line 531, in template_453 File "<453>", line 416, in template_453_content QWebException: Error while render the template ValueError: invalid literal for int() with base 10: 'False' Template: ir.ui.view(453,) Path: /t/div[13]/select/t/option Node: <option t-att-value="country.id" t-att-selected="country.id == int(country_id) if country_id else country.id == partner.country_id.id"/> File "odoo/http.py", line 2252, in __call__ response = request._serve_db() File "odoo/http.py", line 1828, in _serve_db return self._transactioning(_serve_ir_http, readonly=ro) File "odoo/http.py", line 1848, in _transactioning return service_model.retrying(func, env=self.env) File "odoo/service/model.py", line 134, in retrying result = func() File "odoo/http.py", line 1826, in _serve_ir_http return self._serve_ir_http(rule, args) File "odoo/http.py", line 1833, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 1971, in dispatch return self.request.registry['ir.http']._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 224, in _dispatch result.flatten() File "odoo/http.py", line 1321, in flatten self.response.append(self.render()) File "odoo/http.py", line 1313, in render return request.env["ir.ui.view"]._render_template(self.template, self.qcontext) File "addons/website/models/ir_ui_view.py", line 442, in _render_template return super()._render_template(template, values=values) File "odoo/addons/base/models/ir_ui_view.py", line 2023, in _render_template return self.env['ir.qweb']._render(template, values) File "odoo/tools/profiler.py", line 302, in _tracked_method_render return method_render(self, template, values, **options) File "odoo/addons/base/models/ir_qweb.py", line 594, in _render result = ''.join(rendering) File "<454>", line 86, in template_454 File "<454>", line 68, in template_454_content File "<454>", line 41, in template_454_t_call_0 File "<453>", line 539, in template_453 ``` The issue occurs when attempting to save details in the portal view without selecting a country. At this point [1], a string "False" is passed as the 'country_id', and the system attempts to convert it into an integer using typecasting (int()). link[1] : https://github.com/odoo/odoo/blob/fc55cd0ecb9e79ee4491537cc77baa0d57f1f3c7/addons/portal/views/portal_templates.xml#L500 To resolve this issue, the condition is added to ensure that only integer values are passed as a 'country_id'. sentry-4959817278 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

The readonly flag on `res_partner`.`search` was not respected because of `CREATE TEMP TABLE followup_data_cache`. It was used to create a transactional cache. Instead of putting this cache on the database side, put it on the Python side. On the Python side, the memory spike should be the same (we've retrieved all the data at some point), but the memory won't be free until the end of the transaction/cursor. If the memory problem still occurs, we can easily reduce the memory usage by 3 by avoiding the use of dict and dictfetchall usages. https://github.com/odoo/odoo/pull/162390

The `test_accepting_recurrent_event_*` tests make sure that accepting recurrent events on google side reflect in odoo. The test was failing because of the following: when retrieving the invited attendee, the test used `self.assertEqual(event.attendee_ids[1].state, expected_states[i])` assuming that organizer will be at index `0` and invited user at index `1`. However the list of `event.attendee_ids` is ordered by create_date. And we create both organizer and attendee with the same command at the same time: `partner_ids=[Command.set([self.organizer_user.partner_id.id, self.attendee_user.partner_id.id])]` So we might have organizer at index `1` and invited attendee at index `0`. This resulted in the indeterministic behavior of the test. To fix this issue: This commit changes how the invited attendee is retrieved, making sure that we always get the right attendee. fixes runbot-61527 Forward-Port-Of: odoo/odoo#161451

**[FIX] payment(_stripe): adapt validation currency to payment method** When payment details are tokenized through a validation operation, the currency to use was usually (except overrides) chosen as that of the payment provider's company. This sometimes caused compatibility issues if the selected payment method did not support the company's main currency. For example, the SEPA Direct Debit payment method only supports the EUR currency. This commit allows passing a payment method when getting the validation currency so that only supported currencies can be returned. --- **[FIX] payment_(buckaroo, stripe): updated the PM based on provider codes** When processing a transaction, the payment method was searched based on the received code (e.g., 'sepa_debit') that was compared with the `payment` module's generic codes (e.g., 'sepa_direct_debit'). This commit ensures that we now compare with provider-specific codes for Buckaroo and Stripe. In practice, this mistake had little to no impact as most provider codes match the generic ones, and we fall back onto the payment method selected by the user if we can not find a more accurate one based on the code. Forward-Port-Of: odoo/odoo#161883

This commit fixes a bug where the value of an autocomplete with autoselect could go into an undefined state where the model value doesn't match the input value but no change is detected. This would happen on escape press, scroll and more recently due to https://github.com/odoo/odoo/pull/159333 on click out. To fix this issue, the commit introduces some change in the autocomplete behavior so that it will no longer select the active option on click out (blur) when autoselect is active and instead it will revert the input value to the one stored into the model. Also applies this behavior on escape key press and scroll for the before mentioned reasons. Steps to reproduce: - Go to CRM form view - Edit the salesperson name to some non existant one and click out (or scroll or press escape) Before the fix, the name was stuck to the invalid one but no change was detected so we couldnt save it. Before https://github.com/odoo/odoo/pull/159333, click out would select the active option of the dropdown instead (and launch a dialog for quick create). This is removed because the behavior is neither intuitive nor practical. After the fix, the name is reset to its previous valid value instead. This applies to all autocomplete components with autoselect prop set to true. Forward-Port-Of: odoo/odoo#162040 Forward-Port-Of: odoo/odoo#161251

## Problem Before this commit, adding a dropdown to a kanban view via `web_studio` didn't work. Steps: - Install `web_studio` - Install a module containing no dropdown on the kanban view (e.g. `sale_management`) - Modify the kanban view of this module on studio - Click on the 3 small dots on the kanban-card and add the dropdown - Confirm - Exit studio - Try changing the color of one of the kanban-cards via the newly added dropdown - Traceback ## Explanation Here's how adding a dropdown to the kanban view normally works in studio: Python: - Create a new `x_color` field in the model - Add this new field to the view in question - Add a dropdown containing `.oe_kanban_colorpicker` and a `data-field` containing `x_color`. - Change the attributes of the first element in the kanban-card to add a color="x_color". Javascript: If the color is changed, this code is triggered https://github.com/odoo/odoo/blob/0fcb34dd3ba3bbd7f422c627e27c96089b29b044/addons/web/static/src/views/kanban/kanban_record.js#L302-L306 which dynamically updates the `colorpicker` field with the new value via the value of arch `colorField`. Except that in our case `colorField` is `color` and not `x_color`. Then, as the `web_studio` python code adds a `color="x_color"` attribute, instead of `colorField` it's `cardColorField`. https://github.com/odoo/odoo/blob/3c356a40f7d6da5aff8a8e7f6ebb9ea8cc9b3861/addons/web/static/src/views/kanban/kanban_record.js#L266-L269 This code is obsolete because it adds `oe_kanban_color_X` to `o_kanban_record ` instead of adding it to its first child `oe_kanban_card`. So we have several problems: - Use of `cardColorField` instead of `colorField`. - Color style added to wrong HTML element - KanbanArchParser searches for the colorpicker's `data-field` only in `kanban-box`, whereas it is often (including in studio) put in `kanban-menu`. ## Commits ### Commit 1: [[FIX] web: Use kanban-menu template in arch kanban_arch_parser](https://github.com/odoo/odoo/pull/160483/commits/bb0cf9ef09ac29233b99b64077c9b31bcd4a04a0) This commit modifies the way kanban_arch_parser retrieves `colorField`. Previously, the parser tried to retrieve only `colorField` (the `data-field` attribute of `.oe_kanban_colorpicker`) from `kanban-box`. Except that in most cases `.oe_kanban_colorpicker` is defined in `kanban-menu` and not `kanban-box`. for example: https://github.com/odoo/odoo/blob/31107fb4cc9cf5dc2da21cbfef58dae722c73922/addons/crm/views/crm_lead_views.xml#L554-L559 https://github.com/odoo/odoo/blob/c6978c3fc4f828d970d45ebdaa4a35b44f3d09ce/addons/project/views/project_task_views.xml#L544-L550 https://github.com/odoo/odoo/blob/c6978c3fc4f828d970d45ebdaa4a35b44f3d09ce/addons/project_todo/views/project_task_views.xml#L28-L31 etc. As a result, this code was always ignored and we always fallback on `||"color"`. ```js const colorField = (colorEl && colorEl.getAttribute("data-field")) || "color"; ``` Now `KanbanArchParser` checks both `kanban-box` and `kanban-menu` and finally fallbacks to `color`. ### Commit 2: [Put kanban color classes in the right place](https://github.com/odoo/odoo/pull/160483/commits/73844cd42a389020bd4a7bd47ed48c4652fa7e4d) After this commit, `colorField` is used instead of `cardColorField` to handle color change from the dropdown of cards in the kanban view. The value of `colorField` is observed in order to adapt the HTML classes of `oe_kanban_card` (first `DIV` of `o_kanban_record`) by adding/removing `oe_kanban_color_X` (where X is an index representing a color). A commit has also been made in the enterprise section to remove unnecessary code from the `web_studio` controller, which before this pull request was used to add a color="x_color" attribute that we no longer use. https://github.com/odoo/enterprise/pull/60072 opw-3823860 Forward-Port-Of: odoo/odoo#161645 Forward-Port-Of: odoo/odoo#160483

If the "generic" routes (i.e., the ones created from the master data) are company-specific, the user won't be able to create a new comapny anymore. To reproduce the issue: 1. In Settings, enable "Multi-Step Routes" 2. Enable all companies 3. Inventory > Configuration > Rules: - For each Manufacture rule: - If its route does not have any company: - Set the route's company equal to the one of the rule 4. Create a new company Error: a Validation Error is raised: "Rule [...] (Production) belongs to \<new company\> while the route belongs to \<an existing company\>." Creating a company leads to the creation of the WH and its rules. At some point, we create/update the global rules. Let's look at the Manufacture one. We will provide all the required values for its creation: https://github.com/odoo/odoo/blob/270d8aa06bb37b4a01f01a7274062e3f88ca2a1c/addons/mrp/models/stock_warehouse.py#L112-L128 As you can see, for the `route_id` field, we try to find a global route. But here is the issue: in this `_find_global_route`, we will find the "generic" one thanks to the provided XML_ID. But, step 3, we set a company on that route. As a result, here, we try to create a rule for a company X linked to a route that belongs to a company Y, hence the validation error: https://github.com/odoo/odoo/blob/dc58d7913131f1f4dbeb0e3337e61e0b21f6f0d9/addons/stock/models/stock_rule.py#L107-L108 OPW-3790512 Forward-Port-Of: odoo/odoo#162189 Forward-Port-Of: odoo/odoo#161820

When users try to import a file into the ``FEC import`` and the file doesn't have the value of ``key``, an error occurs. This happens because the system requires the value of ``JournalCode`` to be present in the imported file for successful processing. Steps to reproduce: - Install ``l10n_fr_fec_import`` module - Change company from YourCompany to FR Company - Now Accounting -> Configuration -> Accounting -> Journals - Select all journals -> export all journals -> download file in CSV format. - Configuration -> Settings -> Accounting Import -> import -> Click on the ``Import FEC button`` - Upload a file that you have downloaded and Import Traceback: ``` AttributeError: 'NoneType' object has no attribute 'replace' File "odoo/http.py", line 2252, in __call__ response = request._serve_db() File "odoo/http.py", line 1828, in _serve_db return self._transactioning(_serve_ir_http, readonly=ro) File "odoo/http.py", line 1848, in _transactioning return service_model.retrying(func, env=self.env) File "odoo/service/model.py", line 134, in retrying result = func() File "odoo/http.py", line 1826, in _serve_ir_http return self._serve_ir_http(rule, args) File "odoo/http.py", line 1833, in _serve_ir_http response = self.dispatcher.dispatch(rule.endpoint, args) File "odoo/http.py", line 2058, in dispatch result = self.request.registry['ir.http']._dispatch(endpoint) File "odoo/addons/base/models/ir_http.py", line 222, in _dispatch result = endpoint(**request.params) File "odoo/http.py", line 740, in route_wrapper result = endpoint(self, *args, **params_ok) File "addons/web/controllers/dataset.py", line 42, in call_button action = self._call_kw(model, method, args, kwargs) File "addons/web/controllers/dataset.py", line 34, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "odoo/api.py", line 458, in call_kw result = getattr(recs, name)(*args, **kwargs) File "home/odoo/src/enterprise/saas-17.1/l10n_fr_fec_import/wizard/import_wizard.py", line 683, in action_import return self._import_files() File "home/odoo/src/enterprise/saas-17.1/l10n_fr_fec_import/wizard/import_wizard.py", line 729, in _import_files for xml_id, record in generator(rows, cache): File "home/odoo/src/enterprise/saas-17.1/l10n_fr_fec_import/wizard/import_wizard.py", line 193, in _generator_fec_account_journal journal_xml_id = self._make_xml_id('journal', journal_code) File "home/odoo/src/enterprise/saas-17.1/l10n_fr_fec_import/wizard/import_wizard.py", line 110, in _make_xml_id key = key.replace(' ', '_') ``` This commit resolves the mentioned issue by verifying if the key is present; otherwise, it will raise a UserError. sentry - 4929578488 Forward-Port-Of: odoo/enterprise#59997

Bug Fixes(3)

[FIX] portal: prevent error while country is not selected

[REV] web: blacklist customer statements menu in clickall

[FIX] account_followup: remove 'CREATE TEMP TABLE'

Other(39)

[FW][FIX] google_calendar: accepting recurrent event tests

Bug Fixes(3)

[FIX] portal: prevent error while country is not selected

[REV] web: blacklist customer statements menu in clickall

[FIX] account_followup: remove 'CREATE TEMP TABLE'

Other(39)

[FW][FIX] google_calendar: accepting recurrent event tests

[FW][I18N] sale_async_emails: add missing module translation

[FW][FIX] l10n_ar_withholding: Clean up WH Payment Type

[FW][FIX] sale_expense: Fix price_unit used in mapping key

[FW][FIX] test_mail_*: fix query counters tests and runbot builds

[FW][FIX] payment(_stripe): fix issues with the SEPA Direct Debit method

[FW][FIX] base: Fixed inversed currency rates in list view

[FW][IMP] l10n_it_edi: Adding negative bill test

[FW][FIX] tools: properly export all translated attributes

[FW][FIX] web, *: autocomplete cancels search on click out

[FW][FIX] web_editor: remove useless params when call IAP OLG

[FW][FIX] account_edi_ubl_cii: remove deprecated peppol eas

[FW][FIX] website: get env correctly on configurator_apply

[FW][FIX] web: Allow users to add dropdown-kanban via studio

[FW][FIX] stock: display packaging on delivery slip

[FW][FIX] base: bad logging argument in test_smtp_connection

[FW][FIX] stock,mrp: allow company creation with company-specific routes

[FW][FIX] http: force mimetype of .js files to text/javascript

[FW][FIX] portal: fix test that breaks without demo data

[FW][PERF] account: speed up dashboard

[FW][FIX] base: smtp_auth=certificate with SSL/TLS

[FW][FIX] mrp_account: fix BoM creation for non-accounting users

[FW][IMP] mail: prevent line break in systray activity

[FW][MERGE][IMP] appointment: improve performance on linked resources

[FW][FIX] account_followup: wrong template on automatic reminder

[FW][FIX] sale_subscription: fix batch_size on cron trigger

[FW][FIX] sale_subscription: allow to set to draft

[FW][FIX] test_mail_sms: fix query counters tests and failing runbot builds

[FW][FIX] website_studio: Allow users to create website form

[FW][FIX] appointment: add 'More Options' btn to open full form

[FW][IMP] account_3way_match: better xpath specificity

[FW][FIX] l10n_fr_fec_import: raise UserError if key not found

[FW][FIX] account_reports: the warnings arguments was always set to None in _compute_formula_batch_with_engine_custom

[FW][FIX] l10n_nl_reports: reduce XAF export's partner query's memory foo…

[FW][FIX] hr_contract_sign : fix signature request in tree view

[FW][FIX] web_studio: add action button with xml_id

[FW][FIX] l10n_cl_edi_pos: handle missing barcode during order validation

[FW][FIX] pos_iot: Prevent TypeError while uninstalling IoT for PoS

[FW][FIX] appointment: hide buttons when user lacks access