Original PR description

Current Behavior:
Tasks with or without dependent tasks and a state not in closed states have their state changed to `01_in_progress` when duplicated.

previous PR that changed this logic: #139249

Purpose of this PR:
To retain the state of the original task when duplicated.

Steps to Reproduce in Runbot:
1) Enable Task Dependencies in Settings
2) Create a Project with Task A
3) Set state of Task A to 'Approved'
4) Duplicate Task A > Task A will now have a state of 'In Progress'

Note:
This PR does not remove the changes of duplicating projects.
opw-3836251

Forward-Port-Of: odoo/odoo#161778

Original PR description

PR odoo/odoo#157918 has a bug on commit 8bd8d4a3eaf.
We cannot do `int(x) in Command` as it's TypeError.

Forward-Port-Of: odoo/odoo#162786

Original PR description

This commit add a new tax call VAT exemption, read more at https://taxsummaries.pwc.com/vietnam/corporate/other-taxes to understand its usage

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#161457

Original PR description

using sudo().is_kits to account for user not having access to the bom module and boms in different companies

Forward-Port-Of: odoo/odoo#161124

Original PR description

Issue:
Discounts are not displayed in DDT

Steps to reproduce:
- create a quotation with a sale line having a discount
- smart button delivery > set qty > validate
- Print

Ticket link: [odoo/task#3745866](https://www.odoo.com/web#model=project.task&id=3745866)
opw-3745866

Forward-Port-Of: odoo/odoo#162287
Forward-Port-Of: odoo/odoo#159325

Original PR description

task-3870118

--------------------

This PR aims to fix an issue on forum posts, about comments being
placed directly next to each other without having a gap between them,
making it harder to visually recognize items at first glance.

To handle this issue, we simply add a `d-flex gap-x` utility classes
to ensure these elements receive some spacing between them.

| 17.0 | 17.0-fix-forum-comment-spacing-chgo |
|--------|--------|
| <img alt="image" src="https://github.com/odoo/odoo/assets/128030743/a86dd9d7-37e4-4783-8d7f-73bdc6605edf"> | <img alt="image" src="https://github.com/odoo/odoo/assets/128030743/f253452a-3b52-499f-a7c2-4d3e102ab5a4"> |

Forward-Port-Of: odoo/odoo#155364

Original PR description

Previously, if a product had `price < list_price` and `price < compare_list_price`, but `website_sale.group_product_price_comparison` unset, no strikethrough price was shown. However, in that case, we should show `list_price` as the strikethrough price.

Previously, in the search dropdown, `compare_list_price` was only shown as the strikethrough price if `price < list_price` (which is unrelated). This change make it consistent with the product page.

opw-3845926

Forward-Port-Of: odoo/odoo#162611
Forward-Port-Of: odoo/odoo#161473

Original PR description

Since 17.0, the tag `apps` of ir.action.client was removed with the legacy code of javascript. This commit removes the only usage in `res.config.installer` (not used in standard) to avoid a traceback at install.

Fixes #160293

Forward-Port-Of: odoo/odoo#162228

Original PR description

While updating the checkout page an element was changed from div to t
To handle the intermediate value used by users who installed this version
a new selector was added to the xpath to account for both cases

Previous commit that was fixing the same issue 12e5296c1d4dbfe202ad2dcb2690c2e60828f6e1

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#162670
Forward-Port-Of: odoo/odoo#162064

Original PR description

Access rights on ir.attachment depend on the record it is linked to.

steps to reproduce:
- log as admin
- create a calendar event and invite marc demo
- log as marc demo
- check discuss notifications and try to download "invite.ics"

before this commit:
- file can not be downloaded from the webclient (access error appear in logs)

after this commit:
- file can be downloaded from the webclient

opw-3754798

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#162502
Forward-Port-Of: odoo/odoo#160811

Original PR description

Strings within inline templates are not translatable, so we convert these templates into standard templates so that they can be.

Task-3761551

Forward-Port-Of: odoo/odoo#162512
Forward-Port-Of: odoo/odoo#160238

Original PR description

Current behavior:
When entering a lot name that doesn't exist in the PoS, the lot is being created. But the lot is not being assigned to the stock move line.

Steps to reproduce:
- Create a product with tracking by lot
- Open PoS and make an order for this product
- Enter a lot name that doesn't exist
- Validate the order
- Close the session
- Go to the order picking in the inventory app
- The lot is not assigned to the stock move line

opw-3710125
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#160533

Original PR description

Description of the issue/feature this PR addresses:

After the portal redesign, messages for no quotations or sale orders were moved before the portal_table template, which is called when there are entries of quotations or sale orders. However, the previous version of the message for sale orders was left after the template call.

This commit removes the previous version of the message to avoid having duplicated messages.

Current behavior before PR:

Two similar messages are displayed in the portal when there are no sale orders.
- There are currently no sales orders for your account.
- There are currently no orders for your account.

Desired behavior after PR is merged:

Only one message is shown in the portal when there are no sale orders, as it happens for the quotations.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#162546

Original PR description

Current behavior:
If you create a user that only have access to a branch of a company. If this user try to access the QR Menu of any PoS he will get an access error.

Steps to reproduce:
- Create a branch B for company A
- Change access of user U to only have access to branch B
- Login with user U, and try to open any PoS QR Menu
- You get an access error

opw-3745256
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#162222

Original PR description

Before this commit an error appeared if a block had been set at the top
of the /blog page and the user wished to re-enable the
'Top banner - Name / Latest Post' option. This commit resolves the issue
by giving higher priority to the activated view.

Steps to reproduce the fixed bug:
- Go on /blog page
- Disable the customize option "Top banner - Name / Latest Post"
- Enter in edit mode
- Add a snippet to the top (in the oe_structure)
- Save the page
- Enable the customize option "Top banner - Name / Latest Post"

=> An error happens.

task-2774944

Forward-Port-Of: odoo/odoo#162519
Forward-Port-Of: odoo/odoo#92022

Original PR description

Description of the issue/feature this PR addresses:

In systems were POs can have multiple open pickings, updating the Purchase quantities can lead to errors due to the current behaviour.

Current behavior before PR:

Before the fix, the picking used to create the new stock moves resulting from changes in the purchased quantity is simply taking the first available picking of the Purchase. This causes problems when you handle Purchase Orders with multiple open pickings, as the correct picking to use when the quantity is updated is not always taken.

Desired behavior after PR is merged:

After the fix we give priority to evaluate open pickings already related to the line we are updating. We fallback to the same behaviour as before is none is available.



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#161452

Original PR description

Before this PR, trying to get an available operator could result in an
error.

When a live chat is created, an operator is selected based on various
criteria such as language, country, number of ongoing chats and
availability for calls. This selection process involves the
`_get_less_active_operator` method, which receives the status of all
operators and a list of operators to choose from.

Prior to this fix, an operator not included in the list of operators
to choose from could still be selected, resulting in errors when
trying to locate them in the operator list.

This PR resolves the issue by ensuring that operators are only
selected from the provided list.

opw-3874872

Forward-Port-Of: odoo/odoo#162357

Original PR description

How to reproduce:
1. Go to any course
2. Click on the button 'Add attendees'
3. Type the recipients name 

"Create and edit ..." should be displayed but is not.

To reenable this feature, we remove the option no_create_edit on partner_ids
of the slide_channel_invite_view_form form to enable the creation of partner
when adding attendee to a course.

As the support for the force_email context has been discontinued, we don't
reenable the quick_create as it can create partner without email (if the user
enter a non-valid email). But we reenable the "create edit" option with a view
that force the user to enter an email: base.view_partner_simple_form (like
done on some views in odoo/odoo#149806).

Task-3868824

Forward-Port-Of: odoo/odoo#162190

Original PR description

Product domains were not considered when computing the min amount to reach to get a discount. For
example, if you created a discount with a minimum amount of 100 for product "X", the discount
would have been applied, even if the amount for "X" was less than 100, as long as the total amount
of the SO was at least 100.

After this fix, only products that match the domain will be considered when computing the amount
that should be compared to the discount's min amount.

opw-3626345

Forward-Port-Of: odoo/odoo#162061
Forward-Port-Of: odoo/odoo#155085

Original PR description

Commit f0016849 added the module `sale_async_emails` but not the .pot file.

Forward-Port-Of: odoo/odoo#162330
Forward-Port-Of: odoo/odoo#162215

Original PR description

Prior to this commit, splitting an order would create a new order, causing it to appear again on the preparation display. This could lead to the kitchen preparing the same order twice. The sequence of events was as follows:

1. The order is placed.
2. The kitchen receives and prepares the order.
3. The waiter delivers the order to the table.
4. The client receives the bill and requests a split.

At the point of splitting, a new order is created. This duplicate order should not be sent to the kitchen as it represents a meal that has already been prepared and consumed. This commit resolves this issue by preventing display of duplicate orders to the kitchen during order splitting.

Enterprise PR: https://github.com/odoo/enterprise/pull/60537

opw-3809693

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#161498

Original PR description

Steps to reproduce:
-------------------
1. Install the resource module without demo data (or install any module which depends on it, again without demo data).
2. Login with the administrator user for the first time.
3. The default resource calendar (e.g. "Standard 40 hours/week") timezone will be set to 'UTC' by default while it should be set to the timezone of the administrator.

Fix:
-------------------
When there is no demo data, no resource_calendar_id is linked to the admin. In this case, we need to retrieve the record of the default working calendar and set its timezone to the one of the admin user on the first login.

This is a follow-up of this fix: https://github.com/odoo/odoo/pull/84258

task-3793313

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#157583

Original PR description

Description of the issue/feature this PR addresses:
Default employee ID send in request context, when adding a skill from My profile, is not the good one. That can lead to error (missing record, not access)

Steps:
- Login as "Mitchel Admin"
- Install hr_skills_survey
- Delete all employee except "Mitchel Admin"
- Open "My profile"
- Open "Resume"
- Add a skill

Actual result:
- Error due to missing employee
- default_employee_id is using the current record ID so a user ID
- default_employee_id is not the correct ID
- Can lead to record not existing error or access error

Expected result:
- No error
- default_employee_id is the correct employee of the user
- Default employee in dialog is "Mitchel Admin" or Empty but not another employee

opw-3852542

Forward-Port-Of: odoo/odoo#161948
Forward-Port-Of: odoo/odoo#161636

Original PR description

The sale_stock module patches the ProductCatalogKanbanRecord updateQuantity method to prevent the quantity to go under the delivered quantity of the product

The issue is that we are also using the ProductCatalogKanbanRecord in the industry_fsm_stock module we are also doing an override of the updateQuantity method to prevent the quantity of a product to go under the 'minimumQuantityOnProduct' which can be lower that the delivered quantity of a product in the case of a service product

## For account, sales and mrp

We just need to change a bit the inheritance of the `_get_product_catalog_order_data` method override so it takes the productType as well

Task-3689939

https://github.com/odoo/enterprise/pull/55455

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#161262
Forward-Port-Of: odoo/odoo#155157

Original PR description

In this commit:
===============
printer icon will visible based on printer configuration

task - 3869678

Forward-Port-Of: odoo/odoo#162056

Original PR description

Steps to reproduce:
- Install account_sepa_direct_debit
- Create another company
- Go to "Invoicing / Configuration / Accounting / Journals"
- Configure a journal (e.g. Bank) by adding an IBAN bank account number
- Go to "Invoicing / Customers / Direct Debit Mandates"
- Create a Direct Debit Mandate (DD Mandate):
  * Customer: [any customer with an IBAN bank account] (e.g. Gemini Furniture)
  * IBAN: [IBAN bank account of customer]
  * Journal: Bank
  * Start Date: [any]
  * Company: [the current company]
- Save and validate the DD mandate
- Switch to another company
- Open Direct Debit Mandate list view

Issue:
The DD mandate from the other company is displayed. Any user who has access to DD mandates will view the DD mandates from all companies, even those from the companies he has no access.

Cause:
There is no multi-company rule for "sdd.mandate" model.

opw-3769026

Forward-Port-Of: odoo/enterprise#59233

Original PR description

Issue:
------
If we remove the sale order line from a helpdesk ticket, and modify the partner (modify the `is_company` field), the sale order line will be added back to the ticket.

Solution:
---------
Assuming that this behaviour is due to a limitation in the ORM, it is necessary to modify the dependency of the compute method.

This fix performs the same correction on the helpdesk side as the commit: https://github.com/odoo/odoo/commit/5faf5a0dcf4c06716d6a29686d49409b22b05565

opw-3879079

Forward-Port-Of: odoo/enterprise#61125

Original PR description

Currently, when downloading/loading Worldline lib at the start of Odoo, after doing so we are restarting Odoo at the end of "load_worldline_library.sh" script.

This is unnecessary as Odoo is capable of detecting the terminals and communicating with them straight away when it has the library and the linker set up.

More annoyingly, this leads to a very tricky bug:
Odoo service is being restarted in a subshell.
Since Odoo is already running this 2nd service will be blocked, but as soon as the primary Odoo service stops, the 2nd one takes the lead.

So when restarting Odoo we can get error like "Adress already in use", duplicate code executed and even more dangerousely, duplicate C++/C code running with Worldline and Six, which can lead to race conditions and crashes.

task-3873045

Forward-Port-Of: odoo/enterprise#60865

Original PR description

As resources are bound to companies, we need to filter out the events we display so that only events with resources from valid companies are displayed in gantt.

task-3565337

Forward-Port-Of: odoo/enterprise#61039
Forward-Port-Of: odoo/enterprise#52771

Original PR description

This commit removes the unnecessary "-" (minus) that was mistakenly added before `inputs['ATTACH_SALARY'].name`. This addition was causing a traceback error.

task-3794116

Forward-Port-Of: odoo/enterprise#58566

Original PR description

This commit addresses a computed asset failure caused by the inclusion of 'web.editor.frontend.scss' in the 'sign' module manifest since [1] (OWL conversion). A scss variable added in 'fontawesome_overriden.scss' by a related community PR is used in 'web.editor.frontend.scss', leading to a crash during asset computation.
This file is now added in the manifest.

Related community PR:
- https://github.com/odoo/odoo/pull/161770

opw-3747848

[1]:https://github.com/odoo/enterprise/commit/5fa63a2f284fe93acc0c4d8dc12ee47646703247

Forward-Port-Of: odoo/enterprise#60922
Forward-Port-Of: odoo/enterprise#60894

Original PR description

Prior to this commit, splitting an order would create a new order, causing it to appear again on the preparation display. This could lead to the kitchen preparing the same order twice. The sequence of events was as follows:

1. The order is placed.
2. The kitchen receives and prepares the order.
3. The waiter delivers the order to the table.
4. The client receives the bill and requests a split.

At the point of splitting, a new order is created. This duplicate order should not be sent to the kitchen as it represents a meal that has already been prepared and consumed. This commit resolves this issue by preventing display of duplicate orders to the kitchen during order splitting.

Community PR: https://github.com/odoo/odoo/pull/161498

opw-3809693

Forward-Port-Of: odoo/enterprise#60537

Original PR description

## Description
Validating invoices that have a lot of lines that needs to be deferred is taking extremely long time. Most of the bottleneck is from `_generate_deferred_entries`. We've batched some of the ORM calls to avoid repetitive calls to slow methods in `account_move` like `create`, `__set__`, `_post`.

## Benchmark
Tested on a saas-16.4 DB: validating an invoice with deferred lines generating on average 12 periods per line

| Lines | Before (Timing / Queries)     | After (Timing / Queries) | % Speed up |
|-------|-------------------------------|--------------------------|------------|
| 50    | 1 min / 23216                 | 33.4 sec / 16713         | 44.3%      |
| 100   | 3 min / 46736                 | 1.3 min / 33557          | 56.7%      |
| 230   | 17.7 min (timed-out) / 111196 | 3.4 min / 79777          | 80.7%      |

## Reference
opw-3815242

Forward-Port-Of: odoo/enterprise#59448

Original PR description

Steps to reproduce:
-------------------
- create a product with: - recurring - prepaid - create task on order
- in the settings, enable "Recurring Tasks"
- add "Use Recurring Tasks" to the current user
- create a sale order with a recurring plan and the recurring product
- confirm the sale order --> the created task is recurring
- duplicate the sale order
- validate it with a portal user

Issue:
------
The task created is not recurring.
The two tasks should be recurrent because the sale order is the same. The user who confirms the sale order must not affect the status of the task.

Cause:
------
We check that the user belongs to the `group_project_recurring_tasks` group, which will never be the case for a portal user.

Solution:
---------
Authorise the creation of the recurring task if the setting is activated.

opw-3823250

Forward-Port-Of: odoo/enterprise#60807

Original PR description

The quantity_decreasable_sum of a service product no longer takes into account the delivered quantities
This is done so we can decrease service product quantity in the product catalog even tho those product are
considered delivered by default

https://github.com/odoo/odoo/pull/155157

Task-3689939

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/enterprise#60406
Forward-Port-Of: odoo/enterprise#55455

Original PR description

Before this commit, it was possible to cancel a renewed order. It was a mistake not occuring in 17.2 or 17.0.

Forward-Port-Of: odoo/enterprise#61141

Original PR description

In this commit:
==================
Invisible the 'Removal strategy' field when selecting the other location type except the Internal location.


task-3555853

Forward-Port-Of: odoo/odoo#157888
Forward-Port-Of: odoo/odoo#154117

Original PR description

Description of the issue/feature this PR addresses:
Without sudo, an user in a company can change the type even if somes not done stock.move.line exists.

@amoyaux 



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#160856