Daily updates from Odoo
Monday, April 22, 2024
7 changes
1 change
Resolved issues and error corrections
This change makes an internal Web Studio test more stable by avoiding a check that depended on unpredictable background request timing. It helps prevent false failures in automated testing without changing user-facing behavior.
Original PR description
The test edit "one2many form view (2 level) and check chatter allowed" was sometimes failing (https://runbot.odoo.com/runbot/build/61498073) This was due to the ordering of some rpc calls in two different services. Those services do not depend on one another, so it is possible that in some situations, their instanciation and the rpc they pass happen in different order. After this commit this is not a problem because we simply don't assert the rpc "/mail/action".
6 changes
Resolved issues and error corrections
Forum comments were appearing too close together, making them difficult to distinguish visually. This fix adds proper spacing between comments on forum posts, improving readability and the overall user experience when viewing discussions.
Original PR description
task-3870118 -------------------- This PR aims to fix an issue on forum posts, about comments being placed directly next to each other without having a gap between them, making it harder to visually recognize items at first glance. To handle this issue, we simply add a `d-flex gap-x` utility classes to ensure these elements receive some spacing between them. | 17.0 | 17.0-fix-forum-comment-spacing-chgo | |--------|--------| | <img alt="image" src="https://github.com/odoo/odoo/assets/128030743/a86dd9d7-37e4-4783-8d7f-73bdc6605edf"> | <img alt="image" src="https://github.com/odoo/odoo/assets/128030743/f253452a-3b52-499f-a7c2-4d3e102ab5a4"> |
This update removes a reference to an outdated app action feature that was removed in version 17.0. The change prevents installation errors in the configuration installer module, which was using this deprecated feature. This is a cleanup fix that ensures the system installs smoothly without encountering errors related to removed code.
Original PR description
Since 17.0, the tag `apps` of ir.action.client was removed with the legacy code of javascript. This commit removes the only usage in `res.config.installer` (not used in standard) to avoid a traceback at install. Fixes #160293
This update allows users to change the chart of accounts template even when using demo data. Previously, the system prevented these changes to maintain data safety. Now, demo mode users can freely switch chart templates without restrictions, making product demonstrations smoother and ensuring accounting tests run reliably regardless of when templates are loaded.
Original PR description
When in demo mode, we always want to be able to change the CoA * to remove friction when demoing: no need to be overly safe * to ensure that `test_all_l10n` always works even if we load a CoA in `<res.company>.create` Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#159488
This update prevents confusing error messages from appearing to users when they collaborate on editing documents in real-time. The errors were harmless technical issues that didn't affect the actual collaboration, but were being displayed to users. Now these errors are quietly logged instead, providing a cleaner user experience.
Original PR description
__Current behavior before commit:__ Sometimes the following tracebacks are popping up when an RTC connection is being established between two users trying to edit the same document. ```log…
__Current behavior before commit:__ Sometimes the following tracebacks are popping up when an RTC connection is being established between two users trying to edit the same document. ```log InvalidStateError: Failed to execute 'setLocalDescription' on 'RTCPeerConnection': Called in wrong signalingState: stable ``` ```log InvalidStateError: Failed to execute 'setRemoteDescription' on 'RTCPeerConnection': Called in wrong signalingState: stable ``` __Description of the fix:__ These errors are not blocking and don't impact the successful ensuing RTC connection. Thus, we can just catch the error and log it in the console instead of showing it to the user. __Steps to reproduce the issue (in 17):__ - Go to a knowledge article - Open a new tab and open the same article - On this new tab, quit the article and come back multiple times Eventually a traceback will appear on one of the tab. Note that this error seems to occur very randomly. It is similar to the one dealt by [this commit][1] and it is probably due to a similar cause i.e. a browser bug when the RTC connection is under stress. It is however possible to trigger it in a more consistent way by calling [_createClient][2] repeatedly. opw-3778272 [1]: https://github.com/odoo/odoo/pull/158861/commits/0eca324 [2]: https://github.com/odoo/odoo/blob/a1afcc8/addons/web_editor/static/src/js/wysiwyg/PeerToPeer.js#L374 Forward-Port-Of: odoo/odoo#161518
This update corrects an incorrect partner ID reference in the expense module's test file. The fix ensures that tests use the correct partner information, improving test reliability and accuracy for the HR Expense feature.
This update fixes an issue where user avatars appeared stretched or distorted when multiple people were editing content together. The fix ensures that avatars maintain their proper square shape regardless of the original image format uploaded by users, improving the visual appearance of the collaborative editing interface.
Original PR description
task-3877841 ------------------ This PR fixes an issue occurring in the `web_editor` when multiple users edit some content. Prior to this commit, the user avatar was not using any aspect-ratio rule, resulting in a stretch avatar if the uploaded image wasn't square. This commit fixes this issue by adding the `o_object_fit_cover` class to the image, ensuring a correct ratio no matter the format of the uploaded image. | 16.0 | 16.0-fix-editor-avatar-ratio-chgo | |--------|--------| | <img alt="image" src="https://github.com/odoo/odoo/assets/128030743/4de8281f-3469-4e29-b0fa-286f31483d5e"> | <img alt="image" src="https://github.com/odoo/odoo/assets/128030743/eeea593a-090c-4c97-bc07-4d89bbdfa67f"> | Forward-Port-Of: odoo/odoo#162743