Tuesday, April 23, 2024
4 changes · master
Resolved issues and error corrections
Opening the Subscription dashboard spreadsheet side panel could fail when a pivot measure used a Reference field. This fix lets the side panel handle those fields correctly, improving reliability for users editing spreadsheet dashboards.
Original PR description
Steps to reproduce the issue on a fresh runbot database: - open the Subscription dashboard in edit mode - Right click on cell "Data!B7" => boom The pivot `#11` measure is `order_reference` which is a Reference field. This type of field had no aggregator specified which crashes the side panel. Note: UI test added in the Enterprise branch. Task: 3869693 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Deleting a starred message no longer reduces the starred message count twice. This keeps the displayed counter accurate, helping users trust mailbox indicators and avoid confusion.
Original PR description
Before this PR, the starred counter was decremented twice when a starred message was deleted: once in the `remove` method and once in the `onUpdate` of the isEmpty field. This PR removes the decrement from the `remove` method.
An unused piece of mail message data was removed because it was no longer used anywhere in the system. This reduces unnecessary processing and keeps the messaging code cleaner without changing user-facing behavior.
Original PR description
`history_partner_ids` is never used anywhere, it's dead payload inside message_format.
Corrects subscription-related list settings so new entries are added in the expected place when lists span multiple pages. This reduces confusion and prevents records from appearing on the wrong page during editing.
Original PR description
The "editable" attribute in list views can be set to either "top" or "bottom". List views are rng validated, and no other value can be used. However, x2many list inside form views aren't validated, and a few of them have editable="1". This seems to work, but only partially: the list is editable indeed, but if the list is multi page, there'll be issues when adding records (they'll be added in the last page, not the current one). This commit thus fixes the few views with incorrect editable attribute. opw~3860903