Wednesday, April 24, 2024
6 changes · 17.0
Resolved issues and error corrections
This fixes unstable automated checks for Google Calendar recurring event acceptance by ensuring the correct attendee is verified every time. It helps keep the calendar integration validation reliable without changing user-facing behavior.
Original PR description
The `test_accepting_recurrent_event_*` tests make sure that accepting recurrent events on google side reflect in odoo. The test was failing because of the following: when retrieving the invited attendee, the test used `self.assertEqual(event.attendee_ids[1].state, expected_states[i])` assuming that organizer will be at index `0` and invited user at index `1`. However the list of `event.attendee_ids` is ordered by create_date. And we create both organizer and attendee with the same command at the same time: `partner_ids=[Command.set([self.organizer_user.partner_id.id, self.attendee_user.partner_id.id])]` So we might have organizer at index `1` and invited attendee at index `0`. This resulted in the indeterministic behavior of the test. To fix this issue: This commit changes how the invited attendee is retrieved, making sure that we always get the right attendee. fixes runbot-61527
Uploading a custom app package with incorrectly formatted manifest information will no longer trigger an unexpected error. The import process now checks the data format first, making the experience more reliable for users adding modules through Apps.
Original PR description
This traceback occurs when the user tries to upload a `zip file` through import module in apps with the wrong datatype (not list ) in the `manifest` data. To reproduce this issue: 1) create a `zip file` with the manifest data other than list 2) open apps with debugger mode on 3) upload this zip file through `import module` 4) A traceback occurs Error:- ``` TypeError: unsupported operand type(s) for +: 'set' and 'list' ``` https://github.com/odoo/odoo/blob/1882d8f89f760bd1ff8a2bf0ae798939402647a3/addons/base_import_module/models/ir_module.py#L228-L232 When the user defines manifest data with different datatype (other than list) it leads to the above traceback. After applying this commit will resolve this issue by checking the datatype before concatenation, which makes code more robust. sentry-5168971980
This update fixes a performance issue in the Appointment module's test suite where an extra database query was causing test failures in no-demo mode. The fix ensures the automated testing process runs smoothly without unnecessary database calls that could impact system performance.
Original PR description
A single additional query makes runbot break. runbot-62073 Forward-Port-Of: odoo/enterprise#61347
Fixed a test failure in the survey module related to duplicate session codes. When creating multiple surveys at once, each survey requires a unique session code. This fix ensures the test properly handles the uniqueness requirement, preventing test failures that could mask real issues.
Original PR description
Surveys cannot be created in batch without `session_code` because it must be unique across surveys. Technically, using a 5-digit codes makes it unlikely that a collision occurs with records created without explicit session_code (see Survey._get_default_session_code's iterative process). See runbot 55709 See also related runbot 25041 Task-3829536 Forward-Port-Of: odoo/odoo#159882
This fix resolves a test failure in the Manufacturing Accounting module that occurred when running tests without demo data. The test was unable to properly validate user access permissions because a required field wasn't visible. The fix enables the necessary product variant settings for the test user, ensuring the test runs successfully in all environments.
Original PR description
The test needs to set `product_id` field in order to check user's access. However, the field is not visible without enabling product variants, which makes the test fail in an environment with no demo data. This commit fixes the issue by adding the MRP manager to the 'product.group_product_variant' group. The issue was introduced in #162107 . Related build error: https://runbot.odoo.com/web#id=61998&cids=1&menu_id=405&action=573&model=runbot.build.error&view_type=form Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#162814
Miscellaneous changes
Coming from: https://github.com/odoo/odoo/issues/158439 Forward-Port-Of: odoo/odoo#159422
Original PR description
Coming from: https://github.com/odoo/odoo/issues/158439 Forward-Port-Of: odoo/odoo#159422