Wednesday, April 24, 2024
2 changes · saas-17.1
Resolved issues and error corrections
This fixes an internal web service connection issue affecting Spanish electronic tax reporting tests. The change restores expected behavior when selecting and adjusting the service endpoint, helping prevent failures in external SII integrations.
Original PR description
`l10n_es_edi_sii` requires `Client.bind` as well as `_binding_options` in the service returned by this `bind` call.
```py
serv = client.bind('siiService', service_name)
if company.l10n_es_edi_test_env and connection_vals.get('test_url'):
serv._binding_options['address'] = connection_vals['test_url']
```
Can be tested with a external l1On unit test,
tested only in nightly builds,
not by regular runbot builds / mergebot.
`--test-tags=external_l10n:TestEdiWebServices`
opw-3888257
opw-3888559
opw-3888155
opw-3890269
opw-3889683
Manual forward port of odoo/odoo#163119 to expedite the merge as quick as possible.Managers can now edit employee and manager feedback while creating an appraisal, before the record is saved. This removes an unnecessary blocker in the appraisal workflow and helps managers complete evaluations without extra steps.
Original PR description
Steps to reproduce: ------------------- - create an appraisal for an employee; - be the manager of the appraisal; Issue: ------ It is not possible to edit feedback before saving it. Cause: ------ The `accessible_employee_feedback` and `accessible_manager_feedback` fields are read only if `can_see_employee_publish` and `can_see_manager_publish` are equal to `False`. These two fields depend on the `_compute_buttons_display` method, which will test whether the employees linked to the user are in the appraisal managers. The following condition will never be true if the appraisal has not yet been saved: ```py user_employees in appraisal.manager_ids ``` This is because manager_ids will be a `NewId` recordset. Solution: --------- It is necessary to compare ids and not records directly because Model does not support equality between existed records in database and virtual records. opw-3869446