Odoo Changelog — 2024-04-25

Thursday, April 25, 2024

18 changes · master

Improvements(2)

Enhancements to existing features

[IMP] all: detect all uncommented invisible field

Enterprisemasterweb_map

This update documents hidden fields that still need to remain in system views and helps identify ones that are no longer necessary. It improves maintainability and reduces unused configuration without changing day-to-day user workflows.

Original PR description

Since https://github.com/odoo/odoo/pull/137031 the invisible fields are add automatically (invisible and readonly) if they are used by python expressions in views (invisible, required, readonly, context, domain...).

The mandatory invisible field must be commented just after the field tag. The comment must indicate what is the technical requirement to be present. The goal is to clean all views, improve the comprehention of the addons and remove dead code.

#views#cleanup#maintainability

[IMP] documents: improve activity button

PR #60523

Enterprisemasterdocuments

The Documents activity list now gives the “Request a Document” button the same hover styling as related activity actions. This creates a more consistent and polished experience for users managing document requests.

Original PR description

Give the "Request a Document" button of the activity list the same style on hover as the activity elements.

Task-3862008

#documents#activity#user interface

Refactoring(1)

Code cleanup and technical improvements

[REF] *: use hoot.click and hoot.drag in tours

PR #60855

Enterprisemasteraccount_accountantaccount_reportsdocuments_spreadsheethelpdeskhr_payrollknowledgemrp_workorderplanningsignstock_barcode_mrp_subcontractingweb_tour

This update modernizes how Odoo's automated product tours simulate clicks and drag-and-drop actions, making tests more consistent and easier to maintain. It also simplifies the testing helper API by removing rarely useful focus and blur actions, with no expected impact on day-to-day users.

Other(15)

Miscellaneous changes

[FW][FIX] account_reports: properly handle aggregation bounds referenced by cross_report expressions

PR #61450

Enterprisemaster

Original PR description

To reproduce:

- Create a report with just one line, with code line_1_1. Give it an aggregation expression, cross_report, with formula "line_2_1.balance"

- Create another report, containing a single line with code line_2_1. Give it two expressions: - One aggregation, with formula="14.0" (hardcoded fixed value), and subformula "if_other_expr_above(line_2_1.dudu, EUR(0))"

    - Another expression of any engine labelled 'dudu'

==> Try opening the first report; it loads forever.

This is because the bound expression is only searched in the expressions of the active report ; not in the expressions loaded from other reports. In our case, the aggregation needing the bound is from the second report, so the bound belongs to its report as well. The looping occurs because that value, since it's not present in the first report's evaluated data, is considered as not yet computed, and the computation is continuously delayed at the end of the treatment queue, causing it to never become empty.

Forward-Port-Of: odoo/enterprise#61334
Forward-Port-Of: odoo/enterprise#58339

Since https://github.com/odoo/odoo/pull/137031 the invisible fields are add automatically (invisible and readonly) if they are used by python expressions in views (invisible, required, readonly, context, domain...). The mandatory invisible field must be commented just after the field tag. The comment must indicate what is the technical requirement to be present. The goal is to clean all views, improve the comprehention of the addons and remove dead code.

To reproduce: - Create a report with just one line, with code line_1_1. Give it an aggregation expression, cross_report, with formula "line_2_1.balance" - Create another report, containing a single line with code line_2_1. Give it two expressions: - One aggregation, with formula="14.0" (hardcoded fixed value), and subformula "if_other_expr_above(line_2_1.dudu, EUR(0))" - Another expression of any engine labelled 'dudu' ==> Try opening the first report; it loads forever. This is because the bound expression is only searched in the expressions of the active report ; not in the expressions loaded from other reports. In our case, the aggregation needing the bound is from the second report, so the bound belongs to its report as well. The looping occurs because that value, since it's not present in the first report's evaluated data, is considered as not yet computed, and the computation is continuously delayed at the end of the treatment queue, causing it to never become empty. Forward-Port-Of: odoo/enterprise#61334 Forward-Port-Of: odoo/enterprise#58339

# Issue: The query for constructing the aged_payable accounting report takes too long to load. # Analysis: When a database has lots of companies, it's likely to have a huge number of rows in the account_partial_reconcile table. Currently, the entire account_partial_reconcile table is being iterated in the report generation, only to be filtered out later on in the query. This superfluous computation is extremely inefficient and it could be easily avoided by correctly using LATERAL JOIN syntax to make use of the filters applied later on. ![image](https://github.com/odoo/enterprise/assets/44981290/b5d8874c-f845-4483-b6d9-fcd96cccd91a) # Fix: Use the correct condition inside the lateral join to filter on account_move_lines that are already filtered later on. # Benchmark: ### Report loading time | # account partial reconcile lines | # account move lines | Company size | Before | After | | --- | ------ | ------ | ------| ----- | | 588503 | 2339215 | Large | 15m+ (timeout) | ~14.02s | | 5761 | 27635 | Medium | 15m+ (timeout) | ~3s | | 11 | 1513 | Small | 7.69 | ~1.6s | #### Total number of account partial reconcile: 3279438 #### Total number of account move lines: 10688953 # Related ticket: opw-3819017 Forward-Port-Of: odoo/enterprise#61036

This traceback occurs when the user tries to duplicate a follow-up level record. To reproduce this issue: 1) Install `Accounting` 2) Open `Accounting/configuration/follow-up levels` 3) Select any one record and try to `duplicate` it. Error:- ``` TypeError: argument of type 'NoneType' is not iterable ``` https://github.com/odoo/enterprise/blob/a1921fb9a27e5da3592dbc3d9c34e41776b6c8d4/account_followup/models/account_followup.py#L47-L51 When the user tries to duplicate any record, the default value is None, which leads to the above traceback as there is no fallback for default. Because of refactoring in [1] After applying this commit, the issue will be resolved by giving a fallback value. Additionally, an SQL unique name constraint was encountered when attempting to duplicate it because of [2], so this commit also fixed by adding 15 days to the `highest delay in that company + the record name`. Previously duplicating `several levels` at the same time leads to `days_uniq` constraint because of the same delay. This commit will allow duplication several levels at the same time by offsetting `highest existing delay + 15 arbitrary days`. [1] https://github.com/odoo/enterprise/commit/e27a20d2e9a909260f28b18b0643b8205470236b [2] https://github.com/odoo/enterprise/blob/278290dd220e7ca8d4b9909d1bc48a93ac14c0eb/account_followup/models/account_followup.py#L44 sentry-5134878308 Forward-Port-Of: odoo/enterprise#59961

Improvements(2)

[IMP] all: detect all uncommented invisible field

[IMP] documents: improve activity button

Refactoring(1)

[REF] *: use hoot.click and hoot.drag in tours

Other(15)

[FW][FIX] account_reports: properly handle aggregation bounds referenced by cross_report expressions

Improvements(2)

[IMP] all: detect all uncommented invisible field

[IMP] documents: improve activity button

Refactoring(1)

[REF] *: use hoot.click and hoot.drag in tours

Other(15)

[FW][FIX] account_reports: properly handle aggregation bounds referenced by cross_report expressions

[FW][FIX] timesheet_grid: removed the timer from all timesheets kanban view

[FW][FIX] spreadsheet_edition: reinsert list

[FW][FIX] website_delivery_sendcloud: use complete address for pick-up location

[FW][FIX] appointment: fix query counter in no-demo

[FW][FIX] appointment: try to make tests more deterministic

[FW][PERF] account_reports: Speed up aged payable report

[FW][FIX] maintenance_worksheet: link to correct module

[FW][FIX] l10n_be_hr_payroll: Update employment bonus to new 2024 system

[FW][FIX] sale_stock_renting: disable Rental route when it should

[FW][FIX] l10n_be_hr_payroll: Add amiante contribution to DmfA

[FW][FIX] hr_appraisal: determine whether the feedback is readonly

[FW][FIX] account_reports: Missing VAT on pdf exports

[FW][FIX] account_followup: fix traceback while duplicating the followup levels

[FW][FIX] documents_spreadsheet: correctly simulate a click