Steps to reproduce ================== - Install sale_project,industry_fsm,web_studio - Open quotation S00023 - Click on the Tasks stat button - Open studio - Go to views - Enable the gantt view => Unable to complete the operation: duplicate key value violates unique constraint "act_window_view_unique_mode_per_action" Cause of the issue ================== The [action record] already contains the gantt view, but it is replaced inside the python [action]. In [previous] version

Steps to reproduce
==================

- Install sale_project,industry_fsm,web_studio
- Open quotation S00023
- Click on the Tasks stat button
- Open studio
- Go to views
- Enable the gantt view

=> Unable to complete the operation: duplicate key value violates unique constraint "act_window_view_unique_mode_per_action"

Cause of the issue
==================

The [action record] already contains the gantt view, but it is replaced inside the python [action].

In [previous] version, the user was entering this condition and thus had no problem editing the views

Solution
========

Instead of replacing the entire action['views'], we can remap the view ids to the ones we want.

One side effect of this though is that the `gantt,activity,map` views will be available by default.

---

[action record]: https://github.com/odoo/enterprise/blob/1df090289f3c45c200d133734989a6d9a8073145/project_enterprise/views/project_task_views.xml#L227
[action]: https://github.com/odoo/odoo/blob/1a9302dc3a9b0d9323612c10e0f3a91300bb89fd/addons/sale_project/models/sale_order.py#L154
[previous]: https://github.com/odoo/odoo/blob/8dbcd3d955e7270fc26a6141e8fce751029e5a4b/addons/sale_project/models/sale_order.py#L133-L141

opw-3800071

Forward-Port-Of: odoo/odoo#163170

**Steps to reproduce:** - Install Contacts, Accounting and l10n_sa_edi - Switch to a Saudi Arabian company (e.g. SA Company) - Create a contact who is not in Saudi Arabia: * Address: [Complete address in United Arab Emirates] * VAT: [any] - Create an invoice: * Customer: [The created contact] * Product: [any] - Confirm the invoice - Process by ZATCA **Issue:** The following warning is returned: "The other Buyer ID (BT-46) must present in the tax invoice and associated debi

**Steps to reproduce:**
- Install Contacts, Accounting and l10n_sa_edi
- Switch to a Saudi Arabian company (e.g. SA Company)
- Create a contact who is not in Saudi Arabia:
  * Address: [Complete address in United Arab Emirates]
  * VAT: [any]
- Create an invoice:
  * Customer: [The created contact]
  * Product: [any]
- Confirm the invoice
- Process by ZATCA

**Issue:**
The following warning is returned:
"The other Buyer ID (BT-46) must present in the tax invoice and associated debit notes and credit notes (KSA-2, position 1 and 2 = 01), where the buyer VAT registration number or buyer group VAT registration number (BT-48) is not provided."

**Cause:**
"PartyIdentification" element is not set in the electronic invoice for customer because he doesn't have "l10n_sa_additional_identification_number" field set.
This field is only available for contacts living in Saudi Arabia.
For contacts who don't live in Saudi Arabia, "PartyIdentification" should be populate with their VAT number.

opw-3845645



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#162809

Steps to reproduce: - Install Accounting - Go to "Settings / Users & Companies / Companies" - Create a branch company (e.g. Branch Company) for a company (e.g. YourCompany) - Switch to Branch Company - Create a fiscal position Issue: It is not possible to select the taxes from the parent company in the tax mapping. opw-3850514 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#162872

Steps to reproduce:
- Install Accounting
- Go to "Settings / Users & Companies / Companies"
- Create a branch company (e.g. Branch Company) for a company (e.g. YourCompany)
- Switch to Branch Company
- Create a fiscal position

Issue:
It is not possible to select the taxes from the parent company in the tax mapping.

opw-3850514



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#162872

When the report is updated and `groupby` is updated, we might need to also update `user_groupby` if it was not compatible. Followup/fix of odoo/odoo@7d54c76aaee325449248fa698adb9e549c486ee For instance upgrading from before to after odoo/enterprise@d226977e19401f9d95b66991a69abebd466ee7e0 was an issue. Forward-Port-Of: odoo/odoo#163526

When the report is updated and `groupby` is updated, we might need to also update `user_groupby` if it was not compatible. Followup/fix of odoo/odoo@7d54c76aaee325449248fa698adb9e549c486ee

For instance upgrading from before to after
odoo/enterprise@d226977e19401f9d95b66991a69abebd466ee7e0 was an issue.

Forward-Port-Of: odoo/odoo#163526

In stock, you would print multiple times the same lot label. In this scenario, the rendering method get multiple times the same res_id as parameter. However, the code is loosing track of those duplicated ids before all streams are indexed by res_id. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#163362 Forward-Port-Of: odoo/odoo#157710

In stock, you would print multiple times the same lot label. In this scenario, the rendering method get multiple times the same res_id as parameter. However, the code is loosing track of those duplicated ids before all streams are indexed by res_id.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#163362
Forward-Port-Of: odoo/odoo#157710

Before, using a column group on the OSS report broke the layout, as each country line displayed more cells than it should, and they hence mismatched the column headers. This was due to bad management of the column groups: when there was more than one column group, the tax_sums variable contained more than one value, and we were then looping on each column for each tax sum to generate the columns of the country line, which was wrong, since options['columns'] already contained the columns of ea

Before, using a column group on the OSS report broke the layout, as each country line displayed more cells than it should, and they hence mismatched the column headers.

This was due to bad management of the column groups: when there was more than one column group, the tax_sums variable contained more than one value, and we were then looping on each column for each tax sum to generate the columns of the country line, which was wrong, since options['columns'] already contained the columns of each column group.

Forward-Port-Of: odoo/enterprise#61530

To Reproduce: ============= - create a service Product with **invoicing policy** based on milestones and **create on Order** a task in fsm - create Sale order with this product and confirm it - a task is created, mark the task as done (with the button 'Mark as Done') -> the delivered quantity of the sale order line is updated to 1 Problem: ======== - marking the task as done should not update the delivered quantity of the sale order line of product based on milestones Solution: ==

To Reproduce:
=============
- create a service Product with **invoicing policy** based on milestones and **create on Order** a task in fsm

- create Sale order with this product and confirm it
- a task is created, mark the task as done (with the button 'Mark as Done') -> the delivered quantity of the sale order line is updated to 1

Problem:
========
- marking the task as done should not update the delivered quantity of the sale order line of product based on milestones

Solution:
=========
add condition to check if the product invoicing policy is based on milestones before updating the delivered quantity of the sale order line as it will be done when the milestones are reached

opw-3850167

Forward-Port-Of: odoo/enterprise#61304

When generating VAT XML by posting a tax closing entry, the `<ns2:Comment>` tag in the ML is empty despite specifying a comment during the closing process. ### Steps to reproduce 1. Install `l10n_be_reports_post_wizard`. 2. Switch to a Belgian company. 3. Open the tax report. 4. Create a tax closing. 5. Post the tax closing, ensuring a comment is defined in the appearing wizard. 6. Review the generated XML file. Expected behavior: The `<ns2:Comment>` tag in the XML should display t

When generating VAT XML by posting a tax closing entry, the `<ns2:Comment>` tag in the ML is empty despite specifying a comment during the closing process.

### Steps to reproduce

1. Install `l10n_be_reports_post_wizard`.
2. Switch to a Belgian company.
3. Open the tax report.
4. Create a tax closing.
5. Post the tax closing, ensuring a comment is defined in the appearing wizard.
6. Review the generated XML file.

Expected behavior: The `<ns2:Comment>` tag in the XML should display the comment entered during the tax closing.

Actual behavior: The `<ns2:Comment>` tag is found to be empty.

opw-3859928

Forward-Port-Of: odoo/enterprise#60917