Monday, May 6, 2024
5 changes · 17.0
Resolved issues and error corrections
Scrap stock transfers can now be validated without incorrectly prompting users to create a backorder. This prevents unnecessary workflow interruptions when disposing of inventory and keeps scrap operations aligned with the quantities entered.
Original PR description
**Steps to reproduce the bug:**
- Create a storable product “P1” and update its quantity to 10.
- Create a picking:
- Source location: Wh/Stock
- Destination location: Virtual Locations/Scrap
- Product: 10 units of P1.
- Mark as to-do.
- Try to validate the picking.
**Problem:**
A wizard asking to create a backorder is triggered. This occurs because when validating the picking, we check if all the moves are picked and the quantity is set. However, for the scrap moves that are ignored, we'll consider the move as not picked and no quantity done is set, hence the creation of a backorder is proposed.
**Solution:**
For the scrap moves, ignore the check of "picked" but check if a quantity done is set when validating the picking.
opw-3900082This update adjusts automated tests in the Project Sales Subscription module to align with recent changes made in the community version. The test modifications ensure that quality checks continue to pass and the module functions correctly with the latest codebase updates.
Original PR description
This commit adapt test case according to changes in community branch. opw-3853815
This update fixes incorrect Vietnamese translations in the website and HR recruitment modules. The corrections ensure that users in Vietnam see accurate and proper translations of key terms and phrases throughout these applications.
Original PR description
Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Code cleanup and technical improvements
This update removes a leftover initialization file from the l10n_generic_coa module, which was already removed in version 17.0. The file appears to have been accidentally left behind and is no longer needed. This cleanup helps keep the codebase organized and prevents confusion about which modules are actually active.
Original PR description
Description of the issue/feature this PR addresses: The module l10n_generic_coa was removed from version 17.0 but the __init__.py file is still there. I am not sure if this file is necessary or not, maybe for migration, but it looks like a mistake leaving it. Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Problem: When processing a purchase order (PO) with a negative quantity for a product, the system encounters errors during the validating of outgoing shipments. This occurs because the negative quantity is not handled correctly within the PO processing workflow. Steps to reproduce: In Product Category: Inventory Valuation should be Automated. The product should have enough quantity on hand. Set up the testing environment with the necessary modules, including "Purchase", "Inventory", "Accou
Original PR description
Problem: When processing a purchase order (PO) with a negative quantity for a product, the system encounters errors during the validating of outgoing shipments. This occurs because the negative…
Problem: When processing a purchase order (PO) with a negative quantity for a product, the system encounters errors during the validating of outgoing shipments. This occurs because the negative quantity is not handled correctly within the PO processing workflow. Steps to reproduce: In Product Category: Inventory Valuation should be Automated. The product should have enough quantity on hand. Set up the testing environment with the necessary modules, including "Purchase", "Inventory", "Accounting" and “purchase_stock”. Create a purchase order with a negative quantity for a product. Confirm the purchase order. It will create an outgoing shipment and try to validate the shipment. It will raise the error “Division By Zero” Cause: The issue arises due to the lack of proper handling for negative quantities in the purchase order processing logic. When a negative quantity is encountered, it disrupts the flow while calculating the price difference from the return move. Here shipment is not a return. Solution: Implemented a fix to properly handle negative product quantities during purchase order processing. This fix ensures that outgoing shipments are created correctly and in the valuation, it will ensure that we should have at least one return move to process the stock_in account with price difference. Please find the video link here : [Reproducing the issue](https://drive.google.com/file/d/1RrjPZWVrdH4FoBX7QR3qFVQWrbCRO4qc/view?usp=sharing) Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#164288 Forward-Port-Of: odoo/odoo#164098