Wednesday, May 15, 2024
6 changes · 17.0
Resolved issues and error corrections
This update fixes failing tests in the Dutch tax reporting module (l10n_nl_reports_sbr_icp). The issue was caused by an outdated reference that wasn't properly updated during a code migration. By correcting this reference and adding the necessary tag, the tests can now run properly without being blocked.
Original PR description
Changed the chart_template_ref that wasn't adapted for a fw-port. Also added the tag, so the test's requests are not blocked in 17+ runbot-64732 runbot-62320 Forward-Port-Of: odoo/enterprise#62375
This fix corrects where the automatic deletion rule was applied in the HR contract documents module. The ondelete setting was incorrectly placed in one model and has been moved to the correct location, ensuring data is properly managed when records are deleted.
Original PR description
The ondelete was not in the right model. task-3928257
A faulty test in the Google Calendar module has been removed. This test was incorrectly assuming that event organizers would always appear in a specific position in the attendees list, which caused unreliable test results. Removing this test improves the reliability of the Google Calendar synchronization testing.
Original PR description
This commit removes the dead and undeterministic test added by mistake after an unsucessful merge. This test assumes that the organizer of the event might always be on the position 0 of the attendees list but it is not always the case. Issue from: odoo/odoo#164408 Forward-Port-Of: odoo/odoo#165346
This update fixes an issue where automated tests for the Spanish EDI TBAI module were being skipped during testing. The tests were missing a required configuration tag that tells the system to run them. This ensures the module's functionality is properly validated.
Original PR description
The class doesn't have the post_install tag, and so, is skipped. runbot-25903 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165240
Miscellaneous changes
"Cannot unreserve more than you have in stock" Error. Prior to this fix, one could edit and change the uom on the stock move line after reservations were done for an MO. Therefore you could theoretically reserve 10 grams on the MO, go to the stock move line in mobile version and change the UOM to kg - reserving 10kg. This creates a missmatch in the reservation and triggers the unreserve error. This fix blocks the user from doing so if there are already reserved quantities on the move line.
Original PR description
"Cannot unreserve more than you have in stock" Error. Prior to this fix, one could edit and change the uom on the stock move line after reservations were done for an MO. Therefore you could theoretically reserve 10 grams on the MO, go to the stock move line in mobile version and change the UOM to kg - reserving 10kg. This creates a missmatch in the reservation and triggers the unreserve error. This fix blocks the user from doing so if there are already reserved quantities on the move line. OPW-3747596 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165078 Forward-Port-Of: odoo/odoo#159444
after this pr: https://github.com/odoo/odoo/pull/164196 It will create inconsistency during upgrade specially when we are upgrade from 15.0 to 17.0 or 16.0 to 17.0 because when it's try to compute `qty_available`, it's call `_compute_quantities_dict`, on that function, to find quant domain, using `get_domain_location` and on that function will find those warehouses which has `company_id = self.env.companies.ids` and then related virtual location of that warehouses. but in 15.0 and 16.0
Original PR description
after this pr: https://github.com/odoo/odoo/pull/164196 It will create inconsistency during upgrade specially when we are upgrade from 15.0 to 17.0 or 16.0 to 17.0 because when it's try to compute…
after this pr:
https://github.com/odoo/odoo/pull/164196
It will create inconsistency during upgrade
specially when we are upgrade from 15.0 to 17.0
or 16.0 to 17.0 because when it's try to compute
`qty_available`, it's call `_compute_quantities_dict`,
on that function, to find quant domain, using `get_domain_location`
and on that function will find those warehouses which has
`company_id = self.env.companies.ids` and then related
virtual location of that warehouses. but in 15.0 and 16.0
wil find all the warehouses as that code does
not exist in 15.0 and 16.0 so it will find
all the warehouses's virtual location before upgrade
and that will raise exception.
```
Traceback (most recent call last):
File "/tmp/tmpshmnsol1/migrations/testing.py", line 211, in test_check
self.check(value)
File "/tmp/tmpshmnsol1/migrations/stock/tests/test_on_hand_quantity.py", line 58, in check
self.assertEqual(before_results, self.convert_check(after_results), self.message)
AssertionError: Lists differ: [[2, [59 chars]24, '5'], [25, '3'], [26, '4'], [33, '1'], [34[21202 chars]37']] != [[2, [59 chars]24, '4'], [25, '3'], [26, '4'], [33, '1'], [34[6923 chars]'3']]
First differing element 6:
[24, '5']
[24, '4']
```
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#165261