Daily updates from Odoo
Thursday, May 16, 2024
25 changes · master
Enhancements to existing features
The Appointment app now supports checking whether calendar integrations are synchronized, helping the calendar controls work correctly. The appointment calendar header was also adjusted so sharing availability and synchronization buttons fit together better.
Original PR description
This commit adds the route for checking the synchronization status of calendar integration modules in order to fix the current QUnit tests. related: odoo/odoo#150186 task-3570379
When an approval request is created, the person who owns the related record is automatically added as a follower. This helps ensure the owner stays informed and receives notifications about the approval process without manual setup.
Original PR description
When an approval request is created, the owner of the record is added as a follower of the approval request. This way, the owner will receive notifications about the approval request. task-3672542
Resolved issues and error corrections
The Bank Reconciliation message link to the General Ledger now carries over the user's selected settings, such as the reporting date. This helps users compare balances using the intended context and avoids confusion from mismatched report views.
Original PR description
When clicking on the "General Ledger" part of the "The current balance in the General Ledger didn't match the balance of your last bank statement, leading to an unexplained difference of [...]" message in Bank Reconciliation, settings such as the date weren't properly transferred. task-3928454
The Request Signature action now appears only on records that support chatter-based tracking. This prevents users from seeing the option in unsuitable places where signature requests could not be properly followed up.
Original PR description
Before this commit: The action of "Request Signature" was shown in weird records accross Odoo. The idea was to allow adding it in records like tasks, documents, but it is being shown in records that do not have the chatter available to track the signature requests. This commit aims to fix the issue by adding a new condition for displaying that action, that is: check if `message_ids` is present on the view fields. since `message_ids` should be available only in chatter. Task: 3861299
This update fixes an internal Planning test setup so it no longer depends on optional demo data. It helps keep automated checks reliable across different database configurations without changing the user-facing Planning experience.
Original PR description
Before this commit, the #55625 altered the planning_tests_tours to change Aaron into Mitchell Admin for the resource assigned to the shift created inside that tour. The problem is `Mitchell Admin` is a demo data and so, the tour will create a new resource when we have no demo data inside our DB. If the changes made by this PR in that tour are reverted then another error is raised due to a timezone mismatch. This commit reverts the changes made by #55625 inside planning_tests_tours and change the timezone of `Aaron` resource created inside the python test.
The spreadsheet edition now uses the current search icon reference after an older find-and-replace icon name was removed. This prevents the global filters area from pointing to an outdated icon and helps keep the interface displaying correctly.
Original PR description
Since https://github.com/odoo/odoo/commit/554fe45c5f9c4103a126c080d030adce2e6dc871, FIND_AND_REPLACE does not exist anymore and has been replaced by SEARCH.
A planning test was updated to choose the intended button more reliably. This prevents test interference from the tour recorder and helps keep planning quality checks stable.
Original PR description
Before this commit, the selector for a button was not enough precise and with the tour recorder showing everywhere, the selector was selecting the recorder button instead of the right button. After this commit, the selector is more precise and should only select the right button. task-id: 3927002
Features or functions removed from Odoo
An outdated internal method was removed from the HR contract document integration because its responsibility had already been moved elsewhere. This keeps the module cleaner and reduces maintenance risk without changing day-to-day user workflows.
Original PR description
remove the _unlink_except_contract_signature_tag method from the hr.contract model. The method was moved in this commit: https://github.com/odoo/enterprise/commit/c4b1be7a4af975f0f90490dd31647e3f4cd144da (task-id 3928257) And the method was introduce in this commit: https://github.com/odoo/enterprise/commit/03775ae721c139839dfaf12358e87e02041d3359 (task-id 3695553) task-3928257
Miscellaneous changes
When taking a new car, the write on the controller did not update the employer cost properly in case the applicant or employee took extra holidays, to fix this we write the _get_benefit_values_wishlist_car_total_depreciated_cost with it's intended use Forward-Port-Of: odoo/enterprise#62538
Original PR description
When taking a new car, the write on the controller did not update the employer cost properly in case the applicant or employee took extra holidays, to fix this we write the _get_benefit_values_wishlist_car_total_depreciated_cost with it's intended use Forward-Port-Of: odoo/enterprise#62538
Previously the router did not touch the history state when mounting the webclient if the urls were identical, but now it will instead replace the state. Some asserts have been adapted to reflect this behavior. Community: https://github.com/odoo/odoo/pull/160525 Forward-Port-Of: odoo/enterprise#60741
Original PR description
Previously the router did not touch the history state when mounting the webclient if the urls were identical, but now it will instead replace the state. Some asserts have been adapted to reflect this behavior. Community: https://github.com/odoo/odoo/pull/160525 Forward-Port-Of: odoo/enterprise#60741
The definition on the dashboard was wrong since its creation but the error was only highlighted since https://github.com/odoo/odoo/pull/154370. Task-3911582 Forward-Port-Of: odoo/enterprise#62365
Original PR description
The definition on the dashboard was wrong since its creation but the error was only highlighted since https://github.com/odoo/odoo/pull/154370. Task-3911582 Forward-Port-Of: odoo/enterprise#62365
Order changes are sent to the preparation display before printing the receipt. This slows down the workflow as users have to wait for other requests to finish before the receipt is printed when a preparation display is connected. opw-3756416 Forward-Port-Of: odoo/enterprise#62008 Forward-Port-Of: odoo/enterprise#60441
Original PR description
Order changes are sent to the preparation display before printing the receipt. This slows down the workflow as users have to wait for other requests to finish before the receipt is printed when a preparation display is connected. opw-3756416 Forward-Port-Of: odoo/enterprise#62008 Forward-Port-Of: odoo/enterprise#60441
The record `documents_hr_contract.documents_hr_documents_contracts` has `forcecreate=1` and there is a chain of dependency of these 3 records: 1. `documents_hr_contract.documents_hr_documents_contracts` [--> 2.](https://github.com/odoo/enterprise/blob/17.0/documents_hr_contract/data/documents_tag_data.xml#L12) 2. `documents_hr.documents_hr_documents` [--> 3.](https://github.com/odoo/enterprise/blob/17.0/documents_hr/data/documents_facet_data.xml#L7) 3. `docum
Original PR description
The record `documents_hr_contract.documents_hr_documents_contracts` has `forcecreate=1` and there is a chain of dependency of these 3 records: 1.…
The record `documents_hr_contract.documents_hr_documents_contracts` has `forcecreate=1` and there is a chain of dependency of these 3 records:
1. `documents_hr_contract.documents_hr_documents_contracts` [--> 2.](https://github.com/odoo/enterprise/blob/17.0/documents_hr_contract/data/documents_tag_data.xml#L12)
2. `documents_hr.documents_hr_documents` [--> 3.](https://github.com/odoo/enterprise/blob/17.0/documents_hr/data/documents_facet_data.xml#L7)
3. `documents_hr.documents_hr_folder`
But for the latter 2 records **forcecreate=0**. All of these records are set `noupdate=1`. That is why during upgrade the latter 2 records will be skipped from creation if they are missing in db, but it will try to create the 1st one because of that forcecrete=1. This will cause dependency issue if the db is missing the other 2 records.
For solving the issue we set `forcecreate=1` to the latter 2 records.
**Steps to reproduce:**
1. Install modules documents_hr, documents_hr_contract in version `16.0`
2. Delete the document facet `documents_hr.documents_hr_documents`
3. Delete the document folder `documents_hr.documents_hr_folder`
4. Try to upgrade to `17.0`
You will see similar traceback to this:
```
Traceback (most recent call last):
File "/home/odoo/src/odoo/17.0/odoo/modules/registry.py", line 113, in new
odoo.modules.load_modules(registry, force_demo, status, update_module)
...
...
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 693, in convert_xml_import
obj.parse(doc.getroot())
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 613, in parse
self._tag_root(de)
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 556, in _tag_root
f(rec)
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 569, in _tag_root
raise ParseError('while parsing %s:%s, somewhere inside\n%s' % (
odoo.tools.convert.ParseError: while parsing /home/odoo/src/enterprise/17.0/documents_hr_contract/data/documents_tag_data.xml:10, somewhere inside
<record id="document_tag_signature_request" model="documents.tag" forcecreate="1">
<field name="name">Signature Request</field>
<field name="facet_id" ref="documents_hr.documents_hr_documents"/>
<field name="sequence">15</field>
</record>
```
Forward-Port-Of: odoo/enterprise#62464…oiced Before this commit, salespersons could churn a contract that has not been invoiced. It would impact the churn statistics. If the invoice has never been created, a cancelation is more correct. taskid 3925539 Forward-Port-Of: odoo/enterprise#62382
Original PR description
…oiced Before this commit, salespersons could churn a contract that has not been invoiced. It would impact the churn statistics. If the invoice has never been created, a cancelation is more correct. taskid 3925539 Forward-Port-Of: odoo/enterprise#62382
data_merge company dependent fields were always written on res.partner and not their correct model. Forward-Port-Of: odoo/enterprise#61929
Original PR description
data_merge company dependent fields were always written on res.partner and not their correct model. Forward-Port-Of: odoo/enterprise#61929
1. VMT_1 tag should report the currency rate instead of the invoice untaxed amount 2. CDE_2 tag should be limited to a max of 30 characters Related: https://github.com/odoo/odoo/pull/148953 and https://github.com/odoo/enterprise/pull/54086 task-3925896 Forward-Port-Of: odoo/enterprise#62512
Original PR description
1. VMT_1 tag should report the currency rate instead of the invoice untaxed amount 2. CDE_2 tag should be limited to a max of 30 characters Related: https://github.com/odoo/odoo/pull/148953 and https://github.com/odoo/enterprise/pull/54086 task-3925896 Forward-Port-Of: odoo/enterprise#62512
Fix for regressions introduced by https://github.com/odoo/enterprise/pull/58690 Forward-Port-Of: odoo/enterprise#61973 Forward-Port-Of: odoo/enterprise#61025
Original PR description
Fix for regressions introduced by https://github.com/odoo/enterprise/pull/58690 Forward-Port-Of: odoo/enterprise#61973 Forward-Port-Of: odoo/enterprise#61025
Since commit 911886b20ac632a34ab1cfa2c2e22d60d16173ac, any analytic plan that is mandatory for miscellaneous entries is also required for all lines in the bank reconciliation. However, we currently do not allow setting analytic accounts on liquidity lines (the field is not displayed). opw-3905713 Forward-Port-Of: odoo/enterprise#62182
Original PR description
Since commit 911886b20ac632a34ab1cfa2c2e22d60d16173ac, any analytic plan that is mandatory for miscellaneous entries is also required for all lines in the bank reconciliation. However, we currently do not allow setting analytic accounts on liquidity lines (the field is not displayed). opw-3905713 Forward-Port-Of: odoo/enterprise#62182
The ondelete was not in the right model. task-3928257 Forward-Port-Of: odoo/enterprise#62466
Original PR description
The ondelete was not in the right model. task-3928257 Forward-Port-Of: odoo/enterprise#62466
Steps to reproduce: - Create a QC of type operation - Set it on reciepts Bug: you are able to validate reciepts without passing the QC Fix: use the same logic as in "check_quality" opw-3839794 Forward-Port-Of: odoo/enterprise#62498 Forward-Port-Of: odoo/enterprise#62259
Original PR description
Steps to reproduce: - Create a QC of type operation - Set it on reciepts Bug: you are able to validate reciepts without passing the QC Fix: use the same logic as in "check_quality" opw-3839794 Forward-Port-Of: odoo/enterprise#62498 Forward-Port-Of: odoo/enterprise#62259
When zooming in on the gantt view, the gantt header slots could be badly displayed with an observed decalage with the grid cells. We fix that problem by making the gantt header be a grid and putting grid coordinates to some of its children. opw-3850750 Forward-Port-Of: odoo/enterprise#62079 Forward-Port-Of: odoo/enterprise#61849
Original PR description
When zooming in on the gantt view, the gantt header slots could be badly displayed with an observed decalage with the grid cells. We fix that problem by making the gantt header be a grid and putting grid coordinates to some of its children. opw-3850750 Forward-Port-Of: odoo/enterprise#62079 Forward-Port-Of: odoo/enterprise#61849
[REM] account: remove validation on bills ref Remove validation on bills ref and allow users to have multiple bills with same ref Reason: improve user experience with the system as it's a pain for them in a real life senario Task-3869240 odoo-pr: https://github.com/odoo/odoo/pull/161995 Forward-Port-Of: odoo/enterprise#62486 Forward-Port-Of: odoo/enterprise#62395
Original PR description
[REM] account: remove validation on bills ref Remove validation on bills ref and allow users to have multiple bills with same ref Reason: improve user experience with the system as it's a pain for them in a real life senario Task-3869240 odoo-pr: https://github.com/odoo/odoo/pull/161995 Forward-Port-Of: odoo/enterprise#62486 Forward-Port-Of: odoo/enterprise#62395
Invoking `_get_spreadsheet_snapshot` with `bin_size=True` in the context crashes if the spreadsheet has been snaphotted. That's because we are trying to json parse the human readable size version of the field '10.5 ko', which is obviously not a valid json. Since a055dfeb84abc, the computed field `current_revision_uuid` is in the view (which always has `bin_size=True`). And the compute method calls `_get_spreadsheet_snapshot` Task: 3899662 Forward-Port-Of: odoo/enterprise#62176
Original PR description
Invoking `_get_spreadsheet_snapshot` with `bin_size=True` in the context crashes if the spreadsheet has been snaphotted. That's because we are trying to json parse the human readable size version of the field '10.5 ko', which is obviously not a valid json. Since a055dfeb84abc, the computed field `current_revision_uuid` is in the view (which always has `bin_size=True`). And the compute method calls `_get_spreadsheet_snapshot` Task: 3899662 Forward-Port-Of: odoo/enterprise#62176
When producing all the products of a MO, the quality check error is raised before the serial number autocomplete wizard is shown. This should be the opposite. task-id: 3821092 Forward-Port-Of: odoo/enterprise#59382
Original PR description
When producing all the products of a MO, the quality check error is raised before the serial number autocomplete wizard is shown. This should be the opposite. task-id: 3821092 Forward-Port-Of: odoo/enterprise#59382
Sometimes companies might not have a vat number. In this case they are often prevented from exporting a report. They've been using a workaround by enterping '-' or '/' but that prevents from easily setting proper default values elsewhere, for example in l10n_lu_reports. mentioned in opw-3802589 Forward-Port-Of: odoo/enterprise#62410 Forward-Port-Of: odoo/enterprise#62391
Original PR description
Sometimes companies might not have a vat number. In this case they are often prevented from exporting a report. They've been using a workaround by enterping '-' or '/' but that prevents from easily setting proper default values elsewhere, for example in l10n_lu_reports. mentioned in opw-3802589 Forward-Port-Of: odoo/enterprise#62410 Forward-Port-Of: odoo/enterprise#62391