Thursday, May 16, 2024
34 changes · saas-17.2
Resolved issues and error corrections
A configuration issue in the Manufacturing dashboard was corrected so the dashboard definition is valid. This helps ensure the dashboard loads and behaves reliably after stricter checks exposed the existing problem.
Original PR description
The definition on the dashboard was wrong since its creation but the error was only highlighted since https://github.com/odoo/odoo/pull/154370. Task-3911582
This update adjusts an internal enterprise webclient test to match a recent change in how browser navigation history is handled. It helps keep automated checks reliable and does not change day-to-day user behavior.
Original PR description
Previously the router did not touch the history state when mounting the webclient if the urls were identical, but now it will instead replace the state. Some asserts have been adapted to reflect this behavior. Community: https://github.com/odoo/odoo/pull/160525
Spreadsheet formula suggestions now include the required date grouping, such as day or month, when users insert pivot data. This prevents formulas from failing because a suggested date field was missing its granularity.
Original PR description
Steps to reproduce:
- Go to CRM lead pivot view
- group by any date field by day
- insert in spreadsheet
- start typing '=odoo.pivot(1, <measure>, '
=> Currently, when the auto-complete proposes a date field (e.g. "create_date"), the field is proposed without the granularity ("create_date", not "create_date:month").
The formula result is an error if the granularity is missing.
Task: 3823433Miscellaneous changes
Since 9th April, there is a new currency in Zimbabwe, ZiG, created to tackle high inflation. The commit Adds the new ZiG currency, keeping the old ZWL currency record. task-3899063 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#164137
Original PR description
Since 9th April, there is a new currency in Zimbabwe, ZiG, created to tackle high inflation. The commit Adds the new ZiG currency, keeping the old ZWL currency record. task-3899063 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#164137
Prior to this commit, the addItem function had a time complexity of O(n), which resulted in lengthy data load times when dealing with numerous records. This commit optimizes the function by utilizing a set, thereby reducing the time complexity to O(1) and significantly improving performance. opw-3923668 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165451
Original PR description
Prior to this commit, the addItem function had a time complexity of O(n), which resulted in lengthy data load times when dealing with numerous records. This commit optimizes the function by utilizing a set, thereby reducing the time complexity to O(1) and significantly improving performance. opw-3923668 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165451
task-3927949 closes #165322 ------------------ This PR fixes an issue about the sample videos for Vimeo not being displayed anymore due to their private parameter. This PR introduces new samples that will be displayed correctly, allowing the user to really see what he can expect by selecting this option. | 15.0 | 15.0-fix-vimeo-sample-videos-chgo | |--------|--------| |  |  |  | Forward-Port-Of: odoo/odoo#165417
### [[FIX] mail_group: allow selected group of users while not members](https://github.com/odoo/odoo/pull/157590/commits/a25190e30ad732ab5057e85fcd4f34e3bcf3530b) This commit addresses the behavior of mail groups set to privacy mode "Selected group of users". Prior to this fix, incoming emails were being checked against the list of members within the mail group, even when the privacy setting allowed for a specified user group, not solely members. Consequently, legitimate emails from auth
Original PR description
### [[FIX] mail_group: allow selected group of users while not members](https://github.com/odoo/odoo/pull/157590/commits/a25190e30ad732ab5057e85fcd4f34e3bcf3530b) This commit addresses the behavior…
### [[FIX] mail_group: allow selected group of users while not members](https://github.com/odoo/odoo/pull/157590/commits/a25190e30ad732ab5057e85fcd4f34e3bcf3530b) This commit addresses the behavior of mail groups set to privacy mode "Selected group of users". Prior to this fix, incoming emails were being checked against the list of members within the mail group, even when the privacy setting allowed for a specified user group, not solely members. Consequently, legitimate emails from authorized users were being rejected due to the sender not being a member of the mail group. With this commit, the sender's membership in the access group is verified. ### [Reproduce] - Install -i website_mail_group - Set the alias to "odoo.com" in General Settings - Create or Modify Mail Group named "My Company News", with the following settings: - Email Alias: newsletter@odoo.com - Privacy: "Selected Group of Users" - Select internal user group, add there a user with email pian@odoo.com - Send or Inject the email from the eml file below - BUG: email not present in the mail group Email eml file: ```eml From: "pian@odoo.com" <pian@odoo.com> Subject: members only To: "newsletter@odoo.com" <newsletter@odoo.com> Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dutf-8"><p= >Content for Internal Users</p> ``` opw-3725128 Forward-Port-Of: odoo/odoo#164744 Forward-Port-Of: odoo/odoo#157590
Description of the issue/feature this PR addresses: This PR aims to address the issue where the cancel buttons (on transfer and MO) are prone to accidental presses due to their proximity. Currently, pressing the cancel button immediately cancels the transfer or MO. Current behavior before PR: Pressing the cancel button results in immediate cancellation of the transfer or MO. Desired behavior after PR is merged: After merging this PR, Odoo will prompt for confirmation when the cancel but
Original PR description
Description of the issue/feature this PR addresses: This PR aims to address the issue where the cancel buttons (on transfer and MO) are prone to accidental presses due to their proximity. Currently,…
Description of the issue/feature this PR addresses: This PR aims to address the issue where the cancel buttons (on transfer and MO) are prone to accidental presses due to their proximity. Currently, pressing the cancel button immediately cancels the transfer or MO. Current behavior before PR: Pressing the cancel button results in immediate cancellation of the transfer or MO. Desired behavior after PR is merged: After merging this PR, Odoo will prompt for confirmation when the cancel button on a transfer or MO is pressed. This will help prevent accidental cancellations. Additionally, the confirmation warning should always be present for both cancel buttons on the MO to ensure consistency. See below attached for a confirmation message: On transfer,  On MO,  --- I confirm I have signed the CLA and read the PR guidelines at [submit-pr](www.odoo.com/submit-pr) Forward-Port-Of: odoo/odoo#160609
[IMP] point_of_sale: adding a custom page on iot box's nginx server to catch 502 errors Current behavior: When the IoT box's python version is not compatible with the Odoo's one, Odoo server crash and let nginx generate a 502 error with no information for the user After this commit: When the error is triggered, a custom page will be shown to the user `502.html` is the page who will be displayed to the user `default` is the config of nginx, which is responsible to link the html page
Original PR description
[IMP] point_of_sale: adding a custom page on iot box's nginx server to catch 502 errors Current behavior: When the IoT box's python version is not compatible with the Odoo's one, Odoo server crash and let nginx generate a 502 error with no information for the user After this commit: When the error is triggered, a custom page will be shown to the user `502.html` is the page who will be displayed to the user `default` is the config of nginx, which is responsible to link the html page with error triggered opw-3853501 Forward-Port-Of: odoo/odoo#163137
Add new module with functionality of `l10n_in_edi_ewaybill` on `stock` This module enables user to create ewaybill from stock picking without creating an account move task-3376530 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#163335
Original PR description
Add new module with functionality of `l10n_in_edi_ewaybill` on `stock` This module enables user to create ewaybill from stock picking without creating an account move task-3376530 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#163335
### Steps to reproduce the issue: 1. In _Maintenance > Maintenance > Maintenance Requests_, set multiple maintenance requests with scheduled dates 2. In _Maintenance > Maintenance > Maintenance Calendar_, get to a week or month with multiple requests 3. Drag and drop one of the requests in the calendar - You can also double click or resize the request 4. In most cases, the request that is changed or accessed is not the right one ### Explanation: `rawRecord` is the record as retr
Original PR description
### Steps to reproduce the issue: 1. In _Maintenance > Maintenance > Maintenance Requests_, set multiple maintenance requests with scheduled dates 2. In _Maintenance > Maintenance > Maintenance…
### Steps to reproduce the issue:
1. In _Maintenance > Maintenance > Maintenance Requests_, set multiple maintenance requests with scheduled dates
2. In _Maintenance > Maintenance > Maintenance Calendar_, get to a week or month with multiple requests
3. Drag and drop one of the requests in the calendar
- You can also double click or resize the request
4. In most cases, the request that is changed or accessed is not the right one
### Explanation:
`rawRecord` is the record as retrieved by `fetchRecords`, it is then processed in `loadRecords`. In `CalendarWithRecurrence`, with the option of having recurring events, `record.id` is nearly always different from `rawRecord.id`.
https://github.com/odoo/odoo/blob/74a0703671f29fefad02843c0d679f903b812575/addons/maintenance/static/src/views/calendar_with_recurrence/calendar_with_recurrence_model.js#L11-L17
### Suggested fix:
Overriding the methods that lead to the wrong model to replace `record.id` with `record.rawRecord.id` solves the issue without breaking other methods.
For requests with recurrence, any change made using an occurrence in the calendar view would target the original request instead. Accessing it is not an issue, so we will only disable the edition of the occurrences.
opw-3848278
opw-3849852
Forward-Port-Of: odoo/odoo#165474
Forward-Port-Of: odoo/odoo#162041**[FIX] web_editor: fix drag and drop in mobile preview** Steps to reproduce the bug: - In "Website" edit mode. - Click on the "Mobile preview" button in the right panel. - Drop the "Text-Image" and "Image-Text" snippets. - Drop the "Alert" snippet (so an inner content). - Drag the "Alert" snippet and hover the dropzones. - Bug: There is no "preview" of the dragged snippet, like in desktop view. In this commit [1], the "drag and drop" feature of snippets was adapted following the
Original PR description
**[FIX] web_editor: fix drag and drop in mobile preview** Steps to reproduce the bug: - In "Website" edit mode. - Click on the "Mobile preview" button in the right panel. - Drop the "Text-Image" and…
**[FIX] web_editor: fix drag and drop in mobile preview** Steps to reproduce the bug: - In "Website" edit mode. - Click on the "Mobile preview" button in the right panel. - Drop the "Text-Image" and "Image-Text" snippets. - Drop the "Alert" snippet (so an inner content). - Drag the "Alert" snippet and hover the dropzones. - Bug: There is no "preview" of the dragged snippet, like in desktop view. In this commit [1], the "drag and drop" feature of snippets was adapted following the relocation of the website preview into an iframe (see commit [2]). Later, another commit [3] moved the overlay of the snippets into the iframe. It is this latter commit that introduced the bug. Indeed, since the overlay is within the iframe, the jQuery Draggable "Helper" is also within the iframe when a snippet is dragged from the page (as opposed to from the snippets menu). Therefore, it is no longer necessary to consider the offset of the iframe when computing the dropzones (as done in [1]). [1]: https://github.com/odoo/odoo/commit/457e655ff7f4651f185bd7544b8384e2d0ee8ef8 [2]: https://github.com/odoo/odoo/commit/59b96b0742fe8da31eecf896f7a6157811d49de5 [3]: https://github.com/odoo/odoo/commit/872bb20b3ac08cf82613e15e6634a2e7593ccf7a task-3854032 ----------------------------------------------------- **[FIX] web: fix smooth scroll on drag in mobile preview** Steps to reproduce the bug: - In "Website" edit mode. - Click on the "Mobile Preview" button in the right panel. - Drag and drop 3 "Text-Image" snippets onto the page. - Try to scroll the page while dragging a "Text" snippet. - Bug: The page doesn't scroll. Since the changes made by this commit [1], when editing a webpage, it is displayed within an iframe. This has involved changes in the "Smooth scroll on drag" functionality to work correctly within the iframe, especially for mobile preview (see this commit [2]). This latest change caused a bug in the "Sign" app where the "Scroll on drag" no longer worked. This was fixed in the "Sign" app by the following commit [3]. However, it broke the adaptation made by commit [2], resulting in the bug described in this commit. This commit makes the necessary adaptations for everything to work correctly both in "Sign" and in "Website". [1]: https://github.com/odoo/odoo/commit/59b96b0742fe8da31eecf896f7a6157811d49de5 [2]: https://github.com/odoo/odoo/commit/457e655ff7f4651f185bd7544b8384e2d0ee8ef8 [3]: https://github.com/odoo/odoo/commit/0ed6d65d903f8c52b664ab711f6918211e41b6d6 task-3854032 Forward-Port-Of: odoo/odoo#163260 Forward-Port-Of: odoo/odoo#162099
This commit hides the expand/fold button of the search panel in the chart of accounts because it overlaps with the search panel buttons and is not useful in this case. Forward-Port-Of: odoo/odoo#164152
Original PR description
This commit hides the expand/fold button of the search panel in the chart of accounts because it overlaps with the search panel buttons and is not useful in this case. Forward-Port-Of: odoo/odoo#164152
**Description of the issue/feature this PR addresses:** Before this commit Amounts to Settle is not show. When it is a purchase amount_residual is lower than zero. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165645
Original PR description
**Description of the issue/feature this PR addresses:** Before this commit Amounts to Settle is not show. When it is a purchase amount_residual is lower than zero. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165645
Steps to reproduce: ------------------- Delete a time off request from day/week/month scale on the calendar view. Issue: ------ A traceback appears. Cause: ------ In the `deleteRecord` method, the record parameter is sometimes a proxy object (with a `resId` and `data`) or sometimes the record itself (with an `id` and a `raw_record`). This triggers a problem when for example we want to access `record.data.can_cancel` if we are in the case of a record and not a proxy record. The
Original PR description
Steps to reproduce: ------------------- Delete a time off request from day/week/month scale on the calendar view. Issue: ------ A traceback appears. Cause: ------ In the `deleteRecord` method, the record parameter is sometimes a proxy object (with a `resId` and `data`) or sometimes the record itself (with an `id` and a `raw_record`). This triggers a problem when for example we want to access `record.data.can_cancel` if we are in the case of a record and not a proxy record. The override is not compatible with its use in web. Solution: --------- Take into account that the method can accept several "record types". opw-3891206 Forward-Port-Of: odoo/odoo#165345
**[FIX] website_slides: rectify the trigger on the course title input field** Before this commit: - While running the `slides_tour`, it freezes after we click on `Course` to create a new course. The prompt to input the title while creating the new course is not visible. - The prompt to add 'Section Name' is missing. Reason: The 'trigger' update was not addressed in the following PR: https://github.com/odoo/odoo/pull/117799 After this commit: - The prompt to input the course title
Original PR description
**[FIX] website_slides: rectify the trigger on the course title input field** Before this commit: - While running the `slides_tour`, it freezes after we click on `Course` to create a new course. The prompt to input the title while creating the new course is not visible. - The prompt to add 'Section Name' is missing. Reason: The 'trigger' update was not addressed in the following PR: https://github.com/odoo/odoo/pull/117799 After this commit: - The prompt to input the course title is visible. - The prompt to add the 'Section Name' is added. task-3539126 Forward-Port-Of: odoo/odoo#165389 Forward-Port-Of: odoo/odoo#138651
Before this commit, the `point_of_sale.OrderReceipt` template would always print taxes followed by a % symbol. This should not be so for fixed taxes, whose amount is not a percentage. This commit removes the % symbol after fixed taxes. As an improvement it also displays the tax name in the first column, since the tax amount is already displayed in the following column. No task. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior afte
Original PR description
Before this commit, the `point_of_sale.OrderReceipt` template would always print taxes followed by a % symbol. This should not be so for fixed taxes, whose amount is not a percentage. This commit removes the % symbol after fixed taxes. As an improvement it also displays the tax name in the first column, since the tax amount is already displayed in the following column. No task. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#163391
Since showDelete is not the same that checking that an attachement isDeletable, we need to add the class that diplays multiple buttons if we show the delete button, otherwise the Download button will be hidden. So we now use the correct value to decide if display multiple button. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/s
Original PR description
Since showDelete is not the same that checking that an attachement isDeletable, we need to add the class that diplays multiple buttons if we show the delete button, otherwise the Download button will be hidden. So we now use the correct value to decide if display multiple button. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165605
Problem --------- In l10n_ec_edi_certificate.py, we attempt to get the subject attribute which does not exist in the namespace. Solution --------- Add the attribute to the namespace returned. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165572
Original PR description
Problem --------- In l10n_ec_edi_certificate.py, we attempt to get the subject attribute which does not exist in the namespace. Solution --------- Add the attribute to the namespace returned. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165572
Starting Odoo 17, es_419 is used as a base for every Spanish locale (es_VE, es_AR, es_BO...), but a lot of localizations still have their translations written for es_ES only. After this commit, both es_ES and es_419 will be used as base languages for Spanish variations, ensuring that the translations will be loaded whatever the file they where put into and the language of the user. Forward-Port-Of: odoo/odoo#165279
Original PR description
Starting Odoo 17, es_419 is used as a base for every Spanish locale (es_VE, es_AR, es_BO...), but a lot of localizations still have their translations written for es_ES only. After this commit, both es_ES and es_419 will be used as base languages for Spanish variations, ensuring that the translations will be loaded whatever the file they where put into and the language of the user. Forward-Port-Of: odoo/odoo#165279
This PR add the Mercado Pago "Smart Point" payment terminal dedicated to the LATAM (Latin America) region task-3350386 mool --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165208 Forward-Port-Of: odoo/odoo#154962
Original PR description
This PR add the Mercado Pago "Smart Point" payment terminal dedicated to the LATAM (Latin America) region
task-3350386
mool
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#165208
Forward-Port-Of: odoo/odoo#154962This commit fixes a typo in message template. `messageSearch` is a prop of Message component. Forward-Port-Of: odoo/odoo#165643
Original PR description
This commit fixes a typo in message template. `messageSearch` is a prop of Message component. Forward-Port-Of: odoo/odoo#165643
Commit that introduced the issue: [1] Issue: ====== The email sent from chatter message isn't correctly formatted. Steps to reproduce the issue: ============================= - Go to chatter of any form view - Open the mail compose modal - Add a primary link the in the email body - Send it - The email isn't formatted in the received email. Origin of the issue: ==================== The flow goes as follow, we first change the field and then when clicking send, we first update
Original PR description
Commit that introduced the issue: [1] Issue: ====== The email sent from chatter message isn't correctly formatted. Steps to reproduce the issue: ============================= - Go to chatter of any…
Commit that introduced the issue: [1] Issue: ====== The email sent from chatter message isn't correctly formatted. Steps to reproduce the issue: ============================= - Go to chatter of any form view - Open the mail compose modal - Add a primary link the in the email body - Send it - The email isn't formatted in the received email. Origin of the issue: ==================== The flow goes as follow, we first change the field and then when clicking send, we first update the value of the editor by `onWysiwygBlur` , then before the send is done, the field is saved which will trigger the event `NEED_LOCAL_CHANGES` which will call commitChanges, but since we already updated the value and we don't have urgent, nothing will happend and the function `toInline` will never be called. Solution: ========= To not break the old commit behavior and make it reset with disard, we add another flag `shouldInline` so we can force `commitChanges` and calculating inline style when saving. [1]: https://github.com/odoo/odoo/commit/35731674561efa391852fd7e42a19c732c29886f opw-3885368 Forward-Port-Of: odoo/odoo#165269 Forward-Port-Of: odoo/odoo#163323
Problem: The word "Cash" is not translated and appears in the sales details Steps to reproduce: - Install "Point of Sale" app - Open a POS session and make some sales WHITHOUT paying in Cash - Close the session and change the language - Go to "Reporting" > "Sales Details" and print the report - In the section "Payments" you should see a row with "Cash" payments Cause: The word is not added to the translations opw-3684937 --- I confirm I have signed the CLA and read the PR g
Original PR description
Problem: The word "Cash" is not translated and appears in the sales details Steps to reproduce: - Install "Point of Sale" app - Open a POS session and make some sales WHITHOUT paying in Cash - Close the session and change the language - Go to "Reporting" > "Sales Details" and print the report - In the section "Payments" you should see a row with "Cash" payments Cause: The word is not added to the translations opw-3684937 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#164173
In Hungary, companies are required to submit their invoices to the NAV (tax authority) via a dedicated API. This API uses a simple invoicing flow (no cancellation, use credit notes to reverse). The new module `l10n_hu_edi` provides an integration for this API, enabling Hungarian users to make use of Odoo. The new module also provides functionality for tax audit export which is mandatory for accounting software in Hungary. Based on #137301 by Csaba Tóth. taskid: 3213959 Forward-Port
Original PR description
In Hungary, companies are required to submit their invoices to the NAV (tax authority) via a dedicated API. This API uses a simple invoicing flow (no cancellation, use credit notes to reverse). The new module `l10n_hu_edi` provides an integration for this API, enabling Hungarian users to make use of Odoo. The new module also provides functionality for tax audit export which is mandatory for accounting software in Hungary. Based on #137301 by Csaba Tóth. taskid: 3213959 Forward-Port-Of: odoo/odoo#154227
Steps to reproduce: - create a new spreadsheet - type in cell A1 "01/2024" - in A2, type =ODOO.BALANCE("1", A1) - select A1 => boom Since 4939846774 `dateRange` is mutated in place. But `dateRange` is actually the evaluated cell object. It has originally the `type: "number"` and a corresponding value whose type is a number. But those accounting functions replaces the value with a string. From that point, there's a mismatch between `cell.type` and `cell.value`. The type says it's a numbe
Original PR description
Steps to reproduce:
- create a new spreadsheet
- type in cell A1 "01/2024"
- in A2, type =ODOO.BALANCE("1", A1)
- select A1 => boom
Since 4939846774 `dateRange` is mutated in place.
But `dateRange` is actually the evaluated cell object. It has originally the `type: "number"` and a corresponding value whose type is a number.
But those accounting functions replaces the value with a string. From that point, there's a mismatch between `cell.type` and `cell.value`. The type says it's a number but it's actually not.
When selecting the cell and the bottom bar statistics are recomputed, because it expects numbers, not strings.
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#165362data_merge company dependent fields were always written on res.partner and not their correct model. Forward-Port-Of: odoo/enterprise#61929
Original PR description
data_merge company dependent fields were always written on res.partner and not their correct model. Forward-Port-Of: odoo/enterprise#61929
The record `documents_hr_contract.documents_hr_documents_contracts` has `forcecreate=1` and there is a chain of dependency of these 3 records: 1. `documents_hr_contract.documents_hr_documents_contracts` [--> 2.](https://github.com/odoo/enterprise/blob/17.0/documents_hr_contract/data/documents_tag_data.xml#L12) 2. `documents_hr.documents_hr_documents` [--> 3.](https://github.com/odoo/enterprise/blob/17.0/documents_hr/data/documents_facet_data.xml#L7) 3. `docum
Original PR description
The record `documents_hr_contract.documents_hr_documents_contracts` has `forcecreate=1` and there is a chain of dependency of these 3 records: 1.…
The record `documents_hr_contract.documents_hr_documents_contracts` has `forcecreate=1` and there is a chain of dependency of these 3 records:
1. `documents_hr_contract.documents_hr_documents_contracts` [--> 2.](https://github.com/odoo/enterprise/blob/17.0/documents_hr_contract/data/documents_tag_data.xml#L12)
2. `documents_hr.documents_hr_documents` [--> 3.](https://github.com/odoo/enterprise/blob/17.0/documents_hr/data/documents_facet_data.xml#L7)
3. `documents_hr.documents_hr_folder`
But for the latter 2 records **forcecreate=0**. All of these records are set `noupdate=1`. That is why during upgrade the latter 2 records will be skipped from creation if they are missing in db, but it will try to create the 1st one because of that forcecrete=1. This will cause dependency issue if the db is missing the other 2 records.
For solving the issue we set `forcecreate=1` to the latter 2 records.
**Steps to reproduce:**
1. Install modules documents_hr, documents_hr_contract in version `16.0`
2. Delete the document facet `documents_hr.documents_hr_documents`
3. Delete the document folder `documents_hr.documents_hr_folder`
4. Try to upgrade to `17.0`
You will see similar traceback to this:
```
Traceback (most recent call last):
File "/home/odoo/src/odoo/17.0/odoo/modules/registry.py", line 113, in new
odoo.modules.load_modules(registry, force_demo, status, update_module)
...
...
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 693, in convert_xml_import
obj.parse(doc.getroot())
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 613, in parse
self._tag_root(de)
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 556, in _tag_root
f(rec)
File "/home/odoo/src/odoo/17.0/odoo/tools/convert.py", line 569, in _tag_root
raise ParseError('while parsing %s:%s, somewhere inside\n%s' % (
odoo.tools.convert.ParseError: while parsing /home/odoo/src/enterprise/17.0/documents_hr_contract/data/documents_tag_data.xml:10, somewhere inside
<record id="document_tag_signature_request" model="documents.tag" forcecreate="1">
<field name="name">Signature Request</field>
<field name="facet_id" ref="documents_hr.documents_hr_documents"/>
<field name="sequence">15</field>
</record>
```
Forward-Port-Of: odoo/enterprise#62464Add Bank Indonesia as a provider or currency rate in order to align with the local market needs. Task id # 3217982 Forward-Port-Of: odoo/enterprise#62167 Forward-Port-Of: odoo/enterprise#61008
Original PR description
Add Bank Indonesia as a provider or currency rate in order to align with the local market needs. Task id # 3217982 Forward-Port-Of: odoo/enterprise#62167 Forward-Port-Of: odoo/enterprise#61008
Since commit 911886b20ac632a34ab1cfa2c2e22d60d16173ac, any analytic plan that is mandatory for miscellaneous entries is also required for all lines in the bank reconciliation. However, we currently do not allow setting analytic accounts on liquidity lines (the field is not displayed). opw-3905713 Forward-Port-Of: odoo/enterprise#62182
Original PR description
Since commit 911886b20ac632a34ab1cfa2c2e22d60d16173ac, any analytic plan that is mandatory for miscellaneous entries is also required for all lines in the bank reconciliation. However, we currently do not allow setting analytic accounts on liquidity lines (the field is not displayed). opw-3905713 Forward-Port-Of: odoo/enterprise#62182
…oiced Before this commit, salespersons could churn a contract that has not been invoiced. It would impact the churn statistics. If the invoice has never been created, a cancelation is more correct. taskid 3925539 Forward-Port-Of: odoo/enterprise#62382
Original PR description
…oiced Before this commit, salespersons could churn a contract that has not been invoiced. It would impact the churn statistics. If the invoice has never been created, a cancelation is more correct. taskid 3925539 Forward-Port-Of: odoo/enterprise#62382
The ondelete was not in the right model. task-3928257 Forward-Port-Of: odoo/enterprise#62466
Original PR description
The ondelete was not in the right model. task-3928257 Forward-Port-Of: odoo/enterprise#62466
1. VMT_1 tag should report the currency rate instead of the invoice untaxed amount 2. CDE_2 tag should be limited to a max of 30 characters Related: https://github.com/odoo/odoo/pull/148953 and https://github.com/odoo/enterprise/pull/54086 task-3925896 Forward-Port-Of: odoo/enterprise#62512
Original PR description
1. VMT_1 tag should report the currency rate instead of the invoice untaxed amount 2. CDE_2 tag should be limited to a max of 30 characters Related: https://github.com/odoo/odoo/pull/148953 and https://github.com/odoo/enterprise/pull/54086 task-3925896 Forward-Port-Of: odoo/enterprise#62512
This commit presents UI improvements: Renamed the back button to "Change Table." Increased idle table closure time from 1 minute to 3 minutes. Implemented a restriction preventing users from transferring orders to tables already in use. Displayed the attributes of an order line in the order widget. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149465 Forward-Port-Of: odoo/odoo#147677
Original PR description
This commit presents UI improvements: Renamed the back button to "Change Table." Increased idle table closure time from 1 minute to 3 minutes. Implemented a restriction preventing users from transferring orders to tables already in use. Displayed the attributes of an order line in the order widget. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#149465 Forward-Port-Of: odoo/odoo#147677