Sunday, May 19, 2024
6 changes · saas-17.2
Miscellaneous changes
The template for the attachment list adds a class to show multiple options when attachments can be deleted. However the condition to display the delete button is different from the condition to apply that style. Meaning if one condition `showDelete` is true while the other `isDeletable` is false it is impossible to access the download button as the correct style is not applied. - Fix the template to use the same condition everywhere - Fix the condition for showDelete to always be false
Original PR description
The template for the attachment list adds a class to show multiple options when attachments can be deleted. However the condition to display the delete button is different from the condition to apply…
The template for the attachment list adds a class to show multiple options when attachments can be deleted. However the condition to display the delete button is different from the condition to apply that style. Meaning if one condition `showDelete` is true while the other `isDeletable` is false it is impossible to access the download button as the correct style is not applied. - Fix the template to use the same condition everywhere - Fix the condition for showDelete to always be false is deletion is disallowed Issue noticeable since [1] when attachments were made conditionally deletable as opposed to always deletable previously. Steps to reproduce: - Post a couple attachments on the same message as a user in a chatter - Switch to a different user that is not allowed to delete the attachment (not admin) - You can't select the download button without using the tab key 1: 32a80a3ce1b2cbc46b1fc20f96b82256639beb9f task-3519815 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166086 Forward-Port-Of: odoo/odoo#165332
FileReference and FileDate fields are added to the Factura-E export. task-3864452 Forward-Port-Of: odoo/odoo#162791
Original PR description
FileReference and FileDate fields are added to the Factura-E export. task-3864452 Forward-Port-Of: odoo/odoo#162791
The brand new Ubuntu Noble 24.04 ships python3-werkzeug 3.0.1. This versions has a bug [0] which leads to this test failing as double slashes get fixed by werkzeug even though `merge_slashes` parameter is set to False by default in Odoo. This should not have a big impact on real life but the test should be kept to ensure that the actual behavior of a 404 is not broken outside of Ubuntu Noble. So, with this commit, if the impacted version of werkzeug is used the test will not fail with a fi
Original PR description
The brand new Ubuntu Noble 24.04 ships python3-werkzeug 3.0.1. This versions has a bug [0] which leads to this test failing as double slashes get fixed by werkzeug even though `merge_slashes` parameter is set to False by default in Odoo. This should not have a big impact on real life but the test should be kept to ensure that the actual behavior of a 404 is not broken outside of Ubuntu Noble. So, with this commit, if the impacted version of werkzeug is used the test will not fail with a fixed url and a redirect response. The issue that exists from 2.2.0 up to 3.0.1 is fixed upstream [1] in 3.0.2. A bug report was filled in Ubuntu [2] (Debian is not impacted) [0]: https://github.com/pallets/werkzeug/issues/2834 [1]: https://github.com/pallets/werkzeug/pull/2860 [2]: https://bugs.launchpad.net/ubuntu/+source/python-werkzeug/+bug/2066041 Forward-Port-Of: odoo/odoo#165998
In `_onchange_group_sale_pricelist`, we check that there is no active pricelist, otherwise we raise a warning. This commit limits the search to one occurence, as it is not necessary to search for all pricelists. Forward-Port-Of: odoo/odoo#165809
Original PR description
In `_onchange_group_sale_pricelist`, we check that there is no active pricelist, otherwise we raise a warning. This commit limits the search to one occurence, as it is not necessary to search for all pricelists. Forward-Port-Of: odoo/odoo#165809
* account_accountant_batch_payment, sale_account_accountant Currently the tab titles of the bank reconciliation widget are not translatable. This is due to the fact that attributes of OWL components (including `t-set-slot` elements) are not considered translatable. The solution is to extract these translatable terms in a variable outside of the `t-set-slot`'s parent component so it would become translatable and available inside the right slots. The issue was already partially fixed in [
Original PR description
* account_accountant_batch_payment, sale_account_accountant Currently the tab titles of the bank reconciliation widget are not translatable. This is due to the fact that attributes of OWL components (including `t-set-slot` elements) are not considered translatable. The solution is to extract these translatable terms in a variable outside of the `t-set-slot`'s parent component so it would become translatable and available inside the right slots. The issue was already partially fixed in [1] in 17.0. [1]: https://github.com/odoo/enterprise/commit/161163928bc4a18700be1b69b5276cb3b8490e45 opw-3881861 Forward-Port-Of: odoo/enterprise#62691 Forward-Port-Of: odoo/enterprise#62643
Continuation of #59440 Forward-Port-Of: odoo/enterprise#62712
Original PR description
Continuation of #59440 Forward-Port-Of: odoo/enterprise#62712