Odoo Changelog — 2024-05-23

Thursday, May 23, 2024

2 changes · saas-17.1

Bug Fixes(2)

Resolved issues and error corrections

[FIX] mail: error opening chatwindow of a non member channel

Coresaas-17.1mail

Users who are mentioned in a public channel can now open the related chat window without seeing an error, even if they are not channel members. The system avoids saving a chat-window setting that only applies to members, preventing an unnecessary disruption when following notifications.

Original PR description

**Current behavior before PR:**

Opening a chatwindow for a channel the user is not a member of would result in an error.
This occurs because the chatwindow' fold state is saved to the server, but the server expects the user be a member of the channel.

**Steps to reproduce:**

1. Create a channel and change it's Authorized group to null making it public
2. Mention a user who is not a member of this channel.
3. Login through the mentioned user.
4. Open the systray and click on the message notification.
5. It will open the chatwindow and throw the error.

**Desired behavior after PR is merged:**

Prevent saving the fold state to server if the user is not a member of the channel.

task-[3890519](https://www.odoo.com/web?debug=1#id=3890519&cids=2&menu_id=6478&action=4043&model=project.task&view_type=form)

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#chat#notifications#channels

[FIX] l10n_account_customer_statements: make customer statements from studio not crash

PR #62891

Enterprisesaas-17.1l10n_account_customer_statements

Opening the Customer Statements report from Studio now works without an error when no real customer record is selected. This prevents interruptions for users customizing reports and keeps Studio report editing usable.

Original PR description

An error is raised when accessing customer statement from contact page in studio.

### Steps to reproduce:
- Install Studio, Contact apps and the l10n_account_customer_statements module.
- Open studio and go to Reports
- When clicking on the Customer Statements report an error is raised

### Cause:
Studio uses the partner res.partner(0,) to display the report in edit mode, but the method _get_report_values is always searching for the partner data to fill the report. The error is raised because res.partner(0,) does not reference any partner.

### Solution:
Modify _get_report_values to search for partner data only if the partner id is different from 0.

opw-3920298

#customer statements#studio#reports

**Current behavior before PR:** Opening a chatwindow for a channel the user is not a member of would result in an error. This occurs because the chatwindow' fold state is saved to the server, but the server expects the user be a member of the channel. **Steps to reproduce:** 1. Create a channel and change it's Authorized group to null making it public 2. Mention a user who is not a member of this channel. 3. Login through the mentioned user. 4. Open the systray and click on the message notification. 5. It will open the chatwindow and throw the error. **Desired behavior after PR is merged:** Prevent saving the fold state to server if the user is not a member of the channel. task-[3890519](https://www.odoo.com/web?debug=1#id=3890519&cids=2&menu_id=6478&action=4043&model=project.task&view_type=form) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

An error is raised when accessing customer statement from contact page in studio. ### Steps to reproduce: - Install Studio, Contact apps and the l10n_account_customer_statements module. - Open studio and go to Reports - When clicking on the Customer Statements report an error is raised ### Cause: Studio uses the partner res.partner(0,) to display the report in edit mode, but the method _get_report_values is always searching for the partner data to fill the report. The error is raised because res.partner(0,) does not reference any partner. ### Solution: Modify _get_report_values to search for partner data only if the partner id is different from 0. opw-3920298