Saturday, May 25, 2024
1 change · master
Code cleanup and technical improvements
This update simplifies how navigation bars and control buttons adapt on smaller screens. It reduces hidden duplicate interface elements, making behavior more consistent and easier to maintain across several Odoo apps.
Original PR description
*: account_consolidation,documents,documents_spreadsheet,industry_fsm, planning,sign,timesheet_grid,web_grid,web_studio During the "Milk" redesign, the display of some parts/buttons of the ControlPanel and Navbar were transformed into dropdown or hidden on smaller screens. To do so, the Bootstrap's responsive classed were used to make the transition between viewport's width more "fluid". The side-effect was that the elements for both implementations are present in the DOM (just hidden behind breakpoints), leading to more complexity in the implementation and/or weirdness in the tests. This commit simplifies it by binding those buttons/dropdown presence to the common `isSmall` threshold, cleaning up the DOM generated, making it more consistent with the rest of the codebase and allowing to remove weird/misleading selectors in the tests (i.e. click on `.d-none button`). task-3336242