Sunday, May 26, 2024
3 changes · master
Miscellaneous changes
Fine tunning of 447ac7fb97b5 Forward-Port-Of: odoo/odoo#166603 Forward-Port-Of: odoo/odoo#166483
Original PR description
Fine tunning of 447ac7fb97b5 Forward-Port-Of: odoo/odoo#166603 Forward-Port-Of: odoo/odoo#166483
Since [1], Werkzeug discards any remaining data in the read socket after sending the response. In the case of WebSocket connections, the socket is not closed, and data keeps coming. As a result, WebSocket connections to the threaded server hang indefinitely in this discarding phase and never reach the processing phase. Thus, frames sent to the server are never processed. To solve this issue, rfile and wfile are replaced by dummy byte streams to ensure that our socket remains intact.
Original PR description
Since [1], Werkzeug discards any remaining data in the read socket after sending the response. In the case of WebSocket connections, the socket is not closed, and data keeps coming. As a result, WebSocket connections to the threaded server hang indefinitely in this discarding phase and never reach the processing phase. Thus, frames sent to the server are never processed. To solve this issue, rfile and wfile are replaced by dummy byte streams to ensure that our socket remains intact. [1]: https://github.com/pallets/werkzeug/commit/4f7048e7a31752142f18eefeccd49acc42a89e31 Forward-Port-Of: odoo/odoo#166567 Forward-Port-Of: odoo/odoo#166231
Steps to reproduce: - Go to CRM lead pivot view - group by any date field by day - insert in spreadsheet - start typing '=odoo.pivot(1, <measure>, ' => Currently, when the auto-complete proposes a date field (e.g. "create_date"), the field is proposed without the granularity ("create_date", not "create_date:month"). The formula result is an error if the granularity is missing. Task: 3823433 Forward-Port-Of: odoo/enterprise#61696
Original PR description
Steps to reproduce:
- Go to CRM lead pivot view
- group by any date field by day
- insert in spreadsheet
- start typing '=odoo.pivot(1, <measure>, '
=> Currently, when the auto-complete proposes a date field (e.g. "create_date"), the field is proposed without the granularity ("create_date", not "create_date:month").
The formula result is an error if the granularity is missing.
Task: 3823433
Forward-Port-Of: odoo/enterprise#61696