Monday, May 27, 2024
2 changes · saas-17.1
Resolved issues and error corrections
This change reverts a previous update that could accidentally assign website shopping carts to OdooBot instead of the real customer. It protects customer order accuracy while a cleaner long-term solution is prepared separately.
Original PR description
This reverts commit c1d5a59033941f8479f22320cd6e9f0bbd990575. This commit included changes that triggered sale_get_order calls in routes/requests that did not use it previously. Since those routes were using an environment sudoed with the superuser, the call to sale_get_order wrongly changed the customer to OdooBot. This will be addressed in a cleaner way in a separate PR, but for now, we only revert the wrong commit. opw-3949391 & others
This fix prevents a traceback when shop floor users register production for lot-tracked manufactured products. It ensures the production confirmation dialog receives data in the expected format, allowing operators to continue the manufacturing workflow without interruption.
Original PR description
**Current behavior:** Creating a manufacturing order for a product which is tracked via lots can cause a trace back when trying to register the lot number in the shop floor as part of the registering production flow. **Expected behavior:** No trace back. **Steps to reproduce:** 1. Create a product which is tracked with lots and a component 2. Create an MO to manufacture the lot-tracked product and confirm it 3. Open the shop floor, click on the MO line for the product to add the lot number and check it off -> trace back **Cause of the issue:** The context prop is a 'stringified' object instead of the owl-enforced 'object' type. `MrpRegisterProductionDialog` extends `MrpQualityCheckConfirmationDialog`, where we can see context is not stringified. **Fix:** Don't stringify the context upon creation of the confirmation dialog object. opw-3876368