Thursday, May 30, 2024
15 changes · 17.0
Resolved issues and error corrections
The Link Tracker dropdowns now avoid showing the same campaign or UTM record more than once when searching. This makes selection clearer for users and reduces confusion when creating or tracking marketing links.
Original PR description
Since [1] UTM records that match both at the start of their name and elsewhere within their name are displayed twice in the dropdowns. This commit filters the "contains" matches in order to include only the ones that do not already appear among the "start" matches. Steps to reproduce: - Go to the "Link Tracker" page. - Click inside the "Campaign" dropdown. => Entries appear twice because the empty string is matched both at start and inside the names. - Create a campaign that begins and ends with the same letter (e.g. "Supers"). - Return to the "Link Tracker" page. - Click inside the "Campaign" dropdown. - Type the first letter of the new campaign. => The new campaign appears twice in the dropdown list, each time with the first letter highlighted. [1]: https://github.com/odoo/odoo/commit/2bf71a32000c33754a32599776079a0dc60d2bba task-3933262
This fixes a mismatch caused by a field name change in Odoo 17.0, where completed purchase stock quantities are now tracked as picked quantities. It helps purchase stock valuation tests and related workflows use the correct quantity information, reducing errors in inventory and purchasing processes.
Original PR description
Due to change in 17.0 qty_done become picked on the stock.move Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Uganda accounting setup now classifies the taxes payable account correctly so tax lines are not mistaken for receivable items. This prevents an error when users register payments on customer invoices for Uganda companies.
Original PR description
With an Uganda company setup Create an invoice to Uganda customer Try to register a payment Error "You can't register payments for both inbound and outbound moves at the same time" This occurs because the Taxes payable account type is set to Liability Payable, so the tax line will be detected as possible receivable by the payment wizard creating the issue opw-3944574
A duplicate rating field was appearing in the helpdesk ticket list view. This fix hides the unused "rating_last_text" field to ensure customers only see one rating display, improving the clarity and appearance of the ticket list.
Original PR description
This commit hides the unused "rating_last_text" field from the list view of tickets, preventing a duplicate rating. Linked PR: https://github.com/odoo/enterprise/pull/52371 task-3869775
This update fixes a German grammar error in the localization files for German DATEV reports. The correction ensures that German language text displays correctly to users in Germany, improving the accuracy and professionalism of the system's German interface.
Original PR description
German grammar is tricky Forward-Port-Of: odoo/enterprise#63334 Forward-Port-Of: odoo/enterprise#63317
Miscellaneous changes
Since lxml 5.2 (https://github.com/lxml/lxml/commit/73778681f14359fe6d16644e69aaca276eba525a) lxml_html_clean is in another package We can adapt the requirements after python 3.12 (based on ubuntu 24.04) We can use | operator in debian/control We may need to adapt documentation since the current sed script will fail This pr proposes an alternative script to avoid to use a sed Current sed: `sed -n -e '/^Depends:/,/^Pre/ s/ python3-\(.*\),/python3-\1/p' debian/control` This sed wi
Original PR description
Since lxml 5.2 (https://github.com/lxml/lxml/commit/73778681f14359fe6d16644e69aaca276eba525a) lxml_html_clean is in another package We can adapt the requirements after python 3.12 (based on ubuntu 24.04) We can use | operator in debian/control We may need to adapt documentation since the current sed script will fail This pr proposes an alternative script to avoid to use a sed Current sed: `sed -n -e '/^Depends:/,/^Pre/ s/ python3-\(.*\),/python3-\1/p' debian/control` This sed will fail and give the result `python3-lxml-html-clean | python3-lxml` for the lxml line, we need to remove the spaces Forward-Port-Of: odoo/odoo#167076 Forward-Port-Of: odoo/odoo#163788
0a0c931 and https://github.com/odoo/enterprise/commit/58f4287a171df1b13f80e7b23675bcec6a5b2a6c added the key 'lot_id' to all `_get_invoiced_lot_values` methods. But point_of_sale uses a different model (`pos.pack.operation.lot`) than stock does (`stock.lot`). Using the same key for two different model is confusing, hence we use another key for the `pos.pack.operation.lot`. opw-3847889 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-p
Original PR description
0a0c931 and https://github.com/odoo/enterprise/commit/58f4287a171df1b13f80e7b23675bcec6a5b2a6c added the key 'lot_id' to all `_get_invoiced_lot_values` methods.
But point_of_sale uses a different model (`pos.pack.operation.lot`) than stock does (`stock.lot`).
Using the same key for two different model is confusing, hence we use another key for the `pos.pack.operation.lot`.
opw-3847889
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: odoo/odoo#167123Issue: ====== Currently you can delete content inside contenteditable=false elements Steps to reproduce the issue: ============================= - Go to website, edit mode, drag a text block - Add `contenteditable="false"` to a `p` element - Select a word in that `p` element and press on any character, it will be deleted Origin of the issue: ==================== Theres is no check if the element is inside a contenteditable=false or not. Solution: ========= We need to check
Original PR description
Issue: ====== Currently you can delete content inside contenteditable=false elements Steps to reproduce the issue: ============================= - Go to website, edit mode, drag a text block - Add `contenteditable="false"` to a `p` element - Select a word in that `p` element and press on any character, it will be deleted Origin of the issue: ==================== Theres is no check if the element is inside a contenteditable=false or not. Solution: ========= We need to check if the selection is in editable or not to be able to apply commands. task-3605829 Forward-Port-Of: odoo/odoo#166982 Forward-Port-Of: odoo/odoo#155758
If user claimed ewallet in confirm order stage, it would redirect them back to review order stage with wrong calculation if shipping had cost. opw-3825880 Forward-Port-Of: odoo/odoo#161620
Original PR description
If user claimed ewallet in confirm order stage, it would redirect them back to review order stage with wrong calculation if shipping had cost. opw-3825880 Forward-Port-Of: odoo/odoo#161620
VIDEO TO REPRODUCE ON RUNBOT: https://github.com/odoo/odoo/assets/56789189/2b89d8c6-627c-4b93-8d96-e9ca5d662450 STEP TO REPRODUCE: -Install DB with demo data -Go to see my tasks of Michell Admin and 13 tasks available -Then go to user profile and hit action 'Assiged Task' -> No tasks for Michell Admin SOLUTION is remove the 'search_default' use domain instead Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is mer
Original PR description
VIDEO TO REPRODUCE ON RUNBOT: https://github.com/odoo/odoo/assets/56789189/2b89d8c6-627c-4b93-8d96-e9ca5d662450 STEP TO REPRODUCE: -Install DB with demo data -Go to see my tasks of Michell Admin and 13 tasks available -Then go to user profile and hit action 'Assiged Task' -> No tasks for Michell Admin SOLUTION is remove the 'search_default' use domain instead Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165142 Forward-Port-Of: odoo/odoo#164267
Before this fix, when a spreadsheet contained any odoo link (to an action, a menu or a XML Id), when a public user opened the spreadsheet and clicked on the link, he had a nonsensical page because the parser and resolver of the link is never loaded for the public user (he would not have access to the menu data anyway). After this fix, we replace the odoo links by their label, so the link itself is removed. Task: 3925333 --- I confirm I have signed the CLA and read the PR guid
Original PR description
Before this fix, when a spreadsheet contained any odoo link (to an action, a menu or a XML Id), when a public user opened the spreadsheet and clicked on the link, he had a nonsensical page because the parser and resolver of the link is never loaded for the public user (he would not have access to the menu data anyway). After this fix, we replace the odoo links by their label, so the link itself is removed. Task: 3925333 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166897 Forward-Port-Of: odoo/odoo#166843
Steps to reproduce: - Navigate to Product Variants list view in the Inventory module - Search for a warehouse e.g. "My Company" in the list view - Click on any storable product e.g. DESK0005 - In the product form view click on the "Forecasted" button This gives a traceback because the 'warehouse' in the context is the name and not the id. Fixes #165330 Forward-Port-Of: odoo/odoo#165934
Original PR description
Steps to reproduce: - Navigate to Product Variants list view in the Inventory module - Search for a warehouse e.g. "My Company" in the list view - Click on any storable product e.g. DESK0005 - In the product form view click on the "Forecasted" button This gives a traceback because the 'warehouse' in the context is the name and not the id. Fixes #165330 Forward-Port-Of: odoo/odoo#165934
Description of the issue/feature this PR addresses: Avoid IndexError when selecting default_dest_location in `_get_default_dest_location` when: - Adding a new line (stock.move.line) inside a Batch - User has _stock.group_stock_storage_categories_ group https://www.loom.com/share/fbe5d532cab94080b4ea3384ebaeb7c0?sid=e3115127-7153-42a5-9caf-69e871077c1a Current behavior before PR: IndexError Desired behavior after PR is merged: Allow to add an empty line without error --- OP
Original PR description
Description of the issue/feature this PR addresses: Avoid IndexError when selecting default_dest_location in `_get_default_dest_location` when: - Adding a new line (stock.move.line) inside a Batch - User has _stock.group_stock_storage_categories_ group https://www.loom.com/share/fbe5d532cab94080b4ea3384ebaeb7c0?sid=e3115127-7153-42a5-9caf-69e871077c1a Current behavior before PR: IndexError Desired behavior after PR is merged: Allow to add an empty line without error --- OPW-3916135 MT-5971 @moduon @rafaelbn @yajo @EmilioPascual --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165753
Since https://github.com/odoo/odoo/pull/143852 and the backport https://github.com/odoo/odoo/pull/163564 , we have added a lot of index for account.move, but still there are some missing left, so this commit is to add the index btree_not_null for those one. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of:
Original PR description
Since https://github.com/odoo/odoo/pull/143852 and the backport https://github.com/odoo/odoo/pull/163564 , we have added a lot of index for account.move, but still there are some missing left, so this commit is to add the index btree_not_null for those one. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166887
- Before this commit One using an Input Method Editor (i.e. for writing hiraganas) could potentially trigger an hotkey, which does not make any sense. - After this commit While an IME is still composing, the hotkey service will ignore. opw-3633735 Forward-Port-Of: odoo/odoo#165229
Original PR description
- Before this commit One using an Input Method Editor (i.e. for writing hiraganas) could potentially trigger an hotkey, which does not make any sense. - After this commit While an IME is still composing, the hotkey service will ignore. opw-3633735 Forward-Port-Of: odoo/odoo#165229