Monday, June 3, 2024
13 changes · 17.0
Resolved issues and error corrections
This fix updates the expense app’s automated tour so it works correctly in community nightly checks, not just enterprise setups. It helps keep release validation stable and prevents false failures in testing pipelines.
Original PR description
Since #164960, the new tour is failing on community nightly runs as the "go to app" steps were only setup for the enterprise version runbot-66550 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix adds the missing VAT credit and VAT debt accounts to specific Italian tax repartition lines. It helps ensure Italian VAT postings are recorded to the correct accounts, reducing manual corrections and improving accounting accuracy.
Original PR description
For +100 on 5v: 160100 VAT credit For -100 on 4v: 260100 VAT debt task-3940102 opw-3938527
Public holidays linked to working hours now appear correctly in the Time Off dashboard legend for the current user. The fix ensures the system falls back to the logged-in user's employee record when no valid employee is provided, preventing missing holiday information.
Original PR description
Steps to reproduce: - Install Time off module - Create a public holiday with Working Hours 'calendar_id' - Go to env user Time off dashboard Current behavior before PR: The public holidays that has…
Steps to reproduce:
- Install Time off module
- Create a public holiday with Working Hours 'calendar_id'
- Go to env user Time off dashboard
Current behavior before PR:
The public holidays that has 'calendar_id' assigned to it will not be shown in Legend when checking the dashboard of the env user. This is happening because we assign the self 'hr.employee' with the employee_id in context https://github.com/odoo/odoo/blob/c6142d9f1432cfabedcaa7264af9e5bc8e538c20/addons/hr_holidays/models/hr_employee.py#L313 and in '_get_contextual_employee' we just check if employee_id exists in ctx or not
https://github.com/odoo/odoo/blob/17.0/addons/hr_holidays/models/hr_employee.py#L388:L392
but we don't check the value so if ctx is like {'employee_id': None} it will return None.
Desired behavior after PR is merged:
We are now checking if the 'employee_id' in ctx
has a valid value as if it is not we need to return the employee object of the env user.
Other solution that we can add in this line https://github.com/odoo/odoo/blob/c6142d9f1432cfabedcaa7264af9e5bc8e538c20/addons/hr_holidays/models/hr_employee.py#L313 to check if the self._get_contetxtual_employee is None we assign self to self.env.user.employee_id
opw-3863947The online shop test flow was split into separate parts to avoid timing issues during cart updates and payment validation. This helps ensure checkout behavior is tested reliably without false failures, supporting more stable releases.
Original PR description
Tour 'shop_buy_product' checks the correctness of manipulating products and their quantities in the cart and the payment step of the order. With the additional check on the payment step introduced by commit 023d549 the tour was failing due to the relatively late rpc request handling compared to immediate clicks of the tour. `shop/payment` page was rendered faster than the update cart rpc (`shop/cart/update_json`) was processed. Cart update resets the delivery method on the order causing the validation error. That is why the tour is split in 2 separate functional parts.
This fixes an error that could appear when a user edited a product description and then discarded the record. The editor now waits for pending changes to finish before closing, preventing a disruptive crash message.
Original PR description
Steps: - Install sale and editor apps. - Click on varient new button. - Add something in the description. - Discard that record. Issue: - Traceback component destroyed. Cause: - `commit_changes` does not had await on it and because of that it was performing other operations before actually commit changes and we are actully destroying record in `commit_changes` so there is no point doing other operations. Fix: - Add await and remove urgent from `commit_changes` method in-order to properly unmount component. opw-3892602 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The point of sale now skips the product configuration popup when a product has no real choices to make. This removes an unnecessary step for cashiers and makes checkout smoother.
Original PR description
This commit addresses the issue where the Product Configurator Popup was displayed unnecessarily when there was only one value for each attribute of a product. The implementation now includes a check to ensure that the popup is shown only when there are more that one choices available. This enhancement improves the user experience by avoiding the display of a redundant popup without viable options. opw-3903425 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The event exhibitor display now keeps the sponsor level badge inline after the sponsor name, even when the name is long. This improves readability and gives event pages a cleaner, more consistent presentation for visitors.
Original PR description
Ensures that the exhibitor level badge is correctly displayed, as it was shown on a separate column for longer sponsor names. Now, it always appears inline, after the name of the sponsor. Task-3874059
The industry list view now avoids opening invalid records that caused confusing errors. Users can still access details through a dedicated More Info action, making browsing industries more reliable.
Original PR description
[FIX] base_import_module: fix the tree view Steps to Reproduce: When we click on tree view of industry its showing the error that can't fetch record they might have been deleted. Issue: In Kanban, it works because we passed the context on the xml side, however in the tree view, we can't access those contexts, and because the modules aren't stored, we only get the resId as -1. Fix: So we restricted the click and no redirect on the tree view, and as an alternative, we introduced a More Info button that redirects us to the form view. Task - 3834095
Planning users can now copy a previous week again after deleting an earlier copied schedule. This prevents an error that blocked re-copying and helps teams quickly rebuild schedules when they remove a copied version by mistake.
Original PR description
To reproduce: ============= - on Planning > copy previous week - delete the copy - press the copy button again -> error Problem: ======== - the slot record has field `was_copied` that prevents duplicating the slot more than once, but when deleting the copy, the field is not reset Solution: ========= - reset the field `was_copied` when the copy is deleted opw-3874283
This update fixes how test dates are handled in Mexico's electronic invoicing (EDI) system. Previously, test files contained hardcoded dates that could become outdated. Now the system uses dynamic dates that update automatically, and test validations properly ignore date variations to ensure tests remain reliable over time.
This update fixes an error message that appears when Amazon sales order picking synchronization fails. The improvement ensures users receive clearer, more accurate feedback when issues occur during the order fulfillment process with Amazon integration, helping teams quickly identify and resolve synchronization problems.
Original PR description
See also: https://github.com/odoo/odoo/pull/167738
The Planning app's view menu order has been reorganized to prioritize the most commonly used views. Gantt, Pivot, and Graph views are now positioned after Kanban and List views, improving the user experience by making frequently accessed views more prominent.
Original PR description
Previously, Gantt, Pivot, and Graph views were listed before Kanban and List views. In this commit, we've reordered based on priority. Upgrade script: No upgrade script is required as we've updated records added in this version task-3902382 Forward-Port-Of: odoo/enterprise#61834
This update removes an unnecessary work location column from the employee list view when the homeworking module is active. Since remote workers don't have a single physical work location, this column is now hidden to reduce clutter and improve the clarity of employee information displays.
Original PR description
Removed a work location column in the employee list view that is not relevant when the homeworking module is installed. Task-3933447 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr